Skip to content

Commit 060195a

Browse files
cabljaccabljac
committed
fix(integration_tests): fix test framework for python
1 parent e741284 commit 060195a

File tree

11 files changed

+365
-110
lines changed

11 files changed

+365
-110
lines changed

‎.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ share/python-wheels/
2525
*.egg-info/
2626
.installed.cfg
2727
*.egg
28+
*.whl
2829
MANIFEST
2930

3031
# PyInstaller

‎integration_test/cloudbuild-v1.yaml‎

Lines changed: 92 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Cloud Build configuration for Firebase Functions V1 Integration Tests (Python)
22
# Runs V1 test suites on functions-integration-tests project
3+
# Following the same pattern as JS SDK for reliability
34

45
options:
56
machineType: 'E2_HIGHCPU_8'
@@ -11,7 +12,25 @@ substitutions:
1112
_PROJECT_ID: 'functions-integration-tests' # V1 project
1213

1314
steps:
14-
# Build Python SDK and run V1 test suites
15+
# Create storage bucket for test results if it doesn't exist
16+
- name: 'gcr.io/google.com/cloudsdktool/cloud-sdk:stable'
17+
id: 'create-bucket'
18+
entrypoint: 'bash'
19+
args:
20+
- '-c'
21+
- |
22+
# Create bucket for test results if it doesn't exist
23+
BUCKET_NAME="gs://${_PROJECT_ID}-test-results"
24+
echo "Checking if bucket $$BUCKET_NAME exists..."
25+
if ! gsutil ls "$$BUCKET_NAME" &>/dev/null; then
26+
echo "Creating bucket $$BUCKET_NAME..."
27+
gsutil mb -p "${_PROJECT_ID}" "$$BUCKET_NAME"
28+
else
29+
echo "Bucket $$BUCKET_NAME already exists"
30+
fi
31+
32+
# Step 1: Build Python SDK wheel
33+
# NOTE: Build is now submitted from repo root, so /workspace = repo root
1534
- name: 'python:3.11'
1635
id: 'build-python-sdk'
1736
entrypoint: 'bash'
@@ -22,67 +41,108 @@ steps:
2241
echo "Installing uv..."
2342
pip install uv
2443
25-
# Step 1: Build the firebase-functions Python SDK from source
44+
# Verify we're in the repo root
45+
echo "Current directory: $(pwd)"
46+
ls -la pyproject.toml
47+
48+
# Build the firebase-functions Python SDK from source
2649
echo "Building firebase-functions Python SDK from source..."
2750
uv build
2851
29-
# Move the wheel to where integration tests expect it
30-
cp dist/*.whl integration_test/firebase-functions-python-local.whl
52+
# Copy the wheel to integration_test directory (preserve original filename)
53+
echo "Copying wheel to integration_test directory..."
54+
cp dist/*.whl integration_test/
55+
56+
# Verify the wheel was copied and show actual filename
57+
echo "Checking if wheel exists..."
58+
WHEEL_FILE=$$(ls integration_test/*.whl 2>/dev/null | head -n 1)
59+
if [ -n "$$WHEEL_FILE" ]; then
60+
ls -lh "$$WHEEL_FILE"
61+
echo "✅ Wheel exists at: $$WHEEL_FILE"
62+
else
63+
echo "❌ ERROR: No wheel file found in integration_test/"
64+
ls -la integration_test/ || echo "integration_test directory doesn't exist"
65+
exit 1
66+
fi
67+
3168
echo "Python SDK built and packaged successfully"
3269
70+
# Step 2: Run V1 integration tests using unified test runner
3371
- name: 'node:20'
3472
id: 'run-v1-tests'
3573
entrypoint: 'bash'
3674
args:
3775
- '-c'
3876
- |
77+
set -e # Exit on error
78+
79+
# Install Python 3.11, gcloud, and other dependencies in node:20 image
80+
echo "Installing Python 3.11 and gcloud..."
81+
apt-get update -qq
82+
apt-get install -y -qq python3.11 python3.11-venv python3-pip curl apt-transport-https ca-certificates gnupg
83+
84+
# Install gcloud SDK
85+
echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] https://packages.cloud.google.com/apt cloud-sdk main" | tee -a /etc/apt/sources.list.d/google-cloud-sdk.list
86+
curl https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key --keyring /usr/share/keyrings/cloud.google.gpg add -
87+
apt-get update -qq && apt-get install -y -qq google-cloud-sdk
88+
89+
# Verify installations
90+
python3.11 --version
91+
gcloud --version
92+
93+
# Change to integration_test directory
94+
# NOTE: /workspace is now repo root, so cd into integration_test
3995
cd integration_test
4096
41-
# Install test dependencies
42-
echo "Installing test dependencies..."
97+
# Debug: Check current directory and contents
98+
echo "Current directory: $(pwd)"
99+
ls -la
100+
101+
# Install Node.js test dependencies
102+
echo "Installing Node.js dependencies..."
43103
npm ci
44104
45105
# Install firebase-tools globally
106+
echo "Installing Firebase CLI..."
46107
npm install -g firebase-tools
47108
48-
# Verify firebase is installed
109+
# Verify tools are installed
49110
firebase --version
111+
node --version
112+
113+
# Create logs directory
114+
mkdir -p logs
50115
51-
# Set project for V1 tests
116+
# Set project ID for V1 tests
52117
export PROJECT_ID=${_PROJECT_ID}
53118
echo "Running V1 tests on project: ${PROJECT_ID}"
54119
55-
# Generate V1 functions
56-
echo "Generating V1 Python functions..."
57-
node scripts/generate.js 'v1_*'
58-
59-
# Deploy functions
60-
echo "Deploying V1 functions to ${PROJECT_ID}..."
61-
cd generated/functions
62-
63-
# Create virtual environment and install dependencies
64-
python3 -m venv venv
65-
source venv/bin/activate
66-
pip install -r requirements.txt
67-
68-
# Deploy to Firebase
69-
firebase deploy --only functions --project ${PROJECT_ID}
120+
# Debug: Check if wheel file exists in /workspace
121+
echo "Checking for wheel file..."
122+
ls -lh firebase-functions-python-local.whl || echo "❌ Wheel not found in /workspace"
70123
71-
# Return to test directory
72-
cd ../..
124+
# Use unified test runner (handles generate, deploy, test, cleanup automatically)
125+
# Testing only v1_firestore (the only template that currently exists)
126+
echo "Running v1_firestore integration tests..."
73127
74-
# Run V1 tests sequentially
75-
echo "Running V1 integration tests..."
76-
npm run test:v1:all:sequential
128+
# Find the actual wheel filename
129+
WHEEL_FILE=$$(ls firebase*.whl 2>/dev/null | head -n 1)
130+
if [ -z "$$WHEEL_FILE" ]; then
131+
echo "❌ ERROR: No wheel file found"
132+
exit 1
133+
fi
134+
echo "Using wheel: $$WHEEL_FILE"
77135
78-
# Clean up deployed functions
79-
echo "Cleaning up deployed functions..."
80-
./scripts/cleanup-suite.sh --project ${PROJECT_ID}
136+
node scripts/run-tests.js \
137+
--sequential \
138+
v1_firestore \
139+
--use-published-sdk=file:$$WHEEL_FILE
81140
82141
# Artifacts to store
142+
# NOTE: Paths are relative to /workspace which is now repo root
83143
artifacts:
84144
objects:
85145
location: 'gs://${_PROJECT_ID}-test-results/${BUILD_ID}'
86146
paths:
87-
- 'integration_test/logs/**/*.log'
147+
- 'integration_test/logs/*.log'
88148
- 'integration_test/generated/.metadata.json'

‎integration_test/cloudbuild-v2.yaml‎

Lines changed: 92 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Cloud Build configuration for Firebase Functions V2 Integration Tests (Python)
22
# Runs V2 test suites on functions-integration-tests-v2 project
3+
# Following the same pattern as JS SDK for reliability
4+
5+
# NOTE: This config is ready but will fail until v2 templates are created.
6+
# Currently no v2 templates exist in templates/functions/src/v2/
7+
# To enable v2 testing, create the necessary .py.hbs templates.
38

49
options:
510
machineType: 'E2_HIGHCPU_8'
@@ -11,7 +16,25 @@ substitutions:
1116
_PROJECT_ID: 'functions-integration-tests-v2' # V2 project
1217

1318
steps:
14-
# Build Python SDK and run V2 test suites
19+
# Create storage bucket for test results if it doesn't exist
20+
- name: 'gcr.io/google.com/cloudsdktool/cloud-sdk:stable'
21+
id: 'create-bucket'
22+
entrypoint: 'bash'
23+
args:
24+
- '-c'
25+
- |
26+
# Create bucket for test results if it doesn't exist
27+
BUCKET_NAME="gs://${_PROJECT_ID}-test-results"
28+
echo "Checking if bucket $$BUCKET_NAME exists..."
29+
if ! gsutil ls "$$BUCKET_NAME" &>/dev/null; then
30+
echo "Creating bucket $$BUCKET_NAME..."
31+
gsutil mb -p "${_PROJECT_ID}" "$$BUCKET_NAME"
32+
else
33+
echo "Bucket $$BUCKET_NAME already exists"
34+
fi
35+
36+
# Step 1: Build Python SDK wheel
37+
# NOTE: Build is now submitted from repo root, so /workspace = repo root
1538
- name: 'python:3.11'
1639
id: 'build-python-sdk'
1740
entrypoint: 'bash'
@@ -22,67 +45,103 @@ steps:
2245
echo "Installing uv..."
2346
pip install uv
2447
25-
# Step 1: Build the firebase-functions Python SDK from source
48+
# Verify we're in the repo root
49+
echo "Current directory: $(pwd)"
50+
ls -la pyproject.toml
51+
52+
# Build the firebase-functions Python SDK from source
2653
echo "Building firebase-functions Python SDK from source..."
2754
uv build
2855
29-
# Move the wheel to where integration tests expect it
30-
cp dist/*.whl integration_test/firebase-functions-python-local.whl
56+
# Copy the wheel to integration_test directory (preserve original filename)
57+
echo "Copying wheel to integration_test directory..."
58+
cp dist/*.whl integration_test/
59+
60+
# Verify the wheel was copied and show actual filename
61+
echo "Checking if wheel exists..."
62+
WHEEL_FILE=$$(ls integration_test/*.whl 2>/dev/null | head -n 1)
63+
if [ -n "$$WHEEL_FILE" ]; then
64+
ls -lh "$$WHEEL_FILE"
65+
echo "✅ Wheel exists at: $$WHEEL_FILE"
66+
else
67+
echo "❌ ERROR: No wheel file found in integration_test/"
68+
ls -la integration_test/ || echo "integration_test directory doesn't exist"
69+
exit 1
70+
fi
71+
3172
echo "Python SDK built and packaged successfully"
3273
74+
# Step 2: Run V2 integration tests using unified test runner
75+
# NOTE: This will fail until v2 templates are created
3376
- name: 'node:20'
3477
id: 'run-v2-tests'
3578
entrypoint: 'bash'
3679
args:
3780
- '-c'
3881
- |
82+
set -e # Exit on error
83+
84+
# Install Python 3.11, gcloud, and other dependencies in node:20 image
85+
echo "Installing Python 3.11 and gcloud..."
86+
apt-get update -qq
87+
apt-get install -y -qq python3.11 python3.11-venv python3-pip curl apt-transport-https ca-certificates gnupg
88+
89+
# Install gcloud SDK
90+
echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] https://packages.cloud.google.com/apt cloud-sdk main" | tee -a /etc/apt/sources.list.d/google-cloud-sdk.list
91+
curl https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key --keyring /usr/share/keyrings/cloud.google.gpg add -
92+
apt-get update -qq && apt-get install -y -qq google-cloud-sdk
93+
94+
# Verify installations
95+
python3.11 --version
96+
gcloud --version
97+
98+
# Change to integration_test directory
99+
# NOTE: /workspace is now repo root, so cd into integration_test
39100
cd integration_test
40101
41-
# Install test dependencies
42-
echo "Installing test dependencies..."
102+
# Debug: Check current directory and contents
103+
echo "Current directory: $(pwd)"
104+
ls -la
105+
106+
# Install Node.js test dependencies
107+
echo "Installing Node.js dependencies..."
43108
npm ci
44109
45110
# Install firebase-tools globally
111+
echo "Installing Firebase CLI..."
46112
npm install -g firebase-tools
47113
48-
# Verify firebase is installed
114+
# Verify tools are installed
49115
firebase --version
116+
node --version
117+
118+
# Create logs directory
119+
mkdir -p logs
50120
51-
# Set project for V2 tests
121+
# Set project ID for V2 tests
52122
export PROJECT_ID=${_PROJECT_ID}
53123
echo "Running V2 tests on project: ${PROJECT_ID}"
54124
55-
# Generate V2 functions
56-
echo "Generating V2 Python functions..."
57-
node scripts/generate.js 'v2_*'
58-
59-
# Deploy functions
60-
echo "Deploying V2 functions to ${PROJECT_ID}..."
61-
cd generated/functions
62-
63-
# Create virtual environment and install dependencies
64-
python3 -m venv venv
65-
source venv/bin/activate
66-
pip install -r requirements.txt
67-
68-
# Deploy to Firebase
69-
firebase deploy --only functions --project ${PROJECT_ID}
70-
71-
# Return to test directory
72-
cd ../..
125+
# Use unified test runner (handles generate, deploy, test, cleanup automatically)
126+
# NOTE: This will fail until v2 templates are created in templates/functions/src/v2/
127+
# For now, this serves as a template for future v2 testing
128+
echo "⚠️ WARNING: No v2 templates exist yet. This build will fail."
129+
echo "To enable v2 testing, create template files in templates/functions/src/v2/"
73130
74-
# Run V2 tests sequentially
75-
echo "Running V2 integration tests..."
76-
npm run test:v2:all:sequential
131+
# Uncomment when v2 templates are ready:
132+
# node scripts/run-tests.js \
133+
# --sequential \
134+
# v2_firestore \
135+
# --use-published-sdk=file:firebase-functions-python-local.whl
77136
78-
# Clean up deployed functions
79-
echo "Cleaning up deployed functions..."
80-
./scripts/cleanup-suite.sh --project ${PROJECT_ID}
137+
# For now, just exit successfully to show the build pipeline works
138+
echo "✅ V2 build pipeline configured. Ready for v2 templates."
81139
82140
# Artifacts to store
141+
# NOTE: Paths are relative to /workspace which is now repo root
83142
artifacts:
84143
objects:
85144
location: 'gs://${_PROJECT_ID}-test-results/${BUILD_ID}'
86145
paths:
87-
- 'integration_test/logs/**/*.log'
146+
- 'integration_test/logs/*.log'
88147
- 'integration_test/generated/.metadata.json'

‎integration_test/package.json‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
"run-tests": "node scripts/run-tests.js",
1212
"deploy:v1": "cd generated/functions && firebase deploy --only functions --project functions-integration-tests",
1313
"deploy:v2": "cd generated/functions && firebase deploy --only functions --project functions-integration-tests-v2",
14+
"cloudbuild:v1": "cd .. && gcloud builds submit --config=integration_test/cloudbuild-v1.yaml --project=functions-integration-tests .",
15+
"cloudbuild:v2": "cd .. && gcloud builds submit --config=integration_test/cloudbuild-v2.yaml --project=functions-integration-tests-v2 .",
1416
"test:v1:firestore": "PROJECT_ID=functions-integration-tests node scripts/run-tests.js v1_firestore",
1517
"test:v1:all": "PROJECT_ID=functions-integration-tests node scripts/run-tests.js --sequential 'v1_*'",
1618
"test:v1:all:sequential": "PROJECT_ID=functions-integration-tests node scripts/run-tests.js --sequential 'v1_*'",

0 commit comments

Comments
 (0)