-
Notifications
You must be signed in to change notification settings - Fork 424
fix(firestore-bigquery-export): add package & update exports #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @russellwheatley Do we have update on merging the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
firestore-bigquery-change-tracker:^1.1.2 does not have RawChangelogViewSchema
|
And since there is new dependency for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @russellwheatley ! Can you please
- Increment version of firestore-bigquery-change-tracker (it should be 1.1.4 since I just published 1.1.3)
- Increment version of gen-schema-view
- Mark this PR as "ready for review" if it is ready to be merged and the packages are ready to be published?
|
Pls merge this PR soon 🙇♂️ |
|
firestore-bigquery-change-tracker and gen-schema-view have both been updated on NPM. |
|
ERROR I am not sure if this is caused by the change but map type is no longer working. @russellwheatley any thoughts? |
|
If your Firestore document is structured like: Can you ensure your schema file is: Note the top level |
|
Thank you @laurenzlong. I tried to run with the format you shared with but it gave a different error.
It seems the script adds "_" whereas the schema generated from the Firestore export has the "." map notations e.g. mainImage.main is the correct field name where as "mainImage_main" does not exist. Is there a way to have the name generated by the firestore export. |
|
Hi @newadays could you please file a new Github issue for this? |
fixes #250
gen-schema-viewuses thefirestore-bigquery-change-trackerpackage script which is not specified in thepackage.json.fixes #196
RawChangelogViewSchemawas not exported out of thefirestore-bigquery-change-trackerpackage. This caused thefieldsproperty to beundefinedat this point in the code.Here's a screenshot of the

gen-schema-viewscript working again:Please note that the
gen-schema-viewpackage will still not work until this PR has been merged and thefirestore-bigquery-change-tracker&gen-schema-viewpackages have been published again.