Merge pull request #214 from firebase/next

March 3, 2020 Release

Author: Ashley Gau

.prettierignore

@@ -9,6 +9,7 @@ README.md
 **/functions/lib/**
 **/lib/**
 **/dist/**
+coverage
 
 # extension install md files
 #   - excluded as prettier escapes variables e.g. `${PROJECT_ID}` becomes `\${PROJECT_ID}`

.travis.yml

@@ -1,5 +1,9 @@
 language: node_js
 
+install:
+  - npm install -g codecov
+  - npm install
+
 node_js:
   - 8
   - 10
@@ -11,11 +15,10 @@ stages:
 
 jobs:
   include:
-    - stage: validate
-      name: "TypeScript Compile"
-      script: npm run clean && npm run build
     - stage: validate
       name: "Prettier Format Check"
       script: npm run lint
-    - stage: test
-      script: npm run test-coverage
+
+script:
+  - npm run test-coverage
+  - codecov

CONTRIBUTING.md

@@ -1,28 +1,60 @@
-# How to Contribute
+# Contributing
 
-We'd love to accept your patches and contributions to this project. There are
-just a few small guidelines you need to follow.
+It's great to receive contributions from the community! If you'd like to contribute to this project, make sure to review and follow the guidelines below.
 
 ## Contributor License Agreement
 
 Contributions to this project must be accompanied by a Contributor License
 Agreement. You (or your employer) retain the copyright to your contribution;
-this simply gives us permission to use and redistribute your contributions as
-part of the project. Head over to <https://cla.developers.google.com/> to see
+this agreement simply gives us permission to use and redistribute your contributions as
+part of the project. Head over to [https://cla.developers.google.com](https://cla.developers.google.com) to see
 your current agreements on file or to sign a new one.
 
 You generally only need to submit a CLA once, so if you've already submitted one
 (even if it was for a different project), you probably don't need to do it
 again.
 
-## Code reviews
+## Code and copy reviews
 
 All submissions, including submissions by project members, require review. We
 use GitHub pull requests for this purpose. Consult
 [GitHub Help](https://help.github.com/articles/about-pull-requests/) for more
 information on using pull requests.
 
-## Community Guidelines
+## Community guidelines
 
 This project follows [Google's Open Source Community
 Guidelines](https://opensource.google.com/conduct/).
+
+## Report an issue
+
+Report all issues through GitHub Issues using the [Report a Bug](https://github.com/firebase/extensions/issues/new?template=bug.md) template.
+
+To help resolve your issue as quickly as possible, read the template and provide all the requested information.
+
+## File a feature request
+
+We welcome all feature requests, whether it's to add new functionality to an existing extension or to offer an [idea for a brand new extension](https://firebase.google.com/support/troubleshooter/report/features/).
+
+Here's how to submit a feature request for an existing extension:
+
+1. File your feature request through GitHub Issues using the [Feature Request template](https://github.com/firebase/extensions/issues/new?template=fr.md).
+
+1. File a new [Firebase support request](https://firebase.google.com/support/troubleshooter/report/features/) via the Firebase website. Make sure to reference your feature request's GitHub Issue in the support ticket.
+
+## Create a pull request
+
+When making pull requests to the repository, make sure to follow these guidelines for both bug fixes and new features:
+
+- Before creating a pull request, file a GitHub Issue so that maintainers and the community can discuss the problem and potential solutions before you spend time on an implementation.
+- In your PR's description, link to any related issues or pull requests to give reviewers the full context of your change.
+- For commit messages, follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) format.
+  - For example, if you update documentation for a specific extension, your commit message might be: `docs(extension-name) updated installation documentation`.
+- For your PR to be merged:
+
+  - You must sign the [Google Contributor License Agreement](https://cla.developers.google.com/clas).
+  - All tests must pass.
+
+### Features
+
+Before creating pull requests for new features, first file a GitHub Issue describing the reasoning and motivation for the feature. This gives maintainers and the community the opportunity to provide feedback on your idea before implementing it.

auth-mailchimp-sync/extension.yaml

@@ -15,13 +15,13 @@
 name: auth-mailchimp-sync
 version: 0.1.0
 specVersion: v1beta
-displayName: Sync with Mailchimp
 
+displayName: Sync with Mailchimp
 description:
   Adds new users from Firebase Authentication to a specified Mailchimp audience.
 
 license: Apache-2.0
-billingRequired: true
+
 sourceUrl: https://github.com/firebase/extensions/tree/master/auth-mailchimp-sync
 releaseNotesUrl: https://github.com/firebase/extensions/blob/master/auth-mailchimp-sync/CHANGELOG.md
 
@@ -39,6 +39,8 @@ contributors:
     email: [email protected]
     url: https://github.com/ehesp
 
+billingRequired: true
+
 resources:
   - name: addUserToList
     type: firebaseextensions.v1beta.function
@@ -51,6 +53,7 @@ resources:
       eventTrigger:
         eventType: providers/firebase.auth/eventTypes/user.create
         resource: projects/${PROJECT_ID}
+
   - name: removeUserFromList
     type: firebaseextensions.v1beta.function
     description:

codecov.yml

@@ -0,0 +1,15 @@
+codecov:
+  require_ci_to_pass: yes
+
+coverage:
+  precision: 2
+  round: down
+  range: "40...100"
+
+  status:
+    project:
+      default: true
+
+comment:
+  layout: "reach, diff, files"
+  behavior: once

delete-user-data/extension.yaml

@@ -13,16 +13,16 @@
 # limitations under the License.
 
 name: delete-user-data
-displayName: Delete User Data
-specVersion: v1beta
 version: 0.1.3
+specVersion: v1beta
 
+displayName: Delete User Data
 description:
   Deletes data keyed on a userId from Cloud Firestore, Realtime Database, and/or
   Cloud Storage when a user deletes their account.
 
 license: Apache-2.0
-billingRequired: false
+
 sourceUrl: https://github.com/firebase/extensions/tree/master/delete-user-data
 releaseNotesUrl: https://github.com/firebase/extensions/blob/master/delete-user-data/CHANGELOG.md
 
@@ -40,6 +40,8 @@ contributors:
     email: [email protected]
     url: https://github.com/ehesp
 
+billingRequired: false
+
 roles:
   - role: datastore.owner
     reason: Allows the extension to delete (user) data from Cloud Firestore.

firestore-bigquery-export/CHANGELOG.md

@@ -1,3 +1,8 @@
+## Version 0.1.2
+
+fixed - Added "IF NOT EXISTS" to safely run `fs-bq-schema-views` script multiple times (PR #193).
+fixed - Updated BigQuery dependency in `package.json` for the `fs-bq-import-collection` script (issue #192 and PR #197).
+
 ## Version 0.1.1
 
 fixed - Fixed occasional duplicate rows created in the BigQuery backup table (issue #101).

firestore-bigquery-export/extension.yaml

@@ -13,15 +13,15 @@
 # limitations under the License.
 
 name: firestore-bigquery-export
-displayName: Export Collections to BigQuery
+version: 0.1.2
 specVersion: v1beta
-version: 0.1.1
 
+displayName: Export Collections to BigQuery
 description:
   Sends realtime, incremental updates from a specified Cloud Firestore collection to BigQuery.
 
 license: Apache-2.0
-billingRequired: true
+
 sourceUrl: https://github.com/firebase/extensions/tree/master/firestore-bigquery-export
 releaseNotesUrl: https://github.com/firebase/extensions/blob/master/firestore-bigquery-export/CHANGELOG.md
 
@@ -34,6 +34,8 @@ contributors:
     email: [email protected]
     url: https://github.com/IanWyszynski
 
+billingRequired: true
+
 apis:
   - apiName: bigquery-json.googleapis.com
     reason: Mirrors data from your Cloud Firestore collection in BigQuery.

firestore-bigquery-export/firestore-bigquery-change-tracker/package.json

@@ -22,13 +22,13 @@
   "author": "Jan Wyszynski <[email protected]>",
   "license": "Apache-2.0",
   "dependencies": {
-    "@google-cloud/bigquery": "^2.1.0",
+    "@google-cloud/bigquery": "^4.7.0",
     "firebase-admin": "^7.1.1",
     "firebase-functions": "^2.2.1",
-    "lodash": "^4.17.14",
-    "sql-formatter": "^2.3.3",
     "generate-schema": "^2.6.0",
-    "inquirer": "^6.4.0"
+    "inquirer": "^6.4.0",
+    "lodash": "^4.17.14",
+    "sql-formatter": "^2.3.3"
   },
   "devDependencies": {
     "chai": "^4.2.0",

firestore-bigquery-export/firestore-bigquery-change-tracker/src/bigquery/index.ts

@@ -24,7 +24,6 @@ import {
   FirestoreDocumentChangeEvent,
 } from "../tracker";
 import * as logs from "../logs";
-import { BigQuery } from "@google-cloud/bigquery";
 
 export interface FirestoreBigQueryEventHistoryTrackerConfig {
   datasetId: string;
@@ -51,9 +50,6 @@ export class FirestoreBigQueryEventHistoryTracker
 
   async record(events: FirestoreDocumentChangeEvent[]) {
     await this.initialize();
-    const options = {
-      raw: true,
-    };
     const rows = events.map((event) => {
       return {
         insertId: event.eventId,
@@ -66,23 +62,23 @@ export class FirestoreBigQueryEventHistoryTracker
         },
       };
     });
-    await this.insertData(rows, options);
+    await this.insertData(rows);
   }
 
   /**
    * Inserts rows of data into the BigQuery raw change log table.
    */
-  private async insertData(rows: bigquery.RowMetadata[], options: object) {
-    const payload = {
+  private async insertData(rows: bigquery.RowMetadata[]) {
+    const options = {
       skipInvalidRows: false,
       ignoreUnkownValues: false,
-      rows: rows,
+      raw: true,
     };
     try {
       const dataset = this.bq.dataset(this.config.datasetId);
       const table = dataset.table(this.rawChangeLogTableName());
       logs.dataInserting(rows.length);
-      await table.insert(payload, options);
+      await table.insert(rows, options);
       logs.dataInserted(rows.length);
     } catch (e) {
       // Reinitializing in case the destintation table is modified.