Skip to content

Commit 022bf89

Browse files
committed
test: update project ID & test secret flow
1 parent 658f4ae commit 022bf89

File tree

4 files changed

+16
-7
lines changed

4 files changed

+16
-7
lines changed

.github/workflows/test.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,21 @@ jobs:
2121
node-version: ${{ matrix.node }}
2222
cache: "npm"
2323
cache-dependency-path: "**/package-lock.json"
24-
- name: NPM INSTALL
24+
- name: npm install
2525
run: npm i
26-
- name: build emulator functions
26+
- name: Build emulator functions
2727
run: cd _emulator/functions && npm i && npm run build & cd ../..
28-
- name: Install firebase CLI
28+
- name: Install Firebase CLI
2929
uses: nick-invision/retry@v1
3030
with:
3131
timeout_minutes: 10
3232
retry_wait_seconds: 60
3333
max_attempts: 3
3434
command: npm i -g firebase-tools@11
35+
- name: Setup e2e secrets
36+
run: |
37+
cat << EOF > _emulator/extensions/firestore-send-email-sendgrid.secret.local
38+
SMTP_PASSWORD=${{ secrets.SENDGRID_API_KEY }}
39+
EOF
3540
- name: npm test
3641
run: npm run test:ci

_emulator/.firebaserc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"projects": {
3-
"default": "dev-extensions-testing"
3+
"default": "demo-test"
44
}
55
}

_emulator/extensions/firestore-send-email-sendgrid.env.local

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@ [email protected]
22
firebaseextensions.v1beta.function/location=us-central1
33
MAIL_COLLECTION=mail-sg
44
SMTP_CONNECTION_URI=smtps://[email protected]:465
5-
SMTP_PASSWORD=projects/794622217280/secrets/ext-firestore-send-email-sendgrid-SMTP_PASSWORD/versions/1
65
TTL_EXPIRE_TYPE=never
76
TTL_EXPIRE_VALUE=1

firestore-send-email/functions/__tests__/e2e.test.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { smtpServer } from "./createSMTPServer";
44
process.env.FIRESTORE_EMULATOR_HOST = "127.0.0.1:8080";
55

66
admin.initializeApp({
7-
projectId: "dev-extensions-testing",
7+
projectId: "demo-test",
88
});
99

1010
const mail = "mail";
@@ -165,13 +165,18 @@ describe("e2e testing", () => {
165165

166166
const doc = await mailSgCollection.add(record);
167167

168-
return new Promise((resolve) => {
168+
return new Promise((resolve, reject) => {
169169
const unsubscribe = doc.onSnapshot((snapshot) => {
170170
const document = snapshot.data();
171171
if (document.delivery && document.delivery.info) {
172172
expect(document.delivery.state).toEqual("SUCCESS");
173173
unsubscribe();
174174
resolve();
175+
} else {
176+
if (document.delivery && document.delivery.error) {
177+
unsubscribe();
178+
reject(document.delivery.error);
179+
}
175180
}
176181
});
177182
});

0 commit comments

Comments
 (0)