Add apphosting config interface to common. (#385)

- Add interfaces for the apphosting config, while sharing what can be shared with the bundle config
- remove unused and duplicate interfaces in adapter-angular
- Add 'Build' enum value for envvars availability. This was previously limited to "Runtime" because it was used only for bundle.yaml's envvars which are envvars set by the adapter after a build to be used for runtime. Now the envvars interface will be shared with the apphosting config

Author: annajowang

packages/@apphosting/adapter-angular/src/interface.ts

@@ -9,27 +9,6 @@ export interface OutputBundleOptions {
   needsServerGenerated: boolean;
 }
 
-// Environment variable schema for bundle.yaml outputted by angular adapter
-export interface EnvironmentVariable {
-  variable: string;
-  value: string;
-  availability: Availability.Runtime; // currently support RUNTIME only
-}
-
-// defines whether the environment variable is buildtime, runtime or both
-export enum Availability {
-  Buildtime = "BUILD",
-  Runtime = "RUNTIME",
-}
-
-// Metadata schema for bundle.yaml outputted by angular adapter
-export interface Metadata {
-  adapterPackageName: string;
-  adapterVersion: string;
-  framework: string;
-  frameworkVersion: string;
-}
-
 // valid manifest schema
 export interface ValidManifest {
   errors: string[];

packages/@apphosting/common/src/index.ts

@@ -2,9 +2,12 @@ import { spawn } from "child_process";
 import * as fs from "node:fs";
 import * as path from "node:path";
 
+
 // List of apphosting supported frameworks.
 export const SupportedFrameworks = ['nextjs', 'angular'];
 
+// **** OutputBundleConfig interfaces ****
+
 // Output bundle metadata specifications to be written to bundle.yaml
 export interface OutputBundleConfig {
   version: "v1";
@@ -44,9 +47,31 @@ export interface Metadata {
   frameworkVersion?: string;
 }
 
+// **** Apphosting Config interfaces ****
+
+export interface ApphostingConfig {
+  runconfig?: ApphostingRunConfig;
+  env?: EnvVarConfig[];
+  scripts?: Script;
+  outputFiles?: OutputFiles;
+}
+
+export interface ApphostingRunConfig {
+  minInstances?: number;
+  maxInstances?: number;
+  concurrency?: number;
+}
+
+export interface Script {
+  buildCommand?: string;
+  runCommand?: string;
+}
+
+// **** Shared interfaces ****
+
 // Optional outputFiles to configure outputFiles and optimize server files + static assets.
 // If this is not set then all of the source code will be uploaded
-interface OutputFiles {
+export interface OutputFiles {
   serverApp: ServerApp;
 }
 
@@ -62,14 +87,15 @@ export interface EnvVarConfig {
   variable: string;
   // Value associated with the variable
   value: string;
-  // Where the variable will be available, for now only RUNTIME is supported
-  availability: Availability.Runtime[];
+  // Where the variable will be available
+  availability: Availability[];
 }
 
 // Represents where environment variables are made available
 export enum Availability {
   // Runtime environment variables are available on the server when the app is run
   Runtime = "RUNTIME",
+  Build = "BUILD",
 }
 
 // Options to configure the build of a framework application