Skip to content

Commit 465d77e

Browse files
author
Alexander Konovalov
committed
Revert "semipperm.gi: fix RankOfPartialPermSemigroup for groups"
This reverts commit 16ec90c. The changed made there makes testinstall and teststandard fail when all packages are loaded, because it requires the new version of the Semigroups package.
1 parent 07b934f commit 465d77e

2 files changed

Lines changed: 5 additions & 8 deletions

File tree

lib/semipperm.gi

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,17 +94,17 @@ InstallMethod(CodegreeOfPartialPermSemigroup,
9494
s-> DegreeOfPartialPermSemigroup(s));
9595

9696
InstallMethod(RankOfPartialPermSemigroup,
97-
"for a partial perm semigroup with generators of semigroup",
97+
"for a partial perm semigroup",
9898
[IsPartialPermSemigroup and HasGeneratorsOfSemigroup],
9999
S -> RankOfPartialPermCollection(GeneratorsOfSemigroup(S)));
100100

101101
InstallMethod(RankOfPartialPermSemigroup,
102-
"for a partial perm monoid",
103-
[IsPartialPermMonoid],
104-
S -> RankOfPartialPerm(One(S)));
102+
"for a partial perm semigroup",
103+
[IsPartialPermSemigroup and HasGeneratorsOfGroup],
104+
S -> RankOfPartialPermCollection(GeneratorsOfGroup(S)));
105105

106106
InstallMethod(RankOfPartialPermCollection,
107-
"for a partial perm semigroup with generators of semigroup",
107+
"for a partial perm semigroup",
108108
[IsPartialPermSemigroup and HasGeneratorsOfSemigroup],
109109
s-> RankOfPartialPermCollection(GeneratorsOfSemigroup(s)));
110110

tst/testinstall/semipperm.tst

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@ gap> RankOfPartialPermSemigroup(S);
8686
gap> S := Group(PartialPerm([]));;
8787
gap> RankOfPartialPermSemigroup(S);
8888
0
89-
gap> S := Group([], PartialPerm([1, 2]));;
90-
gap> RankOfPartialPermSemigroup(S);
91-
2
9289

9390
# Test Domain/ImageOfPartialPermCollection/Semigroup
9491
gap> S := Semigroup(PartialPerm([1, 2, 3], [4, 5, 11]),

0 commit comments

Comments
 (0)