Skip to content

Commit 5562487

Browse files
committed
disable mplex stream muxer
1 parent 513a533 commit 5562487

4 files changed

Lines changed: 14 additions & 38 deletions

File tree

app/submodule/network/network_submodule.go

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77
"os"
88
"path/filepath"
99
"runtime"
10-
"strings"
1110
"time"
1211

1312
"github.com/ipfs/go-bitswap"
@@ -27,10 +26,8 @@ import (
2726
"github.com/libp2p/go-libp2p"
2827
"github.com/libp2p/go-libp2p-core/host"
2928
p2pmetrics "github.com/libp2p/go-libp2p-core/metrics"
30-
smux "github.com/libp2p/go-libp2p-core/mux"
3129
"github.com/libp2p/go-libp2p-core/routing"
3230
dht "github.com/libp2p/go-libp2p-kad-dht"
33-
mplex "github.com/libp2p/go-libp2p-mplex"
3431
libp2pps "github.com/libp2p/go-libp2p-pubsub"
3532
yamux "github.com/libp2p/go-libp2p-yamux"
3633
ma "github.com/multiformats/go-multiaddr"
@@ -112,7 +109,7 @@ type networkConfig interface {
112109
// NewNetworkSubmodule creates a new network submodule.
113110
func NewNetworkSubmodule(ctx context.Context, config networkConfig) (*NetworkSubmodule, error) {
114111
bandwidthTracker := p2pmetrics.NewBandwidthCounter()
115-
libP2pOpts := append(config.Libp2pOpts(), libp2p.BandwidthReporter(bandwidthTracker), makeSmuxTransportOption(true))
112+
libP2pOpts := append(config.Libp2pOpts(), libp2p.BandwidthReporter(bandwidthTracker), makeSmuxTransportOption())
116113

117114
var networkName string
118115
var err error
@@ -400,9 +397,8 @@ func buildHost(ctx context.Context, config networkConfig, libP2pOpts []libp2p.Op
400397
return libp2p.New(opts...)
401398
}
402399

403-
func makeSmuxTransportOption(mplexExp bool) libp2p.Option {
400+
func makeSmuxTransportOption() libp2p.Option {
404401
const yamuxID = "/yamux/1.0.0"
405-
const mplexID = "/mplex/6.7.0"
406402

407403
ymxtpt := *yamux.DefaultTransport
408404
ymxtpt.AcceptBacklog = 512
@@ -411,27 +407,5 @@ func makeSmuxTransportOption(mplexExp bool) libp2p.Option {
411407
ymxtpt.LogOutput = os.Stderr
412408
}
413409

414-
muxers := map[string]smux.Multiplexer{yamuxID: &ymxtpt}
415-
if mplexExp {
416-
muxers[mplexID] = mplex.DefaultTransport
417-
}
418-
419-
// Allow muxer preference order overriding
420-
order := []string{yamuxID, mplexID}
421-
if prefs := os.Getenv("LIBP2P_MUX_PREFS"); prefs != "" {
422-
order = strings.Fields(prefs)
423-
}
424-
425-
opts := make([]libp2p.Option, 0, len(order))
426-
for _, id := range order {
427-
tpt, ok := muxers[id]
428-
if !ok {
429-
networkLogger.Warnf("unknown or duplicate muxer in LIBP2P_MUX_PREFS: %s", id)
430-
continue
431-
}
432-
delete(muxers, id)
433-
opts = append(opts, libp2p.Muxer(id, tpt))
434-
}
435-
436-
return libp2p.ChainOptions(opts...)
410+
return libp2p.Muxer(yamuxID, ymxtpt)
437411
}

cmd/state.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ var stateWaitMsgCmd = &cmds.Command{
8282
writer.Printf("message was executed in tipset: %s\n", mw.TipSet.Cids())
8383
writer.Printf("Exit Code: %d\n", mw.Receipt.ExitCode)
8484
writer.Printf("Gas Used: %d\n", mw.Receipt.GasUsed)
85-
writer.Printf("Return: %x\n", mw.Receipt.ReturnValue)
85+
writer.Printf("Return: %x\n", mw.Receipt.Return)
8686
} else {
8787
writer.Printf("Unable to find message recepit of %s", cid)
8888
}

go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ require (
9292
github.com/libp2p/go-libp2p v0.17.0
9393
github.com/libp2p/go-libp2p-core v0.13.0
9494
github.com/libp2p/go-libp2p-kad-dht v0.15.0
95-
github.com/libp2p/go-libp2p-mplex v0.4.1
9695
github.com/libp2p/go-libp2p-peerstore v0.6.0
9796
github.com/libp2p/go-libp2p-pubsub v0.6.0
9897
github.com/libp2p/go-libp2p-swarm v0.9.0

pkg/messagepool/selection_test.go

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ import (
55
"context"
66
"encoding/json"
77
"fmt"
8-
"github.com/stretchr/testify/require"
9-
cbg "github.com/whyrusleeping/cbor-gen"
108
"io"
119
"math"
1210
"math/big"
@@ -15,6 +13,9 @@ import (
1513
"sort"
1614
"testing"
1715

16+
"github.com/stretchr/testify/require"
17+
cbg "github.com/whyrusleeping/cbor-gen"
18+
1819
"github.com/filecoin-project/go-address"
1920
tbig "github.com/filecoin-project/go-state-types/big"
2021
"github.com/filecoin-project/go-state-types/crypto"
@@ -577,7 +578,7 @@ func TestMessageSelectionTrimmingMsgsBasic(t *testing.T) {
577578

578579
// the actors
579580
w1 := newWallet(t)
580-
a1, err := w1.NewAddress(address.SECP256K1)
581+
a1, err := w1.NewAddress(context.Background(), address.SECP256K1)
581582
if err != nil {
582583
t.Fatal(err)
583584
}
@@ -616,16 +617,17 @@ func TestMessageSelectionTrimmingMsgsBasic(t *testing.T) {
616617

617618
func TestMessageSelectionTrimmingMsgsTwoSendersBasic(t *testing.T) {
618619
mp, tma := makeTestMpool()
620+
ctx := context.Background()
619621

620622
// the actors
621623
w1 := newWallet(t)
622-
a1, err := w1.NewAddress(address.SECP256K1)
624+
a1, err := w1.NewAddress(ctx, address.SECP256K1)
623625
if err != nil {
624626
t.Fatal(err)
625627
}
626628

627629
w2 := newWallet(t)
628-
a2, err := w2.NewAddress(address.BLS)
630+
a2, err := w2.NewAddress(ctx, address.BLS)
629631
if err != nil {
630632
t.Fatal(err)
631633
}
@@ -674,16 +676,17 @@ func TestMessageSelectionTrimmingMsgsTwoSendersBasic(t *testing.T) {
674676

675677
func TestMessageSelectionTrimmingMsgsTwoSendersAdvanced(t *testing.T) {
676678
mp, tma := makeTestMpool()
679+
ctx := context.Background()
677680

678681
// the actors
679682
w1 := newWallet(t)
680-
a1, err := w1.NewAddress(address.SECP256K1)
683+
a1, err := w1.NewAddress(ctx, address.SECP256K1)
681684
if err != nil {
682685
t.Fatal(err)
683686
}
684687

685688
w2 := newWallet(t)
686-
a2, err := w2.NewAddress(address.BLS)
689+
a2, err := w2.NewAddress(ctx, address.BLS)
687690
if err != nil {
688691
t.Fatal(err)
689692
}

0 commit comments

Comments
 (0)