Skip to content

Fix componentWillUpdate has been renamed warning #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix componentWillUpdate has been renamed warning #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,16 @@ export default class Lottie extends React.Component {
this.setAnimationControl();
}

componentWillUpdate(nextProps /* , nextState */) {
/* Recreate the animation handle if the data is changed */
if (this.options.animationData !== nextProps.options.animationData) {
this.deRegisterEvents(this.props.eventListeners);
componentDidUpdate(prevProps) {
if (prevProps.options.animationData !== this.props.options.animationData) {
Copy link

@chrisnojima chrisnojima Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is slightly incorrect. It should be this.options here and on line 45 instead of prevProps.options

Copy link
Author

@sidhantpanda sidhantpanda Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you write the if condition here?

this.deRegisterEvents(prevProps.eventListeners);
this.destroy();
this.options = { ...this.options, ...nextProps.options };
this.options = { ...prevProps.options, ...this.props.options };
this.anim = lottie.loadAnimation(this.options);
this.animApi = lottieApi.createAnimationApi(this.anim);
this.registerEvents(nextProps.eventListeners);
this.registerEvents(this.props.eventListeners);
}
}

componentDidUpdate() {

if (this.props.isStopped) {
this.stop();
} else if (this.props.segments) {
Expand Down