Make TypeScript HookMap and HooksObject interfaces generic.#1815
Merged
daffl merged 1 commit intofeathersjs:masterfrom Feb 25, 2020
Merged
Make TypeScript HookMap and HooksObject interfaces generic.#1815daffl merged 1 commit intofeathersjs:masterfrom
daffl merged 1 commit intofeathersjs:masterfrom
Conversation
Member
|
Makes sense, thank you! |
daffl
pushed a commit
that referenced
this pull request
Feb 25, 2020
This was referenced Mar 7, 2020
Merged
This was referenced Mar 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made the
HookMapandHooksObjectinterfaces generic. Beyond adding options for one to specify types for the associatedHookContext, this helps a lot with the reusability of these interfaces.