Skip to content

Commit 77e14dd

Browse files
authored
fix(knex): The method getModel in the knex adapter (#3043)
1 parent 5380a5c commit 77e14dd

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

packages/knex/src/adapter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export class KnexAdapter<
6363
return this.getModel()
6464
}
6565

66-
getModel(params?: ServiceParams) {
66+
getModel(params: ServiceParams = {} as ServiceParams) {
6767
const { Model } = this.getOptions(params)
6868
return Model
6969
}

packages/knex/test/overrides.test.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,4 +122,11 @@ describe('Feathers Knex Overridden Method With Self-Join', () => {
122122

123123
assert.strictEqual(patchedAnimal.name, newName)
124124
})
125+
126+
it('get the service model (getModel)', async () => {
127+
const model = animalService.Model
128+
const options = animalService.options
129+
130+
assert.strictEqual(model, options.Model)
131+
})
125132
})

0 commit comments

Comments
 (0)