docs: Add src/ directory to TypeScript starters #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agitated-mahavira-26f8f9 canceled.
|
onlywei
commented
May 3, 2025
| writeFileSync(join(starterRoot, starter, 'package.json'), JSON.stringify(pkgJSON, null, 2)) | ||
| } | ||
| cd(root) | ||
| await $`pnpm i` |
Collaborator
Author
There was a problem hiding this comment.
This is needed to get the optionalDependencies out of pnpm-lock.yaml
Collaborator
Author
|
@galvez hmmm, if we look at the CI results, it doesn't look like the tests are running for all the examples and starters in CI. I ran them locally, but I think we need to fix this. |
onlywei
added a commit
that referenced
this pull request
May 3, 2025
* fix: Remove optionalDependencies from @fastify/vite (#257) * docs: rm outdated info * docs: update roadmap * docs: update known limitations * docs: update section on route location * chore: fix pnpm-lock.yaml * Import meta dirname filename (#263) * Use import.meta.dirname instead of import.meta.url * Use import.meta.filename * undo changes in contrib folder * Fix some stuff I missed * Add src/ directory to TypeScript starters (#264) * Bump @fastify/[email protected] --------- Co-authored-by: Jonas Galvez <[email protected]>
onlywei
changed the title
onlywei
added a commit
that referenced
this pull request
Aug 4, 2025
* fix: Remove optionalDependencies from @fastify/vite (#257) * docs: rm outdated info * docs: update roadmap * docs: update known limitations * docs: update section on route location * chore: fix pnpm-lock.yaml * Import meta dirname filename (#263) * Use import.meta.dirname instead of import.meta.url * Use import.meta.filename * undo changes in contrib folder * Fix some stuff I missed * Add src/ directory to TypeScript starters (#264) * Bump @fastify/[email protected] * fix: install tsx into react/vue starters for typescript * fix: set allowJs to false in starters' tsconfig.json files * Bump @fastify/[email protected] * Run pnpm prep-for-release --------- Co-authored-by: Jonas Galvez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
src/directory to both typescript starters to match the examples folders.Checklist
npm run testandnpm run benchmarkand the Code of conduct