fix: remove optionalDependencies from @fastify/vite

[onlywei]

npm always tries to install transitive optionalDependencies by default, even if you don't need or use them.

This means that every time someone does npm i @fastify/vite, they will also result install these other packages into their node_modules directory, unless they explicitly run npm i @fastify/vite --omit=optional.

This is not only wasteful of our users' HDD space, but it also can cause weird issues with tools like snyk. For example, when I installed @fastify/vite, it came with @fastify/htmx, but it did not come with the dependencies of @fastify/htmx. Specifically, the @kitajs/html was not installed. snyk didn't know what to do in this situation -- it saw @kitajs/html in package-lock.json but didn't find it in node_modules, so it thought my package-lock.json was out of sync with my package.json and threw an error.

Is there any advantage we gain from adding these things in optionalDependencies? If not, I think it's best to just delete them.

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[netlify]

✅ Deploy Preview for agitated-mahavira-26f8f9 canceled.

Name	Link
🔨 Latest commit	441a77e
🔍 Latest deploy log	https://app.netlify.com/sites/agitated-mahavira-26f8f9/deploys/681561f67ab06e000813449a

[galvez]

Can you update package.mjs to include/remove optionalDependencies — they're required for dev.

[onlywei]

Can you update package.mjs to include/remove optionalDependencies — they're required for dev.

I don't see any mention of optionalDependencies in package.mjs

[galvez]

There isn't, since they were part of @fastify/vite's package.json — the setup worked for both releases and development. Since there's a problem with keeping them on the release, the prep-for-dev script should add them to @fastify/vite's package.json, and the prep-for-release script should remove them.

[onlywei]

There isn't, since they were part of @fastify/vite's package.json — the setup worked for both releases and development. Since there's a problem with keeping them on the release, the prep-for-dev script should add them to @fastify/vite's package.json, and the prep-for-release script should remove them.

What's the reason they're needed for development?

[galvez]

When developing the starters, somehow, local @fastify/react and @fastify/vue will fail to be picked up unless they're listed in @fastify/vite.

[zanmato]

It's because the renderer is being passed by string to fastify/vite which can't resolve it. If we pass it like this it'll work, and we can remove the optional dependencies,

await server.register(FastifyVite, {
  root: import.meta.url,
  renderer: import.meta.resolve('@fastify/vue'),
})

[zanmato]

We should update the ci file to also run test on main I guess, this PR bypassed them

[onlywei]

Alrighty. @zanmato @galvez I switched to import.meta.resolve as suggested.

[galvez]

No, please, that's unnecessary complexity. I'm okay with using import.meta.resolve() in development mode, but it certainly shouldn't be seen in the docs. Mind if I update directly in this branch @onlywei?