Improve device detection: Nokia

faisalman · faisalman · commit 4c935c0139c1 · 2025-10-06T22:07:35.000+07:00
diff --git a/src/main/ua-parser.js b/src/main/ua-parser.js
@@ -658,7 +658,7 @@
             /(nokia) (t[12][01])/i
             ], [VENDOR, MODEL, [TYPE, TABLET]], [
             /(?:maemo|nokia).*(n900|lumia \d+|rm-\d+)/i,
-            /nokia[-_ ]?(([-\w\. ]*))/i
+            /nokia[-_ ]?(([-\w\. ]*?))( bui|\)|;|\/)/i
             ], [[MODEL, /_/g, ' '], [TYPE, MOBILE], [VENDOR, 'Nokia']], [
 
             // Google
diff --git a/test/data/ua/device/nokia.json b/test/data/ua/device/nokia.json
@@ -1,4 +1,13 @@
 [
+    {
+        "desc": "Nokia 1",
+        "ua": "Mozilla/5.0 (Linux; Android 10; Nokia 1 Build/QP1A.190711.020) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.5304.15 Mobile Safari/537.36",
+        "expect": {
+            "vendor": "Nokia",
+            "model": "1",
+            "type": "mobile"
+        }
+    },
     {
         "desc": "Nokia3xx",
         "ua": "Nokia303/14.87 CLDC-1.1",

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,13 @@`
`1`	`1`	`[`
	`2`	`+ {`
	`3`	`+ "desc": "Nokia 1",`
	`4`	`+ "ua": "Mozilla/5.0 (Linux; Android 10; Nokia 1 Build/QP1A.190711.020) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.5304.15 Mobile Safari/537.36",`
	`5`	`+ "expect": {`
	`6`	`+ "vendor": "Nokia",`
	`7`	`+ "model": "1",`
	`8`	`+ "type": "mobile"`
	`9`	`+ }`
	`10`	`+ },`
`2`	`11`	`{`
`3`	`12`	`"desc": "Nokia3xx",`
`4`	`13`	`"ua": "Nokia303/14.87 CLDC-1.1",`