Fix building on mingw (#4420)

JAicewizard · facebook-github-bot · commit ee9d18a27e6e · 2025-07-07T12:22:33.000-07:00
Summary: This restores the ability to compile with mingw introduced in #4145. I am not sure why msvc does allow this, but using the `_FMT` macro without any `vaargs` causes a trailing comma in the arguments list. which is not allowed in c++. This switches it over to the `_MSG` macro instead avoiding this issue. Pull Request resolved: #4420 Reviewed By: pankajsingh88 Differential Revision: D77827581 Pulled By: ramilbakhshyiev fbshipit-source-id: f63564546511e88084dbacc71458448d3c403de9
diff --git a/faiss/impl/mapped_io.cpp b/faiss/impl/mapped_io.cpp
@@ -168,12 +168,12 @@ struct MmappedFileMappingOwner::PImpl {
         const int fd = _fileno(f);
         if (fd == -1) {
             // no good
-            FAISS_THROW_FMT("could not get a HANDLE");
+            FAISS_THROW_MSG("could not get a HANDLE");
         }
 
         HANDLE file_handle = (HANDLE)_get_osfhandle(fd);
         if (file_handle == INVALID_HANDLE_VALUE) {
-            FAISS_THROW_FMT("could not get an OS HANDLE");
+            FAISS_THROW_MSG("could not get an OS HANDLE");
         }
 
         // get the size of the file

Original file line number	Diff line number	Diff line change
`@@ -168,12 +168,12 @@ struct MmappedFileMappingOwner::PImpl {`
`168`	`168`	`const int fd = _fileno(f);`
`169`	`169`	`if (fd == -1) {`
`170`	`170`	`// no good`
`171`		`- FAISS_THROW_FMT("could not get a HANDLE");`
	`171`	`+ FAISS_THROW_MSG("could not get a HANDLE");`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`HANDLE file_handle = (HANDLE)_get_osfhandle(fd);`
`175`	`175`	`if (file_handle == INVALID_HANDLE_VALUE) {`
`176`		`- FAISS_THROW_FMT("could not get an OS HANDLE");`
	`176`	`+ FAISS_THROW_MSG("could not get an OS HANDLE");`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`// get the size of the file`