Allow indentation beyond one level deeper than block above. #762
Conversation
Also don't require there to even be a block above to begin indenting.
|
Thanks for adding this! It seems fine to make this change, and I really like that we did it by only deleting code. I'd like to have some tests to go with this, but that could be done in a follow-up. Just like for any PR we want to merge, the first step is for me to pull it into Facebook's codebase. Since this presents a change in default behavior, I would like to do some manual testing and verify that we can maintain the restricted nesting for products where that is desirable. I don't expect problems there though. |
flarnie
left a comment
flarnie
left a comment
There was a problem hiding this comment.
Adding this to my queue for merging - thanks for the fix! :)
|
@flarnie this still being merged I assume? |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@flarnie is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: **Summary** Solves facebookarchive/draft-js#270. Removes restriction on indenting beyond one level deeper than the block above. Also allows indenting the very first item in a list. And all I had to do was delete code!  **Test Plan** 1. Try indenting the first item in a list. 2. Try indenting a list item more than one level deeper than the item above it. Closes facebookarchive/draft-js#762 Differential Revision: D7137964 fbshipit-source-id: 597732b363537e34a0f466c3188f334b3fa30a9e
Summary: **Summary** Solves facebookarchive/draft-js#270. Removes restriction on indenting beyond one level deeper than the block above. Also allows indenting the very first item in a list. And all I had to do was delete code!  **Test Plan** 1. Try indenting the first item in a list. 2. Try indenting a list item more than one level deeper than the item above it. Closes facebookarchive/draft-js#762 Differential Revision: D7137964 fbshipit-source-id: 597732b363537e34a0f466c3188f334b3fa30a9e
5 participants
Summary
Solves #270. Removes restriction on indenting beyond one level deeper than the block above. Also allows indenting the very first item in a list. And all I had to do was delete code!
Test Plan