This repository was archived by the owner on Feb 6, 2023. It is now read-only.
docs: in react hooks example, limit createEmpty calls #2432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the React hooks example, EditorState.createEmpty will be called each time the component is rendered. By wrapping it in a function, it will only be called once per instance of the MyEditor component.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
…e#2432) Summary: In the React hooks example, `EditorState.createEmpty` will be called each time the component is rendered. By wrapping it in a function, it will only be called once per instance of the MyEditor component. Pull Request resolved: facebookarchive#2432 Reviewed By: claudiopro Differential Revision: D21652207 Pulled By: mrkev fbshipit-source-id: 0c24a4e84718227b4e89d1c810b2558ffd51384d
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: In the React hooks example, `EditorState.createEmpty` will be called each time the component is rendered. By wrapping it in a function, it will only be called once per instance of the MyEditor component. Pull Request resolved: facebookarchive/draft-js#2432 Reviewed By: claudiopro Differential Revision: D21652207 Pulled By: mrkev fbshipit-source-id: 0c24a4e84718227b4e89d1c810b2558ffd51384d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the React hooks example,
EditorState.createEmptywill be called each time the component is rendered. By wrapping it in a function, it will only be called once per instance of the MyEditor component.