This repository was archived by the owner on Feb 6, 2023. It is now read-only.
0.10.5 #1619
Closed
0.10.5 #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm shipping this asap - feel free to request changes to the |
| * Fix `cannot read property 'update' of undefined` error that was thrown when | ||
| typing same character into selection that starts with that character. ([@existentialism](https://github.com/existentialism) in | ||
| [#1512](https://github.com/facebook/draft-js/pull/1512)) | ||
| * Fix `encodeRawBlocks` to handle non-contiguous entities. Entities should |
Contributor
There was a problem hiding this comment.
nit: Entities should always be contigious -> contiguous...
Contributor
Author
There was a problem hiding this comment.
Thanks! Will fix in a follow-up - don't want to make CI restart, it is already taking forever-and-a-half.
mitermayer
approved these changes
Jan 20, 2018
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@flarnie is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: It's time for a release~! πβ¨οΏ½ Closes facebookarchive/draft-js#1619 Differential Revision: D6768509 fbshipit-source-id: 7543cee5b746611cfefb89dfeb175e5b2f90fcb0
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: It's time for a release~! πβ¨οΏ½ Closes facebookarchive/draft-js#1619 Differential Revision: D6768509 fbshipit-source-id: 7543cee5b746611cfefb89dfeb175e5b2f90fcb0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time for a release~! πβ¨π¦