Replace instanceof checks with nodeType checks

Author: acusti

src/component/base/DraftEditor.react.js

@@ -374,15 +374,15 @@ class DraftEditor extends React.Component<DraftEditorProps, State> {
 
     const scrollParent = Style.getScrollParent(editorNode);
     const {x, y} = scrollPosition || getScrollPosition(scrollParent);
-    const {defaultView} = editorNode.ownerDocument;
 
     invariant(
-      editorNode instanceof HTMLElement,
-      'editorNode is not an HTMLElement',
+      editorNode.nodeType === 1,
+      'editorNode is not an Element',
     );
     editorNode.focus();
 
     // Restore scroll position
+    const {defaultView} = editorNode.ownerDocument;
     if (scrollParent === defaultView) {
       defaultView.scrollTo(x, y);
     } else {
@@ -406,8 +406,8 @@ class DraftEditor extends React.Component<DraftEditorProps, State> {
   _blur(): void {
     const editorNode = ReactDOM.findDOMNode(this.refs.editor);
     invariant(
-      editorNode instanceof HTMLElement,
-      'editorNode is not an HTMLElement',
+      editorNode.nodeType === 1,
+      'editorNode is not an Element',
     );
     editorNode.blur();
   }

src/component/contents/DraftEditorBlock.react.js

@@ -113,8 +113,8 @@ class DraftEditorBlock extends React.Component<Props> {
       }
     } else {
       invariant(
-        blockNode instanceof HTMLElement,
-        'blockNode is not an HTMLElement',
+        blockNode.nodeType === 1,
+        'blockNode is not an Element',
       );
       var blockBottom = blockNode.offsetHeight + blockNode.offsetTop;
       var scrollBottom = scrollParent.offsetHeight + scrollPosition.y;

src/component/contents/DraftEditorTextNode.react.js

@@ -71,7 +71,7 @@ class DraftEditorTextNode extends React.Component<Props> {
   shouldComponentUpdate(nextProps: Props): boolean {
     const node = ReactDOM.findDOMNode(this);
     const shouldBeNewline = nextProps.children === '';
-    invariant(node instanceof Element, 'node is not an Element');
+    invariant(node.nodeType === 1, 'node is not an Element');
     if (shouldBeNewline) {
       return !isNewline(node);
     }

src/component/handlers/edit/editOnSelect.js

@@ -30,8 +30,8 @@ function editOnSelect(editor: DraftEditor): void {
   const editorNode = ReactDOM.findDOMNode(editor.refs.editorContainer);
   invariant(editorNode, 'Missing editorNode');
   invariant(
-    editorNode.firstChild instanceof HTMLElement,
-    'editorNode.firstChild is not an HTMLElement',
+    editorNode.firstChild.nodeType === 1,
+    'editorNode.firstChild is not an Element',
   );
   var documentSelection = getDraftEditorSelection(
     editorState,

src/component/selection/findAncestorOffsetKey.js

@@ -20,7 +20,7 @@ var getSelectionOffsetKeyForNode = require('getSelectionOffsetKeyForNode');
  */
 function findAncestorOffsetKey(node: Node): ?string {
   let searchNode = node;
-  while (searchNode && searchNode !== searchNode.ownerDocument.documentElement) {
+  while (searchNode && searchNode.nodeName !== 'HTML') {
     var key = getSelectionOffsetKeyForNode(searchNode);
     if (key != null) {
       return key;

src/component/selection/getDraftEditorSelectionWithNodes.js

@@ -156,9 +156,9 @@ function getPointForNonTextNode(
   // wrapper.
   if (editorRoot === node) {
     node = node.firstChild;
-    var win = node && node.ownerDocument.defaultView;
     invariant(
-      win && node instanceof win.Element && node.getAttribute('data-contents') === 'true',
+      node && node.nodeType === 1 && typeof node.getAttribute === 'function' &&
+      node.getAttribute('data-contents') === 'true',
       'Invalid DraftEditorContents structure.',
     );
     if (childOffset > 0) {

src/component/selection/getSelectionOffsetKeyForNode.js

@@ -18,14 +18,14 @@
  * found on the DOM tree of given node.
  */
 function getSelectionOffsetKeyForNode(node: Node): ?string {
-  var win = node.ownerDocument.defaultView;
-  if (win && node instanceof win.Element) {
-    var offsetKey = node.getAttribute('data-offset-key');
+  if (node.nodeType === 1) {
+    var element: Element = (node: any);
+    var offsetKey = element.getAttribute('data-offset-key');
     if (offsetKey) {
       return offsetKey;
     }
-    for (var ii = 0; ii < node.childNodes.length; ii++) {
-      var childOffsetKey = getSelectionOffsetKeyForNode(node.childNodes[ii]);
+    for (var ii = 0; ii < element.childNodes.length; ii++) {
+      var childOffsetKey = getSelectionOffsetKeyForNode(element.childNodes[ii]);
       if (childOffsetKey) {
         return childOffsetKey;
       }

src/component/selection/setDraftEditorSelection.js

@@ -36,10 +36,11 @@ function getAnonymizedDOM(
   }
 
   invariant(
-    anonymized instanceof Element,
+    anonymized.nodeType === Node.ELEMENT_NODE,
     'Node must be an Element if it is not a text node.',
   );
-  return anonymized.outerHTML;
+  var element: Element = (anonymized: any);
+  return element.outerHTML;
 }
 
 function anonymizeTextWithin(
@@ -77,15 +78,14 @@ function getAnonymizedEditorDOM(
   // grabbing the DOM content of the Draft editor
   let currentNode = node;
   while (currentNode) {
-    if (
-      currentNode instanceof Element &&
-      currentNode.hasAttribute('contenteditable')
-    ) {
-      // found the Draft editor container
-      return getAnonymizedDOM(currentNode, getNodeLabels);
-    } else {
-      currentNode = currentNode.parentNode;
+    if (currentNode.nodeType === 1) {
+      const currentElement: Element = (currentNode: any);
+      if (currentElement.hasAttribute('contenteditable')) {
+        // found the Draft editor container
+        return getAnonymizedDOM(currentNode, getNodeLabels);
+      }
     }
+    currentNode = currentNode.parentNode;
   }
   return 'Could not find contentEditable parent of node';
 }

src/model/encoding/convertFromHTMLToContentBlocks.js

@@ -230,11 +230,10 @@ function processInlineTag(
   currentStyle: DraftInlineStyle,
 ): DraftInlineStyle {
   var styleToCheck = inlineTags[tag];
-  var win = node.ownerDocument.defaultView || window;
   if (styleToCheck) {
     currentStyle = currentStyle.add(styleToCheck).toOrderedSet();
-  } else if (node instanceof win.HTMLElement) {
-    const htmlElement = node;
+  } else if (node.nodeType === 1) {
+    const htmlElement: HTMLElement = (node: any);
     currentStyle = currentStyle.withMutations(style => {
       const fontWeight = htmlElement.style.fontWeight;
       const fontStyle = htmlElement.style.fontStyle;
@@ -317,16 +316,16 @@ function containsSemanticBlockMarkup(
 }
 
 function hasValidLinkText(link: Node): boolean {
-  const win = link.ownerDocument.defaultView || window;
   invariant(
-    link instanceof win.HTMLAnchorElement,
+    link.nodeName === 'A',
     'Link must be an HTMLAnchorElement.',
   );
-  var protocol = link.protocol;
+
+  const element: HTMLAnchorElement = (link: any);
   return (
-    protocol === 'http:' ||
-    protocol === 'https:' ||
-    protocol === 'mailto:'
+    element.protocol === 'http:' ||
+    element.protocol === 'https:' ||
+    element.protocol === 'mailto:'
   );
 }
 
@@ -389,37 +388,35 @@ function genFragment(
     return {chunk: getSoftNewlineChunk(), entityMap};
   }
 
-  const win = node.ownerDocument.defaultView || window;
-
   // IMG tags
-  if (
-    nodeName === 'img' &&
-    node instanceof win.HTMLImageElement &&
-    node.attributes.getNamedItem('src') &&
-    node.attributes.getNamedItem('src').value
-  ) {
-    const image: HTMLImageElement = node;
-    const entityConfig = {};
+  if (nodeName === 'img') {
+    const image: HTMLImageElement = (node: any);
+    if (
+      image.attributes.getNamedItem('src') &&
+      image.attributes.getNamedItem('src').value
+    ) {
+      const entityConfig = {};
 
-    imgAttr.forEach((attr) => {
-      const imageAttribute = image.getAttribute(attr);
-      if (imageAttribute) {
-        entityConfig[attr] = imageAttribute;
-      }
-    });
-    // Forcing this node to have children because otherwise no entity will be
-    // created for this node.
-    // The child text node cannot just have a space or return as content -
-    // we strip those out.
-    // See https://github.com/facebook/draft-js/issues/231 for some context.
-    node.textContent = '\ud83d\udcf7';
-
-    // TODO: update this when we remove DraftEntity entirely
-    inEntity = DraftEntity.__create(
-      'IMAGE',
-      'MUTABLE',
-      entityConfig || {},
-    );
+      imgAttr.forEach((attr) => {
+        const imageAttribute = image.getAttribute(attr);
+        if (imageAttribute) {
+          entityConfig[attr] = imageAttribute;
+        }
+      });
+      // Forcing this node to have children because otherwise no entity will be
+      // created for this node.
+      // The child text node cannot just have a space or return as content -
+      // we strip those out.
+      // See https://github.com/facebook/draft-js/issues/231 for some context.
+      node.textContent = '\ud83d\udcf7';
+
+      // TODO: update this when we remove DraftEntity entirely
+      inEntity = DraftEntity.__create(
+        'IMAGE',
+        'MUTABLE',
+        entityConfig || {},
+      );
+    }
   }
 
   var chunk = getEmptyChunk();
@@ -465,30 +462,30 @@ function genFragment(
   var entityId: ?string = null;
 
   while (child) {
-    if (
-      child instanceof win.HTMLAnchorElement &&
-      child.href &&
-      hasValidLinkText(child)
-    ) {
-      const anchor: HTMLAnchorElement = child;
-      const entityConfig = {};
-
-      anchorAttr.forEach((attr) => {
-        const anchorAttribute = anchor.getAttribute(attr);
-        if (anchorAttribute) {
-          entityConfig[attr] = anchorAttribute;
-        }
-      });
+    entityId = null;
+    if (nodeName === 'a') {
+      const anchor: HTMLAnchorElement = (child: any);
+      if (
+        anchor.href &&
+        hasValidLinkText(anchor)
+      ) {
+        const entityConfig = {};
+
+        anchorAttr.forEach((attr) => {
+          const anchorAttribute = anchor.getAttribute(attr);
+          if (anchorAttribute) {
+            entityConfig[attr] = anchorAttribute;
+          }
+        });
 
-      entityConfig.url = new URI(anchor.href).toString();
-      // TODO: update this when we remove DraftEntity completely
-      entityId = DraftEntity.__create(
-        'LINK',
-        'MUTABLE',
-        entityConfig || {},
-      );
-    } else {
-      entityId = undefined;
+        entityConfig.url = new URI(anchor.href).toString();
+        // TODO: update this when we remove DraftEntity completely
+        entityId = DraftEntity.__create(
+          'LINK',
+          'MUTABLE',
+          entityConfig || {},
+        );
+      }
     }
 
     const {