Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Commit 7af73b7

Browse files
mrkevfacebook-github-bot
authored andcommitted
Make decodeEntityRanges flow strict
Summary: Functionality shouldn't have changed, I just editeed types. I did have to edit and re-record a test that was wrong. Differential Revision: D19868736 fbshipit-source-id: e65885cd4565756e6669a17692e2f63d46f0d730
1 parent d6527a9 commit 7af73b7

File tree

3 files changed

+29
-27
lines changed

3 files changed

+29
-27
lines changed

src/model/encoding/__tests__/__snapshots__/decodeEntityRanges-test.js.snap

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ exports[`must decode when an entity is present 1`] = `
44
Array [
55
null,
66
null,
7-
"6",
8-
"6",
7+
6,
8+
6,
99
null,
1010
]
1111
`;
@@ -14,11 +14,11 @@ exports[`must decode when an entity is present more than once 1`] = `
1414
Array [
1515
null,
1616
null,
17-
"6",
18-
"6",
17+
6,
18+
6,
1919
null,
20-
"6",
21-
"6",
20+
6,
21+
6,
2222
null,
2323
]
2424
`;
@@ -27,11 +27,11 @@ exports[`must decode when multiple entities present 1`] = `
2727
Array [
2828
null,
2929
null,
30-
"6",
31-
"6",
30+
6,
31+
6,
3232
null,
33-
"8",
34-
"8",
33+
8,
34+
8,
3535
null,
3636
]
3737
`;
@@ -69,16 +69,16 @@ Array [
6969
null,
7070
null,
7171
null,
72-
"6",
73-
"6",
74-
"6",
75-
"6",
76-
"6",
77-
"6",
72+
6,
73+
6,
74+
6,
75+
6,
76+
6,
77+
6,
7878
null,
7979
null,
80-
"8",
81-
"8",
80+
8,
81+
8,
8282
null,
8383
]
8484
`;

src/model/encoding/__tests__/decodeEntityRanges-test.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ test('must decode when an entity is present', () => {
2323
{
2424
offset: 2,
2525
length: 2,
26-
key: '6',
26+
key: 6,
2727
},
2828
]);
2929
expect(decoded).toMatchSnapshot();
@@ -34,12 +34,12 @@ test('must decode when multiple entities present', () => {
3434
{
3535
offset: 2,
3636
length: 2,
37-
key: '6',
37+
key: 6,
3838
},
3939
{
4040
offset: 5,
4141
length: 2,
42-
key: '8',
42+
key: 8,
4343
},
4444
]);
4545
expect(decoded).toMatchSnapshot();
@@ -50,12 +50,12 @@ test('must decode when an entity is present more than once', () => {
5050
{
5151
offset: 2,
5252
length: 2,
53-
key: '6',
53+
key: 6,
5454
},
5555
{
5656
offset: 5,
5757
length: 2,
58-
key: '6',
58+
key: 6,
5959
},
6060
]);
6161
expect(decoded).toMatchSnapshot();
@@ -66,12 +66,12 @@ test('must handle ranges that include surrogate pairs', () => {
6666
{
6767
offset: 6,
6868
length: 5,
69-
key: '6',
69+
key: 6,
7070
},
7171
{
7272
offset: 13,
7373
length: 2,
74-
key: '8',
74+
key: 8,
7575
},
7676
]);
7777
expect(decoded).toMatchSnapshot();

src/model/encoding/decodeEntityRanges.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,14 @@
55
* LICENSE file in the root directory of this source tree.
66
*
77
* @format
8-
* @flow
8+
* @flow strict
99
* @emails oncall+draft_js
1010
*/
1111

1212
'use strict';
1313

14+
import type {EntityRange} from 'EntityRange';
15+
1416
const UnicodeUtils = require('UnicodeUtils');
1517

1618
const {substr} = UnicodeUtils;
@@ -20,7 +22,7 @@ const {substr} = UnicodeUtils;
2022
*/
2123
function decodeEntityRanges(
2224
text: string,
23-
ranges: Array<Object>,
25+
ranges: Array<EntityRange>,
2426
): Array<?string> {
2527
const entities = Array(text.length).fill(null);
2628
if (ranges) {

0 commit comments

Comments
 (0)