[build] Add support for ASM files in Make + CMake #2783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrelln
force-pushed
the
huf-asm-makefiles
branch
from
5183c56 to
fab16f7
Compare
Cyan4973
approved these changes
Sep 17, 2021
Contributor
Author
|
Looks like some of these changes are triggering a compiler bug in an aarch64 cross compiler :( |
terrelln
force-pushed
the
huf-asm-makefiles
branch
from
fab16f7 to
374a331
Compare
Contributor
Author
|
I've attempted to move the various cross compile builds to the QEMU matrix in GitHub actions, and am hoping they have a different version of the compiler that doesn't have the bug. |
terrelln
force-pushed
the
huf-asm-makefiles
branch
from
374a331 to
bf34bc1
Compare
Cyan4973
approved these changes
Sep 17, 2021
terrelln
force-pushed
the
huf-asm-makefiles
branch
from
bf34bc1 to
41d5de1
Compare
* Extract out common portion of `lib/Makefile` into `lib/libzstd.mk`. Most relevantly, the way we find library files. * Use `lib/libzstd.mk` in the other Makefiles instead of repeating the same code. * Add a test `tests/test-variants.sh` that checks that the builds of `make -C programs allVariants` are correct, and run it in Actions. * Adds support for ASM files in the CMake build. The Meson build is not updated because it lists every file in zstd, and supports ASM off the bat, so the Huffman ASM commit will just add the ASM file to the list. The Visual Studios build is not updated because I'm not adding ASM support to Visual Studios yet.
terrelln
force-pushed
the
huf-asm-makefiles
branch
from
41d5de1 to
8bf699a
Compare
Contributor
Author
|
I'm going to disable the aarch64 test for now. I've opened Issue #2785 to track it. |
terrelln
added a commit
to terrelln/zstd
that referenced
this pull request
Dec 1, 2021
This test was disabled in PR facebook#2783 due to triggering an ICE. Re-enable the test now that it doesn't trigger the same ICE. Fixes facebook#2785.
terrelln
added a commit
to terrelln/zstd
that referenced
this pull request
Dec 1, 2021
This test was disabled in PR facebook#2783 due to triggering an ICE. Re-enable the test now that it doesn't trigger the same ICE. Fixes facebook#2785.
terrelln
added a commit
to terrelln/zstd
that referenced
this pull request
Dec 1, 2021
This test was disabled in PR facebook#2783 due to triggering an ICE. Re-enable the test now that it doesn't trigger the same ICE. Fixes facebook#2785.
terrelln
added a commit
to terrelln/zstd
that referenced
this pull request
Dec 1, 2021
This test was disabled in PR facebook#2783 due to triggering an ICE. Re-enable the test now that it doesn't trigger the same ICE. Fixes facebook#2785.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/Makefileintolib/libzstd.mk.Most relevantly, the way we find library files.
lib/libzstd.mkin the other Makefiles instead of repeating thesame code.
tests/test-variants.shthat checks that the builds ofmake -C programs allVariantsare correct, and run it in Actions.The Meson build is not updated because it lists every file in zstd,
and supports ASM off the bat, so the Huffman ASM commit will just add
the ASM file to the list.
The Visual Studios build is not updated because I'm not adding ASM
support to Visual Studios yet.