-
Notifications
You must be signed in to change notification settings - Fork 49.8k
Fix test-build-devtools if build was generated by build-for-devtools #24088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -220,7 +220,7 @@ export function getInternalReactConstants( | |||||
| // Keep it in sync, and add version guards if it changes. | ||||||
| // | ||||||
| // TODO Update the gt() check below to be gte() whichever the next version number is. | ||||||
| // Currently the version in Git is 17.0.2 (but that version has not been/may not end up being released). | ||||||
| // Currently the version in Git is 18.0.0 (but that version has not been/may not end up being released). | ||||||
|
||||||
| // Currently the version in Git is 18.0.0 (but that version has not been/may not end up being released). | |
| // Currently the version in Git is 17.0.2 (but that version has not been/may not end up being released). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,10 +7,10 @@ | |
|
|
||
| // TODO: this is special because it gets imported during build. | ||
| // | ||
| // TODO: 17.0.3 has not been released to NPM; | ||
| // TODO: 18.0.0 has not been released to NPM; | ||
| // It exists as a placeholder so that DevTools can support work tag changes between releases. | ||
| // When we next publish a release (either 17.0.3 or 17.1.0), update the matching TODO in backend/renderer.js | ||
| // When we next publish a release, update the matching TODO in backend/renderer.js | ||
| // TODO: This module is used both by the release scripts and to expose a version | ||
| // at runtime. We should instead inject the version number as part of the build | ||
| // process, and use the ReactVersions.js module as the single source of truth. | ||
| export default '17.0.3'; | ||
| export default '18.0.0'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @acdlite How do you feel about this change? I don't remember if this would mess up/confuse our release scripts.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah this should be fine |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is using experimental
Previous command would use www-modern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @rickhanlonii might want to chime in since he was working on these test commands recently.