Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
"test-prod-build": "yarn test --deprecated 'yarn test --prod --build'",
"test-build": "yarn test --deprecated 'yarn test --build'",
"test-build-prod": "yarn test --deprecated 'yarn test --build --prod'",
"test-build-devtools": "yarn test --build --project devtools",
"test-build-devtools": "node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is using experimental

Previous command would use www-modern

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also @rickhanlonii might want to chime in since he was working on these test commands recently.

"debug-test-build-devtools": "yarn test --deprecated 'yarn test-build-devtools --debug'",
"test-dom-fixture": "cd fixtures/dom && yarn && yarn prestart && yarn test",
"flow": "node ./scripts/tasks/flow.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-shared/src/backend/renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ export function getInternalReactConstants(
// Keep it in sync, and add version guards if it changes.
//
// TODO Update the gt() check below to be gte() whichever the next version number is.
// Currently the version in Git is 17.0.2 (but that version has not been/may not end up being released).
// Currently the version in Git is 18.0.0 (but that version has not been/may not end up being released).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the old comment was probably fine. The main point wasn't the current version so much as "why 17.0.1 vs 17.0.0"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Currently the version in Git is 18.0.0 (but that version has not been/may not end up being released).
// Currently the version in Git is 17.0.2 (but that version has not been/may not end up being released).

if (gt(version, '17.0.1')) {
ReactTypeOfWork = {
CacheComponent: 24, // Experimental
Expand Down
6 changes: 3 additions & 3 deletions packages/shared/ReactVersion.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@

// TODO: this is special because it gets imported during build.
//
// TODO: 17.0.3 has not been released to NPM;
// TODO: 18.0.0 has not been released to NPM;
// It exists as a placeholder so that DevTools can support work tag changes between releases.
// When we next publish a release (either 17.0.3 or 17.1.0), update the matching TODO in backend/renderer.js
// When we next publish a release, update the matching TODO in backend/renderer.js
// TODO: This module is used both by the release scripts and to expose a version
// at runtime. We should instead inject the version number as part of the build
// process, and use the ReactVersions.js module as the single source of truth.
export default '17.0.3';
export default '18.0.0';
Copy link
Contributor

@bvaughn bvaughn Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @acdlite How do you feel about this change? I don't remember if this would mess up/confuse our release scripts.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this should be fine