-
Notifications
You must be signed in to change notification settings - Fork 49.8k
Don't warn about concurrently rendering contexts if we finished rendering #22797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+68
−1
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
67b5c96
Expected behavior
eps1lon bb33098
Don't warn about concurrent provider renders if we finished rendering
eps1lon 91b9705
Only need to reset in DEV since we only set in DEV
eps1lon 2ab9b80
Restore currentRenderN instead of resetting it
eps1lon 4e9a32e
Update packages/react-reconciler/src/__tests__/ReactNewContext-test.js
eps1lon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -874,6 +874,48 @@ describe('ReactNewContext', () => { | |
| } | ||
| }); | ||
|
|
||
| it('warns not if multiple renderers finished rendering the same context', () => { | ||
| spyOnDev(console, 'error'); | ||
| const Context = React.createContext(0); | ||
|
|
||
| function Foo(props) { | ||
| Scheduler.unstable_yieldValue('Foo'); | ||
| return null; | ||
| } | ||
|
|
||
| function App(props) { | ||
| return ( | ||
| <Context.Provider value={props.value}> | ||
| <Foo /> | ||
| <Foo /> | ||
| </Context.Provider> | ||
| ); | ||
| } | ||
|
|
||
| if (gate(flags => flags.enableSyncDefaultUpdates)) { | ||
| React.startTransition(() => { | ||
| ReactNoop.render(<App value={1} />); | ||
| }); | ||
| } else { | ||
| ReactNoop.render(<App value={1} />); | ||
| } | ||
| expect(Scheduler).toFlushAndYield(['Foo', 'Foo']); | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test above ("warns if multiple renderers concurrently render the same context") did not commit here. Without committing I would expect the warning. But here we actually commit so I don't think we should warn. |
||
|
|
||
| // Get a new copy of ReactNoop | ||
| jest.resetModules(); | ||
| React = require('react'); | ||
| ReactNoop = require('react-noop-renderer'); | ||
| Scheduler = require('scheduler'); | ||
|
|
||
| // Render the provider again using a different renderer | ||
| ReactNoop.render(<App value={1} />); | ||
| expect(Scheduler).toFlushAndYield(['Foo', 'Foo']); | ||
|
|
||
| if (__DEV__) { | ||
| expect(console.error).not.toHaveBeenCalled(); | ||
| } | ||
| }); | ||
|
|
||
| it('provider bails out if children and value are unchanged (like sCU)', () => { | ||
| const Context = React.createContext(0); | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.