Skip to content

Shallow renderer: pass component instance to setState updater as this #12784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2018
Merged

Shallow renderer: pass component instance to setState updater as this #12784

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda5946
Shallow renderer: pass component instance to setState updater as `this`
Hypnosphi May 11, 2018
3d0f2be
Run prettier
Hypnosphi May 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-test-renderer/src/ReactShallowRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ class Updater {
const currentState = this._renderer._newState || publicInstance.state;

if (typeof partialState === 'function') {
partialState = partialState(currentState, publicInstance.props);
partialState = partialState.call(publicInstance, currentState, publicInstance.props);
Copy link
Contributor

@bvaughn bvaughn May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run yarn prettier to reformat this file and CI should pass! 😄

}

// Null and undefined are treated as no-ops.
Expand Down
21 changes: 21 additions & 0 deletions packages/react-test-renderer/src/__tests__/ReactShallowRenderer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,6 +945,27 @@ describe('ReactShallowRenderer', () => {
expect(result.props.children).toEqual(2);
});

it('can access component instance from setState updater function', done => {
let instance;

class SimpleComponent extends React.Component {
state = {};

render() {
instance = this;
return null;
}
}

const shallowRenderer = createRenderer();
shallowRenderer.render(<SimpleComponent />);

instance.setState(function updater(state, props) {
expect(this).toBe(instance);
done();
});
});

it('can setState with a callback', () => {
let instance;

Expand Down