Skip to content

Commit be952bb

Browse files
jackpopejackpope
committed
Handle fabric root level fragment with compareDocumentPosition (#34533)
The root instance doesn't have a canonical property so we were not returning a public instance that we can call compareDocumentPosition on when a Fragment had no other host parent in Fabric. In this case we need to get the ReactNativeElement from the ReactNativeDocument. I've also added test coverage for this case in DOM for consistency, though it was already working there because we use DOM elements as root. This same test will be copied to RN using Fantom. DiffTrain build for [83c88ad](83c88ad)
1 parent cc7cac5 commit be952bb

24 files changed

+170
-185
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-720bb130-20250922
1+
19.2.0-native-fb-83c88ad4-20250923

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<e2c3a6d6120e131282a29302357c4829>>
10+
* @generated SignedSource<<a60917f117c065916a594b76e28c0e95>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-720bb130-20250922";
407+
exports.version = "19.2.0-native-fb-83c88ad4-20250923";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<68b64643c8163c3183a50e2203ca85a0>>
10+
* @generated SignedSource<<d852c0a8dc885d19ad24f32dae025670>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-720bb130-20250922";
206+
exports.version = "19.2.0-native-fb-83c88ad4-20250923";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<68b64643c8163c3183a50e2203ca85a0>>
10+
* @generated SignedSource<<d852c0a8dc885d19ad24f32dae025670>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-720bb130-20250922";
206+
exports.version = "19.2.0-native-fb-83c88ad4-20250923";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<cac287fa200d4ca597d9eb14e76b2ffb>>
10+
* @generated SignedSource<<9afdaab737b4532bdc5238d781909377>>
1111
*/
1212

1313
/*
@@ -29923,11 +29923,11 @@ __DEV__ &&
2992329923
};
2992429924
(function () {
2992529925
var isomorphicReactPackageVersion = React.version;
29926-
if ("19.2.0-native-fb-720bb130-20250922" !== isomorphicReactPackageVersion)
29926+
if ("19.2.0-native-fb-83c88ad4-20250923" !== isomorphicReactPackageVersion)
2992729927
throw Error(
2992829928
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2992929929
(isomorphicReactPackageVersion +
29930-
"\n - react-dom: 19.2.0-native-fb-720bb130-20250922\nLearn more: https://react.dev/warnings/version-mismatch")
29930+
"\n - react-dom: 19.2.0-native-fb-83c88ad4-20250923\nLearn more: https://react.dev/warnings/version-mismatch")
2993129931
);
2993229932
})();
2993329933
("function" === typeof Map &&
@@ -29964,10 +29964,10 @@ __DEV__ &&
2996429964
!(function () {
2996529965
var internals = {
2996629966
bundleType: 1,
29967-
version: "19.2.0-native-fb-720bb130-20250922",
29967+
version: "19.2.0-native-fb-83c88ad4-20250923",
2996829968
rendererPackageName: "react-dom",
2996929969
currentDispatcherRef: ReactSharedInternals,
29970-
reconcilerVersion: "19.2.0-native-fb-720bb130-20250922"
29970+
reconcilerVersion: "19.2.0-native-fb-83c88ad4-20250923"
2997129971
};
2997229972
internals.overrideHookState = overrideHookState;
2997329973
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -30116,5 +30116,5 @@ __DEV__ &&
3011630116
listenToAllSupportedEvents(container);
3011730117
return new ReactDOMHydrationRoot(initialChildren);
3011830118
};
30119-
exports.version = "19.2.0-native-fb-720bb130-20250922";
30119+
exports.version = "19.2.0-native-fb-83c88ad4-20250923";
3012030120
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<43f258e98e350171a9b847b8964bc0ae>>
10+
* @generated SignedSource<<d19b05dee13081d2ce6ac205b90af7f9>>
1111
*/
1212

1313
/*
@@ -17529,14 +17529,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1752917529
};
1753017530
var isomorphicReactPackageVersion$jscomp$inline_2052 = React.version;
1753117531
if (
17532-
"19.2.0-native-fb-720bb130-20250922" !==
17532+
"19.2.0-native-fb-83c88ad4-20250923" !==
1753317533
isomorphicReactPackageVersion$jscomp$inline_2052
1753417534
)
1753517535
throw Error(
1753617536
formatProdErrorMessage(
1753717537
527,
1753817538
isomorphicReactPackageVersion$jscomp$inline_2052,
17539-
"19.2.0-native-fb-720bb130-20250922"
17539+
"19.2.0-native-fb-83c88ad4-20250923"
1754017540
)
1754117541
);
1754217542
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17558,10 +17558,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1755817558
};
1755917559
var internals$jscomp$inline_2625 = {
1756017560
bundleType: 0,
17561-
version: "19.2.0-native-fb-720bb130-20250922",
17561+
version: "19.2.0-native-fb-83c88ad4-20250923",
1756217562
rendererPackageName: "react-dom",
1756317563
currentDispatcherRef: ReactSharedInternals,
17564-
reconcilerVersion: "19.2.0-native-fb-720bb130-20250922"
17564+
reconcilerVersion: "19.2.0-native-fb-83c88ad4-20250923"
1756517565
};
1756617566
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1756717567
var hook$jscomp$inline_2626 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17668,4 +17668,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1766817668
listenToAllSupportedEvents(container);
1766917669
return new ReactDOMHydrationRoot(initialChildren);
1767017670
};
17671-
exports.version = "19.2.0-native-fb-720bb130-20250922";
17671+
exports.version = "19.2.0-native-fb-83c88ad4-20250923";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2a7c96e08f1a65dcc5ce5036b3d91baf>>
10+
* @generated SignedSource<<2176a293b309a694f96f1b6f642f1287>>
1111
*/
1212

1313
/*
@@ -19624,14 +19624,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1962419624
};
1962519625
var isomorphicReactPackageVersion$jscomp$inline_2323 = React.version;
1962619626
if (
19627-
"19.2.0-native-fb-720bb130-20250922" !==
19627+
"19.2.0-native-fb-83c88ad4-20250923" !==
1962819628
isomorphicReactPackageVersion$jscomp$inline_2323
1962919629
)
1963019630
throw Error(
1963119631
formatProdErrorMessage(
1963219632
527,
1963319633
isomorphicReactPackageVersion$jscomp$inline_2323,
19634-
"19.2.0-native-fb-720bb130-20250922"
19634+
"19.2.0-native-fb-83c88ad4-20250923"
1963519635
)
1963619636
);
1963719637
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19653,10 +19653,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1965319653
};
1965419654
var internals$jscomp$inline_2330 = {
1965519655
bundleType: 0,
19656-
version: "19.2.0-native-fb-720bb130-20250922",
19656+
version: "19.2.0-native-fb-83c88ad4-20250923",
1965719657
rendererPackageName: "react-dom",
1965819658
currentDispatcherRef: ReactSharedInternals,
19659-
reconcilerVersion: "19.2.0-native-fb-720bb130-20250922",
19659+
reconcilerVersion: "19.2.0-native-fb-83c88ad4-20250923",
1966019660
getLaneLabelMap: function () {
1966119661
for (
1966219662
var map = new Map(), lane = 1, index$325 = 0;
@@ -19779,4 +19779,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1977919779
listenToAllSupportedEvents(container);
1978019780
return new ReactDOMHydrationRoot(initialChildren);
1978119781
};
19782-
exports.version = "19.2.0-native-fb-720bb130-20250922";
19782+
exports.version = "19.2.0-native-fb-83c88ad4-20250923";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<0aceb7d61968f0f74282f2603c1edfbd>>
10+
* @generated SignedSource<<42c3c6aeb85be0b40d30dbe9ea4b52eb>>
1111
*/
1212

1313
/*
@@ -29979,11 +29979,11 @@ __DEV__ &&
2997929979
};
2998029980
(function () {
2998129981
var isomorphicReactPackageVersion = React.version;
29982-
if ("19.2.0-native-fb-720bb130-20250922" !== isomorphicReactPackageVersion)
29982+
if ("19.2.0-native-fb-83c88ad4-20250923" !== isomorphicReactPackageVersion)
2998329983
throw Error(
2998429984
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2998529985
(isomorphicReactPackageVersion +
29986-
"\n - react-dom: 19.2.0-native-fb-720bb130-20250922\nLearn more: https://react.dev/warnings/version-mismatch")
29986+
"\n - react-dom: 19.2.0-native-fb-83c88ad4-20250923\nLearn more: https://react.dev/warnings/version-mismatch")
2998729987
);
2998829988
})();
2998929989
("function" === typeof Map &&
@@ -30020,10 +30020,10 @@ __DEV__ &&
3002030020
!(function () {
3002130021
var internals = {
3002230022
bundleType: 1,
30023-
version: "19.2.0-native-fb-720bb130-20250922",
30023+
version: "19.2.0-native-fb-83c88ad4-20250923",
3002430024
rendererPackageName: "react-dom",
3002530025
currentDispatcherRef: ReactSharedInternals,
30026-
reconcilerVersion: "19.2.0-native-fb-720bb130-20250922"
30026+
reconcilerVersion: "19.2.0-native-fb-83c88ad4-20250923"
3002730027
};
3002830028
internals.overrideHookState = overrideHookState;
3002930029
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -30488,7 +30488,7 @@ __DEV__ &&
3048830488
exports.useFormStatus = function () {
3048930489
return resolveDispatcher().useHostTransitionStatus();
3049030490
};
30491-
exports.version = "19.2.0-native-fb-720bb130-20250922";
30491+
exports.version = "19.2.0-native-fb-83c88ad4-20250923";
3049230492
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
3049330493
"function" ===
3049430494
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<b1194292c80342ffa34505d89177bbbd>>
10+
* @generated SignedSource<<ca6e991c16154ce7a5db8116b6b34d8f>>
1111
*/
1212

1313
/*
@@ -17540,14 +17540,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1754017540
};
1754117541
var isomorphicReactPackageVersion$jscomp$inline_2053 = React.version;
1754217542
if (
17543-
"19.2.0-native-fb-720bb130-20250922" !==
17543+
"19.2.0-native-fb-83c88ad4-20250923" !==
1754417544
isomorphicReactPackageVersion$jscomp$inline_2053
1754517545
)
1754617546
throw Error(
1754717547
formatProdErrorMessage(
1754817548
527,
1754917549
isomorphicReactPackageVersion$jscomp$inline_2053,
17550-
"19.2.0-native-fb-720bb130-20250922"
17550+
"19.2.0-native-fb-83c88ad4-20250923"
1755117551
)
1755217552
);
1755317553
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17569,10 +17569,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1756917569
};
1757017570
var internals$jscomp$inline_2628 = {
1757117571
bundleType: 0,
17572-
version: "19.2.0-native-fb-720bb130-20250922",
17572+
version: "19.2.0-native-fb-83c88ad4-20250923",
1757317573
rendererPackageName: "react-dom",
1757417574
currentDispatcherRef: ReactSharedInternals,
17575-
reconcilerVersion: "19.2.0-native-fb-720bb130-20250922"
17575+
reconcilerVersion: "19.2.0-native-fb-83c88ad4-20250923"
1757617576
};
1757717577
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1757817578
var hook$jscomp$inline_2629 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17832,4 +17832,4 @@ exports.useFormState = function (action, initialState, permalink) {
1783217832
exports.useFormStatus = function () {
1783317833
return ReactSharedInternals.H.useHostTransitionStatus();
1783417834
};
17835-
exports.version = "19.2.0-native-fb-720bb130-20250922";
17835+
exports.version = "19.2.0-native-fb-83c88ad4-20250923";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<351b3d57ec4d1611aec6e49be227151c>>
10+
* @generated SignedSource<<82a1b27c82f245c2db8611424d8ee805>>
1111
*/
1212

1313
/*
@@ -19639,14 +19639,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1963919639
};
1964019640
var isomorphicReactPackageVersion$jscomp$inline_2324 = React.version;
1964119641
if (
19642-
"19.2.0-native-fb-720bb130-20250922" !==
19642+
"19.2.0-native-fb-83c88ad4-20250923" !==
1964319643
isomorphicReactPackageVersion$jscomp$inline_2324
1964419644
)
1964519645
throw Error(
1964619646
formatProdErrorMessage(
1964719647
527,
1964819648
isomorphicReactPackageVersion$jscomp$inline_2324,
19649-
"19.2.0-native-fb-720bb130-20250922"
19649+
"19.2.0-native-fb-83c88ad4-20250923"
1965019650
)
1965119651
);
1965219652
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19668,10 +19668,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1966819668
};
1966919669
var internals$jscomp$inline_2331 = {
1967019670
bundleType: 0,
19671-
version: "19.2.0-native-fb-720bb130-20250922",
19671+
version: "19.2.0-native-fb-83c88ad4-20250923",
1967219672
rendererPackageName: "react-dom",
1967319673
currentDispatcherRef: ReactSharedInternals,
19674-
reconcilerVersion: "19.2.0-native-fb-720bb130-20250922",
19674+
reconcilerVersion: "19.2.0-native-fb-83c88ad4-20250923",
1967519675
getLaneLabelMap: function () {
1967619676
for (
1967719677
var map = new Map(), lane = 1, index$325 = 0;
@@ -19947,7 +19947,7 @@ exports.useFormState = function (action, initialState, permalink) {
1994719947
exports.useFormStatus = function () {
1994819948
return ReactSharedInternals.H.useHostTransitionStatus();
1994919949
};
19950-
exports.version = "19.2.0-native-fb-720bb130-20250922";
19950+
exports.version = "19.2.0-native-fb-83c88ad4-20250923";
1995119951
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1995219952
"function" ===
1995319953
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)