[compiler] Prevent overriding a derivationEntry on effect mutation and instead update typeOfValue and fix infinite loops (#34967)

Summary:
With this we are now comparing a snapshot of the derivationCache with
the new changes every time we are done recording the derivations
happening in the HIR.

We have to do this after recording everything since we still do some
mutations on the cache when recording mutations.

Test Plan:
Test the following in playground:
```
// @validateNoDerivedComputationsInEffects_exp

function Component({ value }) {
  const [checked, setChecked] = useState('');

  useEffect(() => {
    setChecked(value === '' ? [] : value.split(','));
  }, [value]);

  return (
    <div>{checked}</div>
  )
}
```

This no longer causes an infinite loop.

Added a test case in the next PR in the stack

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34967).
* #35044
* #35020
* #34973
* #34972
* #34995
* __->__ #34967

DiffTrain build for [01fb328](01fb328)

Author: jorge-cab

compiled/eslint-plugin-react-hooks/index.js

@@ -52230,6 +52230,36 @@ class DerivationCache {
     constructor() {
         this.hasChanges = false;
         this.cache = new Map();
+        this.previousCache = null;
+    }
+    takeSnapshot() {
+        this.previousCache = new Map();
+        for (const [key, value] of this.cache.entries()) {
+            this.previousCache.set(key, {
+                place: value.place,
+                sourcesIds: new Set(value.sourcesIds),
+                typeOfValue: value.typeOfValue,
+            });
+        }
+    }
+    checkForChanges() {
+        if (this.previousCache === null) {
+            this.hasChanges = true;
+            return;
+        }
+        for (const [key, value] of this.cache.entries()) {
+            const previousValue = this.previousCache.get(key);
+            if (previousValue === undefined ||
+                !this.isDerivationEqual(previousValue, value)) {
+                this.hasChanges = true;
+                return;
+            }
+        }
+        if (this.cache.size !== this.previousCache.size) {
+            this.hasChanges = true;
+            return;
+        }
+        this.hasChanges = false;
     }
     snapshot() {
         const hasChanges = this.hasChanges;
@@ -52261,12 +52291,7 @@ class DerivationCache {
         if (newValue.sourcesIds.size === 0) {
             newValue.sourcesIds.add(derivedVar.identifier.id);
         }
-        const existingValue = this.cache.get(derivedVar.identifier.id);
-        if (existingValue === undefined ||
-            !this.isDerivationEqual(existingValue, newValue)) {
-            this.cache.set(derivedVar.identifier.id, newValue);
-            this.hasChanges = true;
-        }
+        this.cache.set(derivedVar.identifier.id, newValue);
     }
     isDerivationEqual(a, b) {
         if (a.typeOfValue !== b.typeOfValue) {
@@ -52306,7 +52331,6 @@ function validateNoDerivedComputationsInEffects_exp(fn) {
                     sourcesIds: new Set([param.identifier.id]),
                     typeOfValue: 'fromProps',
                 });
-                context.derivationCache.hasChanges = true;
             }
         }
     }
@@ -52318,17 +52342,18 @@ function validateNoDerivedComputationsInEffects_exp(fn) {
                 sourcesIds: new Set([props.identifier.id]),
                 typeOfValue: 'fromProps',
             });
-            context.derivationCache.hasChanges = true;
         }
     }
     let isFirstPass = true;
     do {
+        context.derivationCache.takeSnapshot();
         for (const block of fn.body.blocks.values()) {
             recordPhiDerivations(block, context);
             for (const instr of block.instructions) {
                 recordInstructionDerivations(instr, context, isFirstPass);
             }
         }
+        context.derivationCache.checkForChanges();
         isFirstPass = false;
     } while (context.derivationCache.snapshot());
     for (const effect of effects) {
@@ -52429,7 +52454,15 @@ function recordInstructionDerivations(instr, context, isFirstPass) {
             case Effect.ConditionallyMutateIterator:
             case Effect.Mutate: {
                 if (isMutable(instr, operand)) {
-                    context.derivationCache.addDerivationEntry(operand, sources, typeOfValue);
+                    if (context.derivationCache.cache.has(operand.identifier.id)) {
+                        const operandMetadata = context.derivationCache.cache.get(operand.identifier.id);
+                        if (operandMetadata !== undefined) {
+                            operandMetadata.typeOfValue = joinValue(typeOfValue, operandMetadata.typeOfValue);
+                        }
+                    }
+                    else {
+                        context.derivationCache.addDerivationEntry(operand, sources, typeOfValue);
+                    }
                 }
                 break;
             }

compiled/facebook-www/REVISION

@@ -1 +1 @@
-52684925368a41a0c9fbfca9016cdcbb72fc9d1e
+01fb3286321b6190b06b1cc86c7c1cd9e2d884d9

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-52684925368a41a0c9fbfca9016cdcbb72fc9d1e
+01fb3286321b6190b06b1cc86c7c1cd9e2d884d9

compiled/facebook-www/React-dev.classic.js

@@ -1499,7 +1499,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.3.0-www-classic-52684925-20251110";
+    exports.version = "19.3.0-www-classic-01fb3286-20251110";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

@@ -1499,7 +1499,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.3.0-www-modern-52684925-20251110";
+    exports.version = "19.3.0-www-modern-01fb3286-20251110";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

@@ -606,4 +606,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-classic-52684925-20251110";
+exports.version = "19.3.0-www-classic-01fb3286-20251110";

compiled/facebook-www/React-prod.modern.js

@@ -606,4 +606,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-modern-52684925-20251110";
+exports.version = "19.3.0-www-modern-01fb3286-20251110";

compiled/facebook-www/React-profiling.classic.js

@@ -610,7 +610,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-classic-52684925-20251110";
+exports.version = "19.3.0-www-classic-01fb3286-20251110";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

@@ -610,7 +610,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-modern-52684925-20251110";
+exports.version = "19.3.0-www-modern-01fb3286-20251110";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

@@ -20466,10 +20466,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.3.0-www-classic-52684925-20251110",
+        version: "19.3.0-www-classic-01fb3286-20251110",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.3.0-www-classic-52684925-20251110"
+        reconcilerVersion: "19.3.0-www-classic-01fb3286-20251110"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20504,7 +20504,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.3.0-www-classic-52684925-20251110";
+    exports.version = "19.3.0-www-classic-01fb3286-20251110";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&