Skip to content

Commit a41d594

Browse files
committed
fix: rename bottom stack frame (#33680)
`react-stack-bottom-frame` -> `react_stack_bottom_frame`. This survives `@babel/plugin-transform-function-name`, but now frames will be displayed as `at Object.react_stack_bottom_frame (...)` in V8. Checks that were relying on exact function name match were updated to use either `.indexOf()` or `.includes()` For backwards compatibility, both React DevTools and Flight Client will look for both options. I am not so sure about the latter and if React version is locked. DiffTrain build for [91d097b](91d097b)
1 parent 7c4226a commit a41d594

38 files changed

+428
-398
lines changed

compiled/facebook-www/JSXDEVRuntime-dev.classic.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,13 +332,13 @@ __DEV__ &&
332332
return null;
333333
};
334334
React = {
335-
"react-stack-bottom-frame": function (callStackForError) {
335+
react_stack_bottom_frame: function (callStackForError) {
336336
return callStackForError();
337337
}
338338
};
339339
var specialPropKeyWarningShown;
340340
var didWarnAboutElementRef = {};
341-
var unknownOwnerDebugStack = React["react-stack-bottom-frame"].bind(
341+
var unknownOwnerDebugStack = React.react_stack_bottom_frame.bind(
342342
React,
343343
UnknownOwner
344344
)();

compiled/facebook-www/JSXDEVRuntime-dev.modern.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,13 +332,13 @@ __DEV__ &&
332332
return null;
333333
};
334334
React = {
335-
"react-stack-bottom-frame": function (callStackForError) {
335+
react_stack_bottom_frame: function (callStackForError) {
336336
return callStackForError();
337337
}
338338
};
339339
var specialPropKeyWarningShown;
340340
var didWarnAboutElementRef = {};
341-
var unknownOwnerDebugStack = React["react-stack-bottom-frame"].bind(
341+
var unknownOwnerDebugStack = React.react_stack_bottom_frame.bind(
342342
React,
343343
UnknownOwner
344344
)();

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e9cab42ece435ac3478ec85847e352177e596ae0
1+
91d097b2c588a0977a7a10ed12512dc8a34e3a5b
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e9cab42ece435ac3478ec85847e352177e596ae0
1+
91d097b2c588a0977a7a10ed12512dc8a34e3a5b

compiled/facebook-www/React-dev.classic.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -844,13 +844,13 @@ __DEV__ &&
844844
return null;
845845
};
846846
fnName = {
847-
"react-stack-bottom-frame": function (callStackForError) {
847+
react_stack_bottom_frame: function (callStackForError) {
848848
return callStackForError();
849849
}
850850
};
851851
var specialPropKeyWarningShown, didWarnAboutOldJSXRuntime;
852852
var didWarnAboutElementRef = {};
853-
var unknownOwnerDebugStack = fnName["react-stack-bottom-frame"].bind(
853+
var unknownOwnerDebugStack = fnName.react_stack_bottom_frame.bind(
854854
fnName,
855855
UnknownOwner
856856
)();
@@ -1479,7 +1479,7 @@ __DEV__ &&
14791479
exports.useTransition = function () {
14801480
return resolveDispatcher().useTransition();
14811481
};
1482-
exports.version = "19.2.0-www-classic-e9cab42e-20250630";
1482+
exports.version = "19.2.0-www-classic-91d097b2-20250701";
14831483
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14841484
"function" ===
14851485
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -844,13 +844,13 @@ __DEV__ &&
844844
return null;
845845
};
846846
fnName = {
847-
"react-stack-bottom-frame": function (callStackForError) {
847+
react_stack_bottom_frame: function (callStackForError) {
848848
return callStackForError();
849849
}
850850
};
851851
var specialPropKeyWarningShown, didWarnAboutOldJSXRuntime;
852852
var didWarnAboutElementRef = {};
853-
var unknownOwnerDebugStack = fnName["react-stack-bottom-frame"].bind(
853+
var unknownOwnerDebugStack = fnName.react_stack_bottom_frame.bind(
854854
fnName,
855855
UnknownOwner
856856
)();
@@ -1479,7 +1479,7 @@ __DEV__ &&
14791479
exports.useTransition = function () {
14801480
return resolveDispatcher().useTransition();
14811481
};
1482-
exports.version = "19.2.0-www-modern-e9cab42e-20250630";
1482+
exports.version = "19.2.0-www-modern-91d097b2-20250701";
14831483
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
14841484
"function" ===
14851485
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
630630
exports.useTransition = function () {
631631
return ReactSharedInternals.H.useTransition();
632632
};
633-
exports.version = "19.2.0-www-classic-e9cab42e-20250630";
633+
exports.version = "19.2.0-www-classic-91d097b2-20250701";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,4 +630,4 @@ exports.useSyncExternalStore = function (
630630
exports.useTransition = function () {
631631
return ReactSharedInternals.H.useTransition();
632632
};
633-
exports.version = "19.2.0-www-modern-e9cab42e-20250630";
633+
exports.version = "19.2.0-www-modern-91d097b2-20250701";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
634634
exports.useTransition = function () {
635635
return ReactSharedInternals.H.useTransition();
636636
};
637-
exports.version = "19.2.0-www-classic-e9cab42e-20250630";
637+
exports.version = "19.2.0-www-classic-91d097b2-20250701";
638638
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
639639
"function" ===
640640
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@ exports.useSyncExternalStore = function (
634634
exports.useTransition = function () {
635635
return ReactSharedInternals.H.useTransition();
636636
};
637-
exports.version = "19.2.0-www-modern-e9cab42e-20250630";
637+
exports.version = "19.2.0-www-modern-91d097b2-20250701";
638638
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
639639
"function" ===
640640
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)