Skip to content

Commit 9704f0b

Browse files
simplify error retry comments
1 parent c34bc47 commit 9704f0b

File tree

1 file changed

+19
-57
lines changed

1 file changed

+19
-57
lines changed

packages/react-dom/src/__tests__/ReactErrorBoundaries-test.internal.js

Lines changed: 19 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -727,9 +727,7 @@ describe('ReactErrorBoundaries', () => {
727727
'ErrorBoundary static getDerivedStateFromError',
728728
'ErrorBoundary componentWillMount',
729729
'ErrorBoundary render error',
730-
// Retry because the error may be caused by a dependency on concurrent
731-
// state like a store. Retrying can recover from errors that will
732-
// succeed in the next render such as tearing.
730+
// logs for error retry
733731
'ErrorBoundary constructor',
734732
'ErrorBoundary componentWillMount',
735733
'ErrorBoundary render success',
@@ -768,9 +766,7 @@ describe('ReactErrorBoundaries', () => {
768766
'ErrorBoundary static getDerivedStateFromError',
769767
'ErrorBoundary componentWillMount',
770768
'ErrorBoundary render error',
771-
// Retry because the error may be caused by a dependency on concurrent
772-
// state like a store. Retrying can recover from errors that will
773-
// succeed in the next render such as tearing.
769+
// logs for error retry
774770
'ErrorBoundary constructor',
775771
'ErrorBoundary componentWillMount',
776772
'ErrorBoundary render success',
@@ -807,9 +803,7 @@ describe('ReactErrorBoundaries', () => {
807803
'ErrorBoundary static getDerivedStateFromError',
808804
'ErrorBoundary componentWillMount',
809805
'ErrorBoundary render error',
810-
// Retry because the error may be caused by a dependency on concurrent
811-
// state like a store. Retrying can recover from errors that will
812-
// succeed in the next render such as tearing.
806+
// logs for error retry
813807
'ErrorBoundary constructor',
814808
'ErrorBoundary componentWillMount',
815809
'ErrorBoundary render success',
@@ -845,9 +839,7 @@ describe('ReactErrorBoundaries', () => {
845839
'ErrorBoundary static getDerivedStateFromError',
846840
'ErrorBoundary componentWillMount',
847841
'ErrorBoundary render error',
848-
// Retry because the error may be caused by a dependency on concurrent
849-
// state like a store. Retrying can recover from errors that will
850-
// succeed in the next render such as tearing.
842+
// logs for error retry
851843
'ErrorBoundary constructor',
852844
'ErrorBoundary componentWillMount',
853845
'ErrorBoundary render success',
@@ -960,9 +952,7 @@ describe('ReactErrorBoundaries', () => {
960952
'ErrorMessage constructor',
961953
'ErrorMessage componentWillMount',
962954
'ErrorMessage render',
963-
// Retry because the error may be caused by a dependency on concurrent
964-
// state like a store. Retrying can recover from errors that will
965-
// succeed in the next render such as tearing.
955+
// logs for error retry
966956
'ErrorBoundary constructor',
967957
'ErrorBoundary componentWillMount',
968958
'ErrorBoundary render success',
@@ -1020,9 +1010,7 @@ describe('ReactErrorBoundaries', () => {
10201010
'ErrorBoundary static getDerivedStateFromError',
10211011
'ErrorBoundary componentWillMount',
10221012
'ErrorBoundary render error',
1023-
// Retry because the error may be caused by a dependency on concurrent
1024-
// state like a store. Retrying can recover from errors that will
1025-
// succeed in the next render such as tearing.
1013+
// logs for error retry
10261014
'ErrorBoundary constructor',
10271015
'ErrorBoundary componentWillMount',
10281016
'ErrorBoundary render success',
@@ -1069,9 +1057,7 @@ describe('ReactErrorBoundaries', () => {
10691057
'ErrorBoundary static getDerivedStateFromError',
10701058
'ErrorBoundary componentWillMount',
10711059
'ErrorBoundary render error',
1072-
// Retry because the error may be caused by a dependency on concurrent
1073-
// state like a store. Retrying can recover from errors that will
1074-
// succeed in the next render such as tearing.
1060+
// logs for error retry
10751061
'ErrorBoundary constructor',
10761062
'ErrorBoundary componentWillMount',
10771063
'ErrorBoundary render success',
@@ -1118,9 +1104,7 @@ describe('ReactErrorBoundaries', () => {
11181104
'ErrorBoundary static getDerivedStateFromError',
11191105
'ErrorBoundary componentWillMount',
11201106
'ErrorBoundary render error',
1121-
// Retry because the error may be caused by a dependency on concurrent
1122-
// state like a store. Retrying can recover from errors that will
1123-
// succeed in the next render such as tearing.
1107+
// logs for error retry
11241108
'ErrorBoundary constructor',
11251109
'ErrorBoundary componentWillMount',
11261110
'ErrorBoundary render success',
@@ -1173,9 +1157,7 @@ describe('ReactErrorBoundaries', () => {
11731157
'ErrorBoundary static getDerivedStateFromError',
11741158
'ErrorBoundary componentWillMount',
11751159
'ErrorBoundary render error',
1176-
// Retry because the error may be caused by a dependency on concurrent
1177-
// state like a store. Retrying can recover from errors that will
1178-
// succeed in the next render such as tearing.
1160+
// logs for error retry
11791161
'ErrorBoundary constructor',
11801162
'ErrorBoundary componentWillMount',
11811163
'ErrorBoundary render success',
@@ -1225,9 +1207,7 @@ describe('ReactErrorBoundaries', () => {
12251207
'ErrorBoundary static getDerivedStateFromError',
12261208
'ErrorBoundary componentWillMount',
12271209
'ErrorBoundary render error',
1228-
// Retry because the error may be caused by a dependency on concurrent
1229-
// state like a store. Retrying can recover from errors that will
1230-
// succeed in the next render such as tearing.
1210+
// logs for error retry
12311211
'ErrorBoundary constructor',
12321212
'ErrorBoundary componentWillMount',
12331213
'ErrorBoundary render success',
@@ -1274,9 +1254,7 @@ describe('ReactErrorBoundaries', () => {
12741254
'ErrorBoundary static getDerivedStateFromError',
12751255
'ErrorBoundary componentWillMount',
12761256
'ErrorBoundary render error',
1277-
// Retry because the error may be caused by a dependency on concurrent
1278-
// state like a store. Retrying can recover from errors that will
1279-
// succeed in the next render such as tearing.
1257+
// logs for error retry
12801258
'ErrorBoundary constructor',
12811259
'ErrorBoundary componentWillMount',
12821260
'ErrorBoundary render success',
@@ -1358,9 +1336,7 @@ describe('ReactErrorBoundaries', () => {
13581336
// Render the error message
13591337
'ErrorBoundary componentWillUpdate',
13601338
'ErrorBoundary render error',
1361-
// Retry because the error may be caused by a dependency on concurrent
1362-
// state like a store. Retrying can recover from errors that will
1363-
// succeed in the next render such as tearing.
1339+
// logs for error retry
13641340
'ErrorBoundary componentWillReceiveProps',
13651341
'ErrorBoundary componentWillUpdate',
13661342
'ErrorBoundary render success',
@@ -1423,9 +1399,7 @@ describe('ReactErrorBoundaries', () => {
14231399
// Render the error message
14241400
'ErrorBoundary componentWillUpdate',
14251401
'ErrorBoundary render error',
1426-
// Retry because the error may be caused by a dependency on concurrent
1427-
// state like a store. Retrying can recover from errors that will
1428-
// succeed in the next render such as tearing.
1402+
// logs for error retry
14291403
'ErrorBoundary componentWillReceiveProps',
14301404
'ErrorBoundary componentWillUpdate',
14311405
'ErrorBoundary render success',
@@ -1484,9 +1458,7 @@ describe('ReactErrorBoundaries', () => {
14841458
// Render the error message
14851459
'ErrorBoundary componentWillUpdate',
14861460
'ErrorBoundary render error',
1487-
// Retry because the error may be caused by a dependency on concurrent
1488-
// state like a store. Retrying can recover from errors that will
1489-
// succeed in the next render such as tearing.
1461+
// logs for error retry
14901462
'ErrorBoundary componentWillReceiveProps',
14911463
'ErrorBoundary componentWillUpdate',
14921464
'ErrorBoundary render success',
@@ -1542,9 +1514,7 @@ describe('ReactErrorBoundaries', () => {
15421514
'ErrorBoundary static getDerivedStateFromError',
15431515
'ErrorBoundary componentWillUpdate',
15441516
'ErrorBoundary render error',
1545-
// Retry because the error may be caused by a dependency on concurrent
1546-
// state like a store. Retrying can recover from errors that will
1547-
// succeed in the next render such as tearing.
1517+
// logs for error retry
15481518
'ErrorBoundary componentWillReceiveProps',
15491519
'ErrorBoundary componentWillUpdate',
15501520
'ErrorBoundary render success',
@@ -1606,9 +1576,7 @@ describe('ReactErrorBoundaries', () => {
16061576
'ErrorBoundary static getDerivedStateFromError',
16071577
'ErrorBoundary componentWillUpdate',
16081578
'ErrorBoundary render error',
1609-
// Retry because the error may be caused by a dependency on concurrent
1610-
// state like a store. Retrying can recover from errors that will
1611-
// succeed in the next render such as tearing.
1579+
// logs for error retry
16121580
'ErrorBoundary componentWillReceiveProps',
16131581
'ErrorBoundary componentWillUpdate',
16141582
'ErrorBoundary render success',
@@ -1682,9 +1650,7 @@ describe('ReactErrorBoundaries', () => {
16821650
'ErrorBoundary static getDerivedStateFromError',
16831651
'ErrorBoundary componentWillUpdate',
16841652
'ErrorBoundary render error',
1685-
// Retry because the error may be caused by a dependency on concurrent
1686-
// state like a store. Retrying can recover from errors that will
1687-
// succeed in the next render such as tearing.
1653+
// logs for error retry
16881654
'ErrorBoundary componentWillReceiveProps',
16891655
'ErrorBoundary componentWillUpdate',
16901656
'ErrorBoundary render success',
@@ -2225,9 +2191,7 @@ describe('ReactErrorBoundaries', () => {
22252191

22262192
// verify flushed passive effects and handle the error
22272193
assertLog([
2228-
// Retry because the error may be caused by a dependency on concurrent
2229-
// state like a store. Retrying can recover from errors that will
2230-
// succeed in the next render such as tearing.
2194+
// logs for error retry
22312195
'ErrorBoundary constructor',
22322196
'ErrorBoundary componentWillMount',
22332197
'ErrorBoundary render success',
@@ -2487,9 +2451,7 @@ describe('ReactErrorBoundaries', () => {
24872451
'BrokenRender constructor',
24882452
'BrokenRender componentWillMount',
24892453
'BrokenRender render [!]',
2490-
// Retry because the error may be caused by a dependency on concurrent
2491-
// state like a store. Retrying can recover from errors that will
2492-
// succeed in the next render such as tearing.
2454+
// logs for error retry
24932455
'NoopErrorBoundary constructor',
24942456
'NoopErrorBoundary componentWillMount',
24952457
'NoopErrorBoundary render',

0 commit comments

Comments
 (0)