Skip to content

Commit 8a8d973

Browse files
committed
Use clearer wording
Fixes #13604
1 parent 7d1169b commit 8a8d973

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

packages/react-dom/src/client/ReactDOMComponent.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,9 @@ function setInitialDOMProperties(
302302
// Noop
303303
} else if (propKey === AUTOFOCUS) {
304304
// We polyfill it separately on the client during commit.
305-
// We blacklist it here rather than in the property list because we emit it in SSR.
305+
// We could have excluded it in the property list instead of
306+
// adding a special case here, but then it wouldn't be emitted
307+
// on server rendering (but we *do* want to emit it in SSR).
306308
} else if (registrationNameModules.hasOwnProperty(propKey)) {
307309
if (nextProp != null) {
308310
if (__DEV__ && typeof nextProp !== 'function') {

packages/react-dom/src/events/BeforeInputEventPlugin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ function getNativeBeforeInputChars(topLevelType: TopLevelType, nativeEvent) {
314314

315315
// If it's a spacebar character, assume that we have already handled
316316
// it at the keypress level and bail immediately. Android Chrome
317-
// doesn't give us keycodes, so we need to blacklist it.
317+
// doesn't give us keycodes, so we need to ignore it.
318318
if (chars === SPACEBAR_CHAR && hasSpaceKeypress) {
319319
return null;
320320
}

scripts/jest/config.build.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ packages.forEach(name => {
3232
module.exports = Object.assign({}, baseConfig, {
3333
// Redirect imports to the compiled bundles
3434
moduleNameMapper,
35-
// Don't run bundle tests on blacklisted -test.internal.* files
35+
// Don't run bundle tests on -test.internal.* files
3636
testPathIgnorePatterns: ['/node_modules/', '-test.internal.js$'],
3737
// Exclude the build output from transforms
3838
transformIgnorePatterns: ['/node_modules/', '<rootDir>/build/'],

scripts/rollup/build.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -250,9 +250,9 @@ function isProfilingBundleType(bundleType) {
250250
}
251251
}
252252

253-
function blacklistFBJS() {
253+
function forbidFBJSImports() {
254254
return {
255-
name: 'blacklistFBJS',
255+
name: 'forbidFBJSImports',
256256
resolveId(importee, importer) {
257257
if (/^fbjs\//.test(importee)) {
258258
throw new Error(
@@ -304,7 +304,7 @@ function getPlugins(
304304
// Shim any modules that need forking in this environment.
305305
useForks(forks),
306306
// Ensure we don't try to bundle any fbjs modules.
307-
blacklistFBJS(),
307+
forbidFBJSImports(),
308308
// Use Node resolution mechanism.
309309
resolve({
310310
skip: externals,

scripts/rollup/forks.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ const forks = Object.freeze({
162162
}
163163
},
164164

165-
// This logic is forked on www to blacklist warnings.
165+
// This logic is forked on www to ignore some warnings.
166166
'shared/lowPriorityWarning': (bundleType, entry) => {
167167
switch (bundleType) {
168168
case FB_WWW_DEV:
@@ -174,7 +174,7 @@ const forks = Object.freeze({
174174
}
175175
},
176176

177-
// This logic is forked on www to blacklist warnings.
177+
// This logic is forked on www to ignore some warnings.
178178
'shared/warningWithoutStack': (bundleType, entry) => {
179179
switch (bundleType) {
180180
case FB_WWW_DEV:

0 commit comments

Comments
 (0)