Skip to content

Commit 7b53202

Browse files
rickhanloniirickhanlonii
committed
Land enableAsyncActions enableFormActions in www (#28315)
DiffTrain build for [5d445b5](5d445b5)
1 parent 1985f4f commit 7b53202

29 files changed

Lines changed: 3181 additions & 4122 deletions

‎compiled/facebook-www/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
14fd9630ee04387f4361da289393234e2b7d93b6
1+
5d445b50a670d6cdc52943ca4e5ab3422792c57c

‎compiled/facebook-www/React-dev.classic.js‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (__DEV__) {
2424
) {
2525
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
2626
}
27-
var ReactVersion = "18.3.0-www-classic-38e30556";
27+
var ReactVersion = "18.3.0-www-classic-77190284";
2828

2929
// ATTENTION
3030
// When adding new symbols to this file,
@@ -475,7 +475,6 @@ if (__DEV__) {
475475

476476
var enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
477477
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
478-
enableAsyncActions = dynamicFeatureFlags.enableAsyncActions,
479478
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext; // On WWW, false is used for a new modern build.
480479

481480
function getWrappedName(outerType, innerType, wrapperName) {
@@ -3024,7 +3023,7 @@ if (__DEV__) {
30243023
}
30253024
}
30263025

3027-
if (enableAsyncActions) {
3026+
{
30283027
try {
30293028
var returnValue = scope();
30303029

@@ -3044,15 +3043,6 @@ if (__DEV__) {
30443043
warnAboutTransitionSubscriptions(prevTransition, currentTransition);
30453044
ReactCurrentBatchConfig.transition = prevTransition;
30463045
}
3047-
} else {
3048-
// When async actions are not enabled, startTransition does not
3049-
// capture errors.
3050-
try {
3051-
scope();
3052-
} finally {
3053-
warnAboutTransitionSubscriptions(prevTransition, currentTransition);
3054-
ReactCurrentBatchConfig.transition = prevTransition;
3055-
}
30563046
}
30573047
}
30583048

‎compiled/facebook-www/React-dev.modern.js‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (__DEV__) {
2424
) {
2525
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
2626
}
27-
var ReactVersion = "18.3.0-www-modern-f32f96e5";
27+
var ReactVersion = "18.3.0-www-modern-5d2c8ee0";
2828

2929
// ATTENTION
3030
// When adding new symbols to this file,
@@ -475,7 +475,6 @@ if (__DEV__) {
475475

476476
var enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
477477
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
478-
enableAsyncActions = dynamicFeatureFlags.enableAsyncActions,
479478
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext; // On WWW, true is used for a new modern build.
480479

481480
function getWrappedName(outerType, innerType, wrapperName) {
@@ -2989,7 +2988,7 @@ if (__DEV__) {
29892988
}
29902989
}
29912990

2992-
if (enableAsyncActions) {
2991+
{
29932992
try {
29942993
var returnValue = scope();
29952994

@@ -3009,15 +3008,6 @@ if (__DEV__) {
30093008
warnAboutTransitionSubscriptions(prevTransition, currentTransition);
30103009
ReactCurrentBatchConfig.transition = prevTransition;
30113010
}
3012-
} else {
3013-
// When async actions are not enabled, startTransition does not
3014-
// capture errors.
3015-
try {
3016-
scope();
3017-
} finally {
3018-
warnAboutTransitionSubscriptions(prevTransition, currentTransition);
3019-
ReactCurrentBatchConfig.transition = prevTransition;
3020-
}
30213011
}
30223012
}
30233013

‎compiled/facebook-www/React-prod.classic.js‎

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ pureComponentPrototype.isPureReactComponent = !0;
8484
var isArrayImpl = Array.isArray,
8585
dynamicFeatureFlags = require("ReactFeatureFlags"),
8686
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
87-
enableAsyncActions = dynamicFeatureFlags.enableAsyncActions,
8887
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
8988
hasOwnProperty = Object.prototype.hasOwnProperty,
9089
ReactCurrentOwner$1 = { current: null };
@@ -518,27 +517,20 @@ exports.startTransition = function (scope, options) {
518517
void 0 !== options.name &&
519518
((ReactCurrentBatchConfig.transition.name = options.name),
520519
(ReactCurrentBatchConfig.transition.startTime = -1));
521-
if (enableAsyncActions)
522-
try {
523-
var returnValue = scope();
524-
"object" === typeof returnValue &&
525-
null !== returnValue &&
526-
"function" === typeof returnValue.then &&
527-
(callbacks.forEach(function (callback) {
528-
return callback(currentTransition, returnValue);
529-
}),
530-
returnValue.then(noop, onError));
531-
} catch (error) {
532-
onError(error);
533-
} finally {
534-
ReactCurrentBatchConfig.transition = prevTransition;
535-
}
536-
else
537-
try {
538-
scope();
539-
} finally {
540-
ReactCurrentBatchConfig.transition = prevTransition;
541-
}
520+
try {
521+
var returnValue = scope();
522+
"object" === typeof returnValue &&
523+
null !== returnValue &&
524+
"function" === typeof returnValue.then &&
525+
(callbacks.forEach(function (callback) {
526+
return callback(currentTransition, returnValue);
527+
}),
528+
returnValue.then(noop, onError));
529+
} catch (error) {
530+
onError(error);
531+
} finally {
532+
ReactCurrentBatchConfig.transition = prevTransition;
533+
}
542534
};
543535
exports.unstable_Activity = REACT_OFFSCREEN_TYPE;
544536
exports.unstable_Cache = REACT_CACHE_TYPE;
@@ -626,4 +618,4 @@ exports.useSyncExternalStore = function (
626618
exports.useTransition = function () {
627619
return ReactCurrentDispatcher.current.useTransition();
628620
};
629-
exports.version = "18.3.0-www-classic-25a61d97";
621+
exports.version = "18.3.0-www-classic-a886996f";

‎compiled/facebook-www/React-prod.modern.js‎

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ pureComponentPrototype.isPureReactComponent = !0;
8383
var isArrayImpl = Array.isArray,
8484
dynamicFeatureFlags = require("ReactFeatureFlags"),
8585
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
86-
enableAsyncActions = dynamicFeatureFlags.enableAsyncActions,
8786
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
8887
hasOwnProperty = Object.prototype.hasOwnProperty,
8988
ReactCurrentOwner$1 = { current: null };
@@ -511,27 +510,20 @@ exports.startTransition = function (scope, options) {
511510
void 0 !== options.name &&
512511
((ReactCurrentBatchConfig.transition.name = options.name),
513512
(ReactCurrentBatchConfig.transition.startTime = -1));
514-
if (enableAsyncActions)
515-
try {
516-
var returnValue = scope();
517-
"object" === typeof returnValue &&
518-
null !== returnValue &&
519-
"function" === typeof returnValue.then &&
520-
(callbacks.forEach(function (callback) {
521-
return callback(currentTransition, returnValue);
522-
}),
523-
returnValue.then(noop, onError));
524-
} catch (error) {
525-
onError(error);
526-
} finally {
527-
ReactCurrentBatchConfig.transition = prevTransition;
528-
}
529-
else
530-
try {
531-
scope();
532-
} finally {
533-
ReactCurrentBatchConfig.transition = prevTransition;
534-
}
513+
try {
514+
var returnValue = scope();
515+
"object" === typeof returnValue &&
516+
null !== returnValue &&
517+
"function" === typeof returnValue.then &&
518+
(callbacks.forEach(function (callback) {
519+
return callback(currentTransition, returnValue);
520+
}),
521+
returnValue.then(noop, onError));
522+
} catch (error) {
523+
onError(error);
524+
} finally {
525+
ReactCurrentBatchConfig.transition = prevTransition;
526+
}
535527
};
536528
exports.unstable_Activity = REACT_OFFSCREEN_TYPE;
537529
exports.unstable_Cache = REACT_CACHE_TYPE;
@@ -618,4 +610,4 @@ exports.useSyncExternalStore = function (
618610
exports.useTransition = function () {
619611
return ReactCurrentDispatcher.current.useTransition();
620612
};
621-
exports.version = "18.3.0-www-modern-04e2d939";
613+
exports.version = "18.3.0-www-modern-d2591625";

‎compiled/facebook-www/React-profiling.classic.js‎

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ pureComponentPrototype.isPureReactComponent = !0;
8888
var isArrayImpl = Array.isArray,
8989
dynamicFeatureFlags = require("ReactFeatureFlags"),
9090
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
91-
enableAsyncActions = dynamicFeatureFlags.enableAsyncActions,
9291
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
9392
hasOwnProperty = Object.prototype.hasOwnProperty,
9493
ReactCurrentOwner$1 = { current: null };
@@ -522,27 +521,20 @@ exports.startTransition = function (scope, options) {
522521
void 0 !== options.name &&
523522
((ReactCurrentBatchConfig.transition.name = options.name),
524523
(ReactCurrentBatchConfig.transition.startTime = -1));
525-
if (enableAsyncActions)
526-
try {
527-
var returnValue = scope();
528-
"object" === typeof returnValue &&
529-
null !== returnValue &&
530-
"function" === typeof returnValue.then &&
531-
(callbacks.forEach(function (callback) {
532-
return callback(currentTransition, returnValue);
533-
}),
534-
returnValue.then(noop, onError));
535-
} catch (error) {
536-
onError(error);
537-
} finally {
538-
ReactCurrentBatchConfig.transition = prevTransition;
539-
}
540-
else
541-
try {
542-
scope();
543-
} finally {
544-
ReactCurrentBatchConfig.transition = prevTransition;
545-
}
524+
try {
525+
var returnValue = scope();
526+
"object" === typeof returnValue &&
527+
null !== returnValue &&
528+
"function" === typeof returnValue.then &&
529+
(callbacks.forEach(function (callback) {
530+
return callback(currentTransition, returnValue);
531+
}),
532+
returnValue.then(noop, onError));
533+
} catch (error) {
534+
onError(error);
535+
} finally {
536+
ReactCurrentBatchConfig.transition = prevTransition;
537+
}
546538
};
547539
exports.unstable_Activity = REACT_OFFSCREEN_TYPE;
548540
exports.unstable_Cache = REACT_CACHE_TYPE;
@@ -630,7 +622,7 @@ exports.useSyncExternalStore = function (
630622
exports.useTransition = function () {
631623
return ReactCurrentDispatcher.current.useTransition();
632624
};
633-
exports.version = "18.3.0-www-classic-0c80b4ef";
625+
exports.version = "18.3.0-www-classic-49d2df34";
634626
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
635627
"function" ===
636628
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-profiling.modern.js‎

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ pureComponentPrototype.isPureReactComponent = !0;
8787
var isArrayImpl = Array.isArray,
8888
dynamicFeatureFlags = require("ReactFeatureFlags"),
8989
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
90-
enableAsyncActions = dynamicFeatureFlags.enableAsyncActions,
9190
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
9291
hasOwnProperty = Object.prototype.hasOwnProperty,
9392
ReactCurrentOwner$1 = { current: null };
@@ -515,27 +514,20 @@ exports.startTransition = function (scope, options) {
515514
void 0 !== options.name &&
516515
((ReactCurrentBatchConfig.transition.name = options.name),
517516
(ReactCurrentBatchConfig.transition.startTime = -1));
518-
if (enableAsyncActions)
519-
try {
520-
var returnValue = scope();
521-
"object" === typeof returnValue &&
522-
null !== returnValue &&
523-
"function" === typeof returnValue.then &&
524-
(callbacks.forEach(function (callback) {
525-
return callback(currentTransition, returnValue);
526-
}),
527-
returnValue.then(noop, onError));
528-
} catch (error) {
529-
onError(error);
530-
} finally {
531-
ReactCurrentBatchConfig.transition = prevTransition;
532-
}
533-
else
534-
try {
535-
scope();
536-
} finally {
537-
ReactCurrentBatchConfig.transition = prevTransition;
538-
}
517+
try {
518+
var returnValue = scope();
519+
"object" === typeof returnValue &&
520+
null !== returnValue &&
521+
"function" === typeof returnValue.then &&
522+
(callbacks.forEach(function (callback) {
523+
return callback(currentTransition, returnValue);
524+
}),
525+
returnValue.then(noop, onError));
526+
} catch (error) {
527+
onError(error);
528+
} finally {
529+
ReactCurrentBatchConfig.transition = prevTransition;
530+
}
539531
};
540532
exports.unstable_Activity = REACT_OFFSCREEN_TYPE;
541533
exports.unstable_Cache = REACT_CACHE_TYPE;
@@ -622,7 +614,7 @@ exports.useSyncExternalStore = function (
622614
exports.useTransition = function () {
623615
return ReactCurrentDispatcher.current.useTransition();
624616
};
625-
exports.version = "18.3.0-www-modern-73e137c7";
617+
exports.version = "18.3.0-www-modern-20701ea1";
626618
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
627619
"function" ===
628620
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)