Skip to content

Commit 728c473

Browse files
committed
[string-refs] remove enableLogStringRefsProd flag (#31414)
We no longer need this production logging. DiffTrain build for [d1f0472](d1f0472)
1 parent eed58d4 commit 728c473

36 files changed

+122
-674
lines changed

compiled/facebook-www/JSXDEVRuntime-dev.classic.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -795,9 +795,7 @@ __DEV__ &&
795795
)
796796
(type = getComponentNameFromFiber(owner) || "Component"),
797797
didWarnAboutStringRefs[type] ||
798-
(enableLogStringRefsProd &&
799-
enableLogStringRefsProd(type, stringRef),
800-
error(
798+
(error(
801799
'Component "%s" contains the string ref "%s". Support for string refs will be removed in a future major release. We recommend using useRef() or createRef() instead. Learn more about using refs safely here: https://react.dev/link/strict-mode-string-ref',
802800
type,
803801
stringRef
@@ -820,7 +818,6 @@ __DEV__ &&
820818
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
821819
disableStringRefs = dynamicFeatureFlags.disableStringRefs,
822820
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
823-
enableLogStringRefsProd = dynamicFeatureFlags.enableLogStringRefsProd,
824821
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
825822
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
826823
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,

compiled/facebook-www/JSXDEVRuntime-dev.modern.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -792,9 +792,7 @@ __DEV__ &&
792792
)
793793
(type = getComponentNameFromFiber(owner) || "Component"),
794794
didWarnAboutStringRefs[type] ||
795-
(enableLogStringRefsProd &&
796-
enableLogStringRefsProd(type, stringRef),
797-
error(
795+
(error(
798796
'Component "%s" contains the string ref "%s". Support for string refs will be removed in a future major release. We recommend using useRef() or createRef() instead. Learn more about using refs safely here: https://react.dev/link/strict-mode-string-ref',
799797
type,
800798
stringRef
@@ -817,7 +815,6 @@ __DEV__ &&
817815
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
818816
disableStringRefs = dynamicFeatureFlags.disableStringRefs,
819817
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
820-
enableLogStringRefsProd = dynamicFeatureFlags.enableLogStringRefsProd,
821818
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
822819
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing;
823820
dynamicFeatureFlags = dynamicFeatureFlags.renameElementSymbol;

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
07aa494432e97f63fca9faf2fad6f76fead31063
1+
d1f04722d617600cc6cd96dcebc1c2ef7affc904
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
07aa494432e97f63fca9faf2fad6f76fead31063
1+
d1f04722d617600cc6cd96dcebc1c2ef7affc904

compiled/facebook-www/React-dev.classic.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -864,9 +864,7 @@ __DEV__ &&
864864
)
865865
(type = getComponentNameFromFiber(owner) || "Component"),
866866
didWarnAboutStringRefs[type] ||
867-
(enableLogStringRefsProd &&
868-
enableLogStringRefsProd(type, stringRef),
869-
error$jscomp$0(
867+
(error$jscomp$0(
870868
'Component "%s" contains the string ref "%s". Support for string refs will be removed in a future major release. We recommend using useRef() or createRef() instead. Learn more about using refs safely here: https://react.dev/link/strict-mode-string-ref',
871869
type,
872870
stringRef
@@ -1208,7 +1206,6 @@ __DEV__ &&
12081206
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
12091207
disableStringRefs = dynamicFeatureFlags.disableStringRefs,
12101208
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
1211-
enableLogStringRefsProd = dynamicFeatureFlags.enableLogStringRefsProd,
12121209
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
12131210
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
12141211
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
@@ -1998,7 +1995,7 @@ __DEV__ &&
19981995
exports.useTransition = function () {
19991996
return resolveDispatcher().useTransition();
20001997
};
2001-
exports.version = "19.0.0-www-classic-07aa4944-20241104";
1998+
exports.version = "19.0.0-www-classic-d1f04722-20241106";
20021999
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
20032000
"function" ===
20042001
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -861,9 +861,7 @@ __DEV__ &&
861861
)
862862
(type = getComponentNameFromFiber(owner) || "Component"),
863863
didWarnAboutStringRefs[type] ||
864-
(enableLogStringRefsProd &&
865-
enableLogStringRefsProd(type, stringRef),
866-
error$jscomp$0(
864+
(error$jscomp$0(
867865
'Component "%s" contains the string ref "%s". Support for string refs will be removed in a future major release. We recommend using useRef() or createRef() instead. Learn more about using refs safely here: https://react.dev/link/strict-mode-string-ref',
868866
type,
869867
stringRef
@@ -1205,7 +1203,6 @@ __DEV__ &&
12051203
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
12061204
disableStringRefs = dynamicFeatureFlags.disableStringRefs,
12071205
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
1208-
enableLogStringRefsProd = dynamicFeatureFlags.enableLogStringRefsProd,
12091206
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
12101207
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
12111208
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
@@ -1978,7 +1975,7 @@ __DEV__ &&
19781975
exports.useTransition = function () {
19791976
return resolveDispatcher().useTransition();
19801977
};
1981-
exports.version = "19.0.0-www-modern-07aa4944-20241104";
1978+
exports.version = "19.0.0-www-modern-d1f04722-20241106";
19821979
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19831980
"function" ===
19841981
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 9 additions & 146 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,9 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
1515
disableDefaultPropsExceptForClasses =
1616
dynamicFeatureFlags.disableDefaultPropsExceptForClasses,
1717
disableStringRefs = dynamicFeatureFlags.disableStringRefs,
18-
enableLogStringRefsProd = dynamicFeatureFlags.enableLogStringRefsProd,
1918
enableRenderableContext = dynamicFeatureFlags.enableRenderableContext,
2019
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
2120
renameElementSymbol = dynamicFeatureFlags.renameElementSymbol,
22-
disableLegacyMode = dynamicFeatureFlags.disableLegacyMode,
2321
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
2422
REACT_ELEMENT_TYPE = renameElementSymbol
2523
? Symbol.for("react.transitional.element")
@@ -93,143 +91,15 @@ pureComponentPrototype.constructor = PureComponent;
9391
assign(pureComponentPrototype, Component.prototype);
9492
pureComponentPrototype.isPureReactComponent = !0;
9593
var isArrayImpl = Array.isArray,
96-
REACT_CLIENT_REFERENCE = Symbol.for("react.client.reference");
97-
function getComponentNameFromType(type) {
98-
if (null == type) return null;
99-
if ("function" === typeof type)
100-
return type.$$typeof === REACT_CLIENT_REFERENCE
101-
? null
102-
: type.displayName || type.name || null;
103-
if ("string" === typeof type) return type;
104-
switch (type) {
105-
case REACT_FRAGMENT_TYPE:
106-
return "Fragment";
107-
case REACT_PORTAL_TYPE:
108-
return "Portal";
109-
case REACT_PROFILER_TYPE:
110-
return "Profiler";
111-
case REACT_STRICT_MODE_TYPE:
112-
return "StrictMode";
113-
case REACT_SUSPENSE_TYPE:
114-
return "Suspense";
115-
case REACT_SUSPENSE_LIST_TYPE:
116-
return "SuspenseList";
117-
case REACT_TRACING_MARKER_TYPE:
118-
if (enableTransitionTracing) return "TracingMarker";
119-
}
120-
if ("object" === typeof type)
121-
switch (type.$$typeof) {
122-
case REACT_PROVIDER_TYPE:
123-
if (enableRenderableContext) break;
124-
else return (type._context.displayName || "Context") + ".Provider";
125-
case REACT_CONTEXT_TYPE:
126-
return enableRenderableContext
127-
? (type.displayName || "Context") + ".Provider"
128-
: (type.displayName || "Context") + ".Consumer";
129-
case REACT_CONSUMER_TYPE:
130-
if (enableRenderableContext)
131-
return (type._context.displayName || "Context") + ".Consumer";
132-
break;
133-
case REACT_FORWARD_REF_TYPE:
134-
var innerType = type.render;
135-
type = type.displayName;
136-
type ||
137-
((type = innerType.displayName || innerType.name || ""),
138-
(type = "" !== type ? "ForwardRef(" + type + ")" : "ForwardRef"));
139-
return type;
140-
case REACT_MEMO_TYPE:
141-
return (
142-
(innerType = type.displayName || null),
143-
null !== innerType
144-
? innerType
145-
: getComponentNameFromType(type.type) || "Memo"
146-
);
147-
case REACT_LAZY_TYPE:
148-
innerType = type._payload;
149-
type = type._init;
150-
try {
151-
return getComponentNameFromType(type(innerType));
152-
} catch (x) {}
153-
}
154-
return null;
155-
}
156-
var ReactSharedInternals = { H: null, A: null, T: null, S: null },
94+
ReactSharedInternals = { H: null, A: null, T: null, S: null },
15795
hasOwnProperty = Object.prototype.hasOwnProperty;
158-
function getComponentNameFromFiber(fiber) {
159-
var type = fiber.type;
160-
switch (fiber.tag) {
161-
case 24:
162-
return "Cache";
163-
case 9:
164-
return enableRenderableContext
165-
? (type._context.displayName || "Context") + ".Consumer"
166-
: (type.displayName || "Context") + ".Consumer";
167-
case 10:
168-
return enableRenderableContext
169-
? (type.displayName || "Context") + ".Provider"
170-
: (type._context.displayName || "Context") + ".Provider";
171-
case 18:
172-
return "DehydratedFragment";
173-
case 11:
174-
return (
175-
(fiber = type.render),
176-
(fiber = fiber.displayName || fiber.name || ""),
177-
type.displayName ||
178-
("" !== fiber ? "ForwardRef(" + fiber + ")" : "ForwardRef")
179-
);
180-
case 7:
181-
return "Fragment";
182-
case 26:
183-
case 27:
184-
case 5:
185-
return type;
186-
case 4:
187-
return "Portal";
188-
case 3:
189-
return "Root";
190-
case 6:
191-
return "Text";
192-
case 16:
193-
return getComponentNameFromType(type);
194-
case 8:
195-
return type === REACT_STRICT_MODE_TYPE ? "StrictMode" : "Mode";
196-
case 22:
197-
return "Offscreen";
198-
case 12:
199-
return "Profiler";
200-
case 21:
201-
return "Scope";
202-
case 13:
203-
return "Suspense";
204-
case 19:
205-
return "SuspenseList";
206-
case 25:
207-
return "TracingMarker";
208-
case 17:
209-
case 28:
210-
if (disableLegacyMode) break;
211-
case 1:
212-
case 0:
213-
case 14:
214-
case 15:
215-
if ("function" === typeof type)
216-
return type.displayName || type.name || null;
217-
if ("string" === typeof type) return type;
218-
break;
219-
case 23:
220-
return "LegacyHidden";
221-
}
222-
return null;
223-
}
22496
function getOwner() {
22597
if (!disableStringRefs) {
22698
var dispatcher = ReactSharedInternals.A;
22799
return null === dispatcher ? null : dispatcher.getOwner();
228100
}
229101
return null;
230102
}
231-
var didWarnAboutStringRefs;
232-
enableLogStringRefsProd && (didWarnAboutStringRefs = {});
233103
function ReactElement(type, key, self, source, owner, props) {
234104
self = props.ref;
235105
self = void 0 !== self ? self : null;
@@ -268,9 +138,9 @@ function jsxProd(type, config, maybeKey) {
268138
} else maybeKey = config;
269139
if (!disableDefaultPropsExceptForClasses && type && type.defaultProps) {
270140
config = type.defaultProps;
271-
for (var propName$1 in config)
272-
void 0 === maybeKey[propName$1] &&
273-
(maybeKey[propName$1] = config[propName$1]);
141+
for (var propName$0 in config)
142+
void 0 === maybeKey[propName$0] &&
143+
(maybeKey[propName$0] = config[propName$0]);
274144
}
275145
return ReactElement(type, key, void 0, void 0, getOwner(), maybeKey);
276146
}
@@ -315,22 +185,15 @@ function stringRefAsCallbackRef(stringRef, type, owner, value) {
315185
throw Error(
316186
"Function components cannot have string refs. We recommend using useRef() instead. Learn more about using refs safely here: https://react.dev/link/strict-mode-string-ref"
317187
);
318-
enableLogStringRefsProd &&
319-
("function" !== typeof type ||
320-
(type.prototype && type.prototype.isReactComponent)) &&
321-
((type = getComponentNameFromFiber(owner) || "Component"),
322-
didWarnAboutStringRefs[type] ||
323-
(enableLogStringRefsProd && enableLogStringRefsProd(type, stringRef),
324-
(didWarnAboutStringRefs[type] = !0)));
325-
owner = owner.stateNode;
326-
if (!owner)
188+
type = owner.stateNode;
189+
if (!type)
327190
throw Error(
328191
"Missing owner for string ref " +
329192
stringRef +
330193
". This error is likely caused by a bug in React. Please file an issue."
331194
);
332-
owner = owner.refs;
333-
null === value ? delete owner[stringRef] : (owner[stringRef] = value);
195+
type = type.refs;
196+
null === value ? delete type[stringRef] : (type[stringRef] = value);
334197
}
335198
}
336199
function escape(key) {
@@ -823,4 +686,4 @@ exports.useSyncExternalStore = function (
823686
exports.useTransition = function () {
824687
return ReactSharedInternals.H.useTransition();
825688
};
826-
exports.version = "19.0.0-www-classic-07aa4944-20241104";
689+
exports.version = "19.0.0-www-classic-d1f04722-20241106";

0 commit comments

Comments
 (0)