Skip to content

Commit 64aba73

Browse files
jackpopejackpope
committed
Make renameElementSymbol dynamic for native fb (#32566)
Use variant to begin rolling this out internally. DiffTrain build for [50ab2dd](50ab2dd)
1 parent ffe288a commit 64aba73

30 files changed

+269
-178
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.1.0-native-fb-cc680065-20250307
1+
19.1.0-native-fb-50ab2dde-20250310

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5edff3291918daa3857981ff8465b386>>
10+
* @generated SignedSource<<6763b97d7b06065e3f5dc442add24cb9>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.1.0-native-fb-cc680065-20250307";
407+
exports.version = "19.1.0-native-fb-50ab2dde-20250310";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<588a475c946866c40c1cf959e83fadd6>>
10+
* @generated SignedSource<<474d18a52fd73302db5fedbf7a66886b>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.1.0-native-fb-cc680065-20250307";
206+
exports.version = "19.1.0-native-fb-50ab2dde-20250310";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<588a475c946866c40c1cf959e83fadd6>>
10+
* @generated SignedSource<<474d18a52fd73302db5fedbf7a66886b>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.1.0-native-fb-cc680065-20250307";
206+
exports.version = "19.1.0-native-fb-50ab2dde-20250310";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<0538a76ba9831542fbb02dae6934c679>>
10+
* @generated SignedSource<<f3f5787e9cfdbd2fd44d8101d37054e0>>
1111
*/
1212

1313
/*
@@ -22353,9 +22353,12 @@ __DEV__ &&
2235322353
enableUseEffectCRUDOverload =
2235422354
dynamicFlagsUntyped.enableUseEffectCRUDOverload,
2235522355
enableSiblingPrerendering = dynamicFlagsUntyped.enableSiblingPrerendering,
22356+
renameElementSymbol = dynamicFlagsUntyped.renameElementSymbol,
2235622357
assign = Object.assign,
2235722358
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
22358-
REACT_ELEMENT_TYPE = REACT_LEGACY_ELEMENT_TYPE,
22359+
REACT_ELEMENT_TYPE = renameElementSymbol
22360+
? Symbol.for("react.transitional.element")
22361+
: REACT_LEGACY_ELEMENT_TYPE,
2235922362
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
2236022363
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
2236122364
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -26064,11 +26067,11 @@ __DEV__ &&
2606426067
};
2606526068
(function () {
2606626069
var isomorphicReactPackageVersion = React.version;
26067-
if ("19.1.0-native-fb-cc680065-20250307" !== isomorphicReactPackageVersion)
26070+
if ("19.1.0-native-fb-50ab2dde-20250310" !== isomorphicReactPackageVersion)
2606826071
throw Error(
2606926072
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2607026073
(isomorphicReactPackageVersion +
26071-
"\n - react-dom: 19.1.0-native-fb-cc680065-20250307\nLearn more: https://react.dev/warnings/version-mismatch")
26074+
"\n - react-dom: 19.1.0-native-fb-50ab2dde-20250310\nLearn more: https://react.dev/warnings/version-mismatch")
2607226075
);
2607326076
})();
2607426077
("function" === typeof Map &&
@@ -26105,10 +26108,10 @@ __DEV__ &&
2610526108
!(function () {
2610626109
var internals = {
2610726110
bundleType: 1,
26108-
version: "19.1.0-native-fb-cc680065-20250307",
26111+
version: "19.1.0-native-fb-50ab2dde-20250310",
2610926112
rendererPackageName: "react-dom",
2611026113
currentDispatcherRef: ReactSharedInternals,
26111-
reconcilerVersion: "19.1.0-native-fb-cc680065-20250307"
26114+
reconcilerVersion: "19.1.0-native-fb-50ab2dde-20250310"
2611226115
};
2611326116
internals.overrideHookState = overrideHookState;
2611426117
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26252,5 +26255,5 @@ __DEV__ &&
2625226255
listenToAllSupportedEvents(container);
2625326256
return new ReactDOMHydrationRoot(initialChildren);
2625426257
};
26255-
exports.version = "19.1.0-native-fb-cc680065-20250307";
26258+
exports.version = "19.1.0-native-fb-50ab2dde-20250310";
2625626259
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<203350160db7029b23ae52387671cd50>>
10+
* @generated SignedSource<<7126c1f0f7c0312944b43bbbd6d55b06>>
1111
*/
1212

1313
/*
@@ -40,7 +40,8 @@ var alwaysThrottleRetries = dynamicFlagsUntyped.alwaysThrottleRetries,
4040
enablePersistedModeClonedFlag =
4141
dynamicFlagsUntyped.enablePersistedModeClonedFlag,
4242
enableUseEffectCRUDOverload = dynamicFlagsUntyped.enableUseEffectCRUDOverload,
43-
enableSiblingPrerendering = dynamicFlagsUntyped.enableSiblingPrerendering;
43+
enableSiblingPrerendering = dynamicFlagsUntyped.enableSiblingPrerendering,
44+
renameElementSymbol = dynamicFlagsUntyped.renameElementSymbol;
4445
function isValidContainer(node) {
4546
return !(
4647
!node ||
@@ -155,6 +156,9 @@ function findCurrentHostFiberImpl(node) {
155156
}
156157
var assign = Object.assign,
157158
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
159+
REACT_ELEMENT_TYPE = renameElementSymbol
160+
? Symbol.for("react.transitional.element")
161+
: REACT_LEGACY_ELEMENT_TYPE,
158162
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
159163
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
160164
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -5087,7 +5091,7 @@ function createChildReconciler(shouldTrackSideEffects) {
50875091
);
50885092
if ("object" === typeof newChild && null !== newChild) {
50895093
switch (newChild.$$typeof) {
5090-
case REACT_LEGACY_ELEMENT_TYPE:
5094+
case REACT_ELEMENT_TYPE:
50915095
return (
50925096
(lanes = createFiberFromTypeAndProps(
50935097
newChild.type,
@@ -5151,7 +5155,7 @@ function createChildReconciler(shouldTrackSideEffects) {
51515155
: updateTextNode(returnFiber, oldFiber, "" + newChild, lanes);
51525156
if ("object" === typeof newChild && null !== newChild) {
51535157
switch (newChild.$$typeof) {
5154-
case REACT_LEGACY_ELEMENT_TYPE:
5158+
case REACT_ELEMENT_TYPE:
51555159
return newChild.key === key
51565160
? updateElement(returnFiber, oldFiber, newChild, lanes)
51575161
: null;
@@ -5206,7 +5210,7 @@ function createChildReconciler(shouldTrackSideEffects) {
52065210
);
52075211
if ("object" === typeof newChild && null !== newChild) {
52085212
switch (newChild.$$typeof) {
5209-
case REACT_LEGACY_ELEMENT_TYPE:
5213+
case REACT_ELEMENT_TYPE:
52105214
return (
52115215
(existingChildren =
52125216
existingChildren.get(
@@ -5442,7 +5446,7 @@ function createChildReconciler(shouldTrackSideEffects) {
54425446
(newChild = newChild.props.children);
54435447
if ("object" === typeof newChild && null !== newChild) {
54445448
switch (newChild.$$typeof) {
5445-
case REACT_LEGACY_ELEMENT_TYPE:
5449+
case REACT_ELEMENT_TYPE:
54465450
a: {
54475451
for (var key = newChild.key; null !== currentFirstChild; ) {
54485452
if (currentFirstChild.key === key) {
@@ -16173,14 +16177,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1617316177
};
1617416178
var isomorphicReactPackageVersion$jscomp$inline_1817 = React.version;
1617516179
if (
16176-
"19.1.0-native-fb-cc680065-20250307" !==
16180+
"19.1.0-native-fb-50ab2dde-20250310" !==
1617716181
isomorphicReactPackageVersion$jscomp$inline_1817
1617816182
)
1617916183
throw Error(
1618016184
formatProdErrorMessage(
1618116185
527,
1618216186
isomorphicReactPackageVersion$jscomp$inline_1817,
16183-
"19.1.0-native-fb-cc680065-20250307"
16187+
"19.1.0-native-fb-50ab2dde-20250310"
1618416188
)
1618516189
);
1618616190
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16202,10 +16206,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1620216206
};
1620316207
var internals$jscomp$inline_2290 = {
1620416208
bundleType: 0,
16205-
version: "19.1.0-native-fb-cc680065-20250307",
16209+
version: "19.1.0-native-fb-50ab2dde-20250310",
1620616210
rendererPackageName: "react-dom",
1620716211
currentDispatcherRef: ReactSharedInternals,
16208-
reconcilerVersion: "19.1.0-native-fb-cc680065-20250307"
16212+
reconcilerVersion: "19.1.0-native-fb-50ab2dde-20250310"
1620916213
};
1621016214
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1621116215
var hook$jscomp$inline_2291 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16309,4 +16313,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1630916313
listenToAllSupportedEvents(container);
1631016314
return new ReactDOMHydrationRoot(initialChildren);
1631116315
};
16312-
exports.version = "19.1.0-native-fb-cc680065-20250307";
16316+
exports.version = "19.1.0-native-fb-50ab2dde-20250310";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7a330aec4fa972445bd767d7231bc931>>
10+
* @generated SignedSource<<d5ae63fdb72be023e5dff41f0e572cd2>>
1111
*/
1212

1313
/*
@@ -40,7 +40,8 @@ var alwaysThrottleRetries = dynamicFlagsUntyped.alwaysThrottleRetries,
4040
enablePersistedModeClonedFlag =
4141
dynamicFlagsUntyped.enablePersistedModeClonedFlag,
4242
enableUseEffectCRUDOverload = dynamicFlagsUntyped.enableUseEffectCRUDOverload,
43-
enableSiblingPrerendering = dynamicFlagsUntyped.enableSiblingPrerendering;
43+
enableSiblingPrerendering = dynamicFlagsUntyped.enableSiblingPrerendering,
44+
renameElementSymbol = dynamicFlagsUntyped.renameElementSymbol;
4445
function isValidContainer(node) {
4546
return !(
4647
!node ||
@@ -155,6 +156,9 @@ function findCurrentHostFiberImpl(node) {
155156
}
156157
var assign = Object.assign,
157158
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
159+
REACT_ELEMENT_TYPE = renameElementSymbol
160+
? Symbol.for("react.transitional.element")
161+
: REACT_LEGACY_ELEMENT_TYPE,
158162
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
159163
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
160164
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -5227,7 +5231,7 @@ function createChildReconciler(shouldTrackSideEffects) {
52275231
);
52285232
if ("object" === typeof newChild && null !== newChild) {
52295233
switch (newChild.$$typeof) {
5230-
case REACT_LEGACY_ELEMENT_TYPE:
5234+
case REACT_ELEMENT_TYPE:
52315235
return (
52325236
(lanes = createFiberFromTypeAndProps(
52335237
newChild.type,
@@ -5291,7 +5295,7 @@ function createChildReconciler(shouldTrackSideEffects) {
52915295
: updateTextNode(returnFiber, oldFiber, "" + newChild, lanes);
52925296
if ("object" === typeof newChild && null !== newChild) {
52935297
switch (newChild.$$typeof) {
5294-
case REACT_LEGACY_ELEMENT_TYPE:
5298+
case REACT_ELEMENT_TYPE:
52955299
return newChild.key === key
52965300
? updateElement(returnFiber, oldFiber, newChild, lanes)
52975301
: null;
@@ -5346,7 +5350,7 @@ function createChildReconciler(shouldTrackSideEffects) {
53465350
);
53475351
if ("object" === typeof newChild && null !== newChild) {
53485352
switch (newChild.$$typeof) {
5349-
case REACT_LEGACY_ELEMENT_TYPE:
5353+
case REACT_ELEMENT_TYPE:
53505354
return (
53515355
(existingChildren =
53525356
existingChildren.get(
@@ -5582,7 +5586,7 @@ function createChildReconciler(shouldTrackSideEffects) {
55825586
(newChild = newChild.props.children);
55835587
if ("object" === typeof newChild && null !== newChild) {
55845588
switch (newChild.$$typeof) {
5585-
case REACT_LEGACY_ELEMENT_TYPE:
5589+
case REACT_ELEMENT_TYPE:
55865590
a: {
55875591
for (var key = newChild.key; null !== currentFirstChild; ) {
55885592
if (currentFirstChild.key === key) {
@@ -16823,14 +16827,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1682316827
};
1682416828
var isomorphicReactPackageVersion$jscomp$inline_1912 = React.version;
1682516829
if (
16826-
"19.1.0-native-fb-cc680065-20250307" !==
16830+
"19.1.0-native-fb-50ab2dde-20250310" !==
1682716831
isomorphicReactPackageVersion$jscomp$inline_1912
1682816832
)
1682916833
throw Error(
1683016834
formatProdErrorMessage(
1683116835
527,
1683216836
isomorphicReactPackageVersion$jscomp$inline_1912,
16833-
"19.1.0-native-fb-cc680065-20250307"
16837+
"19.1.0-native-fb-50ab2dde-20250310"
1683416838
)
1683516839
);
1683616840
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16852,10 +16856,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1685216856
};
1685316857
var internals$jscomp$inline_1919 = {
1685416858
bundleType: 0,
16855-
version: "19.1.0-native-fb-cc680065-20250307",
16859+
version: "19.1.0-native-fb-50ab2dde-20250310",
1685616860
rendererPackageName: "react-dom",
1685716861
currentDispatcherRef: ReactSharedInternals,
16858-
reconcilerVersion: "19.1.0-native-fb-cc680065-20250307",
16862+
reconcilerVersion: "19.1.0-native-fb-50ab2dde-20250310",
1685916863
getLaneLabelMap: function () {
1686016864
for (
1686116865
var map = new Map(), lane = 1, index$294 = 0;
@@ -16974,4 +16978,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1697416978
listenToAllSupportedEvents(container);
1697516979
return new ReactDOMHydrationRoot(initialChildren);
1697616980
};
16977-
exports.version = "19.1.0-native-fb-cc680065-20250307";
16981+
exports.version = "19.1.0-native-fb-50ab2dde-20250310";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bdeb7247beb66d1cca26602f057756b5>>
10+
* @generated SignedSource<<e36ed991c4596ad688caa81cb1a007e4>>
1111
*/
1212

1313
/*
@@ -22414,9 +22414,12 @@ __DEV__ &&
2241422414
enableUseEffectCRUDOverload =
2241522415
dynamicFlagsUntyped.enableUseEffectCRUDOverload,
2241622416
enableSiblingPrerendering = dynamicFlagsUntyped.enableSiblingPrerendering,
22417+
renameElementSymbol = dynamicFlagsUntyped.renameElementSymbol,
2241722418
assign = Object.assign,
2241822419
REACT_LEGACY_ELEMENT_TYPE = Symbol.for("react.element"),
22419-
REACT_ELEMENT_TYPE = REACT_LEGACY_ELEMENT_TYPE,
22420+
REACT_ELEMENT_TYPE = renameElementSymbol
22421+
? Symbol.for("react.transitional.element")
22422+
: REACT_LEGACY_ELEMENT_TYPE,
2242022423
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
2242122424
REACT_FRAGMENT_TYPE = Symbol.for("react.fragment"),
2242222425
REACT_STRICT_MODE_TYPE = Symbol.for("react.strict_mode"),
@@ -26125,11 +26128,11 @@ __DEV__ &&
2612526128
};
2612626129
(function () {
2612726130
var isomorphicReactPackageVersion = React.version;
26128-
if ("19.1.0-native-fb-cc680065-20250307" !== isomorphicReactPackageVersion)
26131+
if ("19.1.0-native-fb-50ab2dde-20250310" !== isomorphicReactPackageVersion)
2612926132
throw Error(
2613026133
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2613126134
(isomorphicReactPackageVersion +
26132-
"\n - react-dom: 19.1.0-native-fb-cc680065-20250307\nLearn more: https://react.dev/warnings/version-mismatch")
26135+
"\n - react-dom: 19.1.0-native-fb-50ab2dde-20250310\nLearn more: https://react.dev/warnings/version-mismatch")
2613326136
);
2613426137
})();
2613526138
("function" === typeof Map &&
@@ -26166,10 +26169,10 @@ __DEV__ &&
2616626169
!(function () {
2616726170
var internals = {
2616826171
bundleType: 1,
26169-
version: "19.1.0-native-fb-cc680065-20250307",
26172+
version: "19.1.0-native-fb-50ab2dde-20250310",
2617026173
rendererPackageName: "react-dom",
2617126174
currentDispatcherRef: ReactSharedInternals,
26172-
reconcilerVersion: "19.1.0-native-fb-cc680065-20250307"
26175+
reconcilerVersion: "19.1.0-native-fb-50ab2dde-20250310"
2617326176
};
2617426177
internals.overrideHookState = overrideHookState;
2617526178
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26629,7 +26632,7 @@ __DEV__ &&
2662926632
exports.useFormStatus = function () {
2663026633
return resolveDispatcher().useHostTransitionStatus();
2663126634
};
26632-
exports.version = "19.1.0-native-fb-cc680065-20250307";
26635+
exports.version = "19.1.0-native-fb-50ab2dde-20250310";
2663326636
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2663426637
"function" ===
2663526638
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)