Fizz: Prevent UnhandledPromiseRejection if shell errors

eps1lon · eps1lon · commit 528e2f4d3e3c · 2022-03-08T10:19:17.000+01:00
diff --git a/packages/react-dom/src/server/ReactDOMFizzServerBrowser.js b/packages/react-dom/src/server/ReactDOMFizzServerBrowser.js
@@ -67,6 +67,10 @@ function renderToReadableStream(
       resolve(stream);
     }
     function onShellError(error: mixed) {
+      // If the shell errors the caller of `renderToReadableStream` won't have access to `allReady`.
+      // However, `allReady` will be rejected by `onFatalError` as well.
+      // So we need to catch the duplicate, uncatchable fatal error in `allReady` to prevent a `UnhandledPromiseRejection`.
+      allReady.catch(() => {});
       reject(error);
     }
     const request = createRequest(

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,10 @@ function renderToReadableStream(`
`67`	`67`	`resolve(stream);`
`68`	`68`	`}`
`69`	`69`	`function onShellError(error: mixed) {`
	`70`	+ // If the shell errors the caller of `renderToReadableStream` won't have access to `allReady`.
	`71`	+ // However, `allReady` will be rejected by `onFatalError` as well.
	`72`	+ // So we need to catch the duplicate, uncatchable fatal error in `allReady` to prevent a `UnhandledPromiseRejection`.
	`73`	`+ allReady.catch(() => {});`
`70`	`74`	`reject(error);`
`71`	`75`	`}`
`72`	`76`	`const request = createRequest(`