Replaced warning() with console.error()

Author: Brian Vaughn

packages/react-native-renderer/src/ReactFabricRenderer.js

@@ -23,7 +23,6 @@ import ReactFiberReconciler from 'react-reconciler';
 
 import deepFreezeAndThrowOnMutationInDev from 'deepFreezeAndThrowOnMutationInDev';
 import emptyObject from 'fbjs/lib/emptyObject';
-import warning from 'fbjs/lib/warning';
 
 // Modules provided by RN:
 import TextInputState from 'TextInputState';
@@ -155,10 +154,13 @@ const ReactFabricRenderer = ReactFiberReconciler({
         }
       }
 
-      warning(
-        type !== 'RCTView' || !hostContext.isInAParentText,
-        'Nesting of <View> within <Text> is not currently supported.',
-      );
+      if (type === 'RCTView' && hostContext.isInAParentText) {
+        // Intentional use of console.error() rather than fbjs warning(),
+        // So that React Native redbox is used (rather than yellow box).
+        console.error(
+          'Nesting of <View> within <Text> is not currently supported.',
+        );
+      }
     }
 
     const updatePayload = ReactNativeAttributePayload.create(
@@ -189,10 +191,13 @@ const ReactFabricRenderer = ReactFiberReconciler({
     internalInstanceHandle: Object,
   ): TextInstance {
     if (__DEV__) {
-      warning(
-        hostContext.isInAParentText,
-        'Text strings must be rendered within a <Text>.',
-      );
+      if (!hostContext.isInAParentText) {
+        // Intentional use of console.error() rather than fbjs warning(),
+        // So that React Native redbox is used (rather than yellow box).
+        console.error(
+          'Text strings must be rendered within a <Text> component.',
+        );
+      }
     }
 
     const tag = nextReactTag;

packages/react-native-renderer/src/ReactNativeFiberRenderer.js

@@ -12,7 +12,7 @@ import type {ReactNativeBaseComponentViewConfig} from './ReactNativeTypes';
 import ReactFiberReconciler from 'react-reconciler';
 import emptyObject from 'fbjs/lib/emptyObject';
 import invariant from 'fbjs/lib/invariant';
-import warning from 'fbjs/lib/warning';
+
 // Modules provided by RN:
 import UIManager from 'UIManager';
 import deepFreezeAndThrowOnMutationInDev from 'deepFreezeAndThrowOnMutationInDev';
@@ -89,10 +89,13 @@ const NativeRenderer = ReactFiberReconciler({
         }
       }
 
-      warning(
-        type !== 'RCTView' || !hostContext.isInAParentText,
-        'Nesting of <View> within <Text> is not currently supported.',
-      );
+      if (type === 'RCTView' && hostContext.isInAParentText) {
+        // Intentional use of console.error() rather than fbjs warning(),
+        // So that React Native redbox is used (rather than yellow box).
+        console.error(
+          'Nesting of <View> within <Text> is not currently supported.',
+        );
+      }
     }
 
     const updatePayload = ReactNativeAttributePayload.create(
@@ -124,10 +127,13 @@ const NativeRenderer = ReactFiberReconciler({
     internalInstanceHandle: Object,
   ): TextInstance {
     if (__DEV__) {
-      warning(
-        hostContext.isInAParentText,
-        'Text strings must be rendered within a <Text>.',
-      );
+      if (!hostContext.isInAParentText) {
+        // Intentional use of console.error() rather than fbjs warning(),
+        // So that React Native redbox is used (rather than yellow box).
+        console.error(
+          'Text strings must be rendered within a <Text> component.',
+        );
+      }
     }
 
     const tag = allocateTag();

packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js

@@ -321,7 +321,7 @@ describe('ReactFabric', () => {
 
     expect(() =>
       ReactFabric.render(<View>this should warn</View>, 11),
-    ).toWarnDev('Text strings must be rendered within a <Text>.');
+    ).toWarnDev('Text strings must be rendered within a <Text> component.');
 
     expect(() =>
       ReactFabric.render(
@@ -330,7 +330,7 @@ describe('ReactFabric', () => {
         </Text>,
         11,
       ),
-    ).toWarnDev('Text strings must be rendered within a <Text>.');
+    ).toWarnDev('Text strings must be rendered within a <Text> component.');
   });
 
   it('should not warn warn about text inside of an indirect <Text> ancestor', () => {

packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js

@@ -231,7 +231,7 @@ describe('ReactNative', () => {
 
     expect(() =>
       ReactNative.render(<View>this should warn</View>, 11),
-    ).toWarnDev('Text strings must be rendered within a <Text>.');
+    ).toWarnDev('Text strings must be rendered within a <Text> component.');
 
     expect(() =>
       ReactNative.render(
@@ -240,7 +240,7 @@ describe('ReactNative', () => {
         </Text>,
         11,
       ),
-    ).toWarnDev('Text strings must be rendered within a <Text>.');
+    ).toWarnDev('Text strings must be rendered within a <Text> component.');
   });
 
   it('should not warn warn about text inside of an indirect <Text> ancestor', () => {