Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Jun 2, 2025

Summary:

The current Devtools.d.ts doesn't match the parseErrorStack.js and symbolicateStackTrace.js implementations.

I've tried to run build-types, but only symbolicateStackTrace.d.ts was generated. I've not checked why.

Changelog:

[GENERAL] [FIXED] - Devtools TS Types

Test Plan:

Call parseErrorStack and symbolicateStackTrace in TS.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Sentry Partner: Sentry Partner labels Jun 2, 2025
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 2, 2025
@huntie
Copy link
Member

huntie commented Jun 2, 2025

We can accept this, however please bear in mind this is a stopgap fix to the existing types, accessible via Libraries/....

@facebook-github-bot
Copy link
Contributor

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@krystofwoldrich
Copy link
Contributor Author

krystofwoldrich commented Jun 2, 2025

@huntie Thank you, got it. I've missed the RFC.

Just out of interest and to clarify, will the APIs like parseErrorStack and symbolicateStackTrace exist in 0.82+, just won't be officially part of the public APIs, or is there a plan to remove them completely?

After taking a second look, I understand the exports will be removed.

@facebook-github-bot
Copy link
Contributor

@huntie merged this pull request in 8f189fc.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @krystofwoldrich in 8f189fc

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Sentry Partner: Sentry Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants