diff --git a/packages/react-native/Libraries/Network/RCTNetworking.android.js b/packages/react-native/Libraries/Network/RCTNetworking.android.js index a83bd28a971862..a957a09a4a2c6c 100644 --- a/packages/react-native/Libraries/Network/RCTNetworking.android.js +++ b/packages/react-native/Libraries/Network/RCTNetworking.android.js @@ -59,7 +59,7 @@ const RCTNetworking = { sendRequest( method: string, - trackingName: ?string, + trackingName: string | void, url: string, headers: Object, data: RequestBody, diff --git a/packages/react-native/Libraries/Network/RCTNetworking.ios.js b/packages/react-native/Libraries/Network/RCTNetworking.ios.js index 40035ff1f6aeb1..dcabadec9fdb5f 100644 --- a/packages/react-native/Libraries/Network/RCTNetworking.ios.js +++ b/packages/react-native/Libraries/Network/RCTNetworking.ios.js @@ -29,7 +29,7 @@ const RCTNetworking = { sendRequest( method: string, - trackingName: ?string, + trackingName: string | void, url: string, headers: {...}, data: RequestBody, diff --git a/packages/react-native/Libraries/Network/RCTNetworking.js.flow b/packages/react-native/Libraries/Network/RCTNetworking.js.flow index 59e4a0b3924d58..a5dab051943396 100644 --- a/packages/react-native/Libraries/Network/RCTNetworking.js.flow +++ b/packages/react-native/Libraries/Network/RCTNetworking.js.flow @@ -25,7 +25,7 @@ declare const RCTNetworking: interface { sendRequest( method: string, - trackingName: ?string, + trackingName: string | void, url: string, headers: {...}, data: RequestBody, diff --git a/packages/react-native/Libraries/Network/XMLHttpRequest.js b/packages/react-native/Libraries/Network/XMLHttpRequest.js index 9208f614fb0f55..d963e07a474154 100644 --- a/packages/react-native/Libraries/Network/XMLHttpRequest.js +++ b/packages/react-native/Libraries/Network/XMLHttpRequest.js @@ -170,7 +170,7 @@ class XMLHttpRequest extends EventTarget { _sent: boolean; _url: ?string = null; _timedOut: boolean = false; - _trackingName: string | void = undefined; + _trackingName: ?string; _incrementalEvents: boolean = false; _startTime: ?number = null; _performanceLogger: IPerformanceLogger = GlobalPerformanceLogger; @@ -534,7 +534,7 @@ class XMLHttpRequest extends EventTarget { /** * Custom extension for tracking origins of request. */ - setTrackingName(trackingName: string | void): XMLHttpRequest { + setTrackingName(trackingName: ?string): XMLHttpRequest { this._trackingName = trackingName; return this; } @@ -632,7 +632,7 @@ class XMLHttpRequest extends EventTarget { ); RCTNetworking.sendRequest( this._method, - this._trackingName, + this._trackingName ?? undefined, this._url, this._headers, data, diff --git a/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap b/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap index a4ca1c0951ae9f..cf3cda189433e5 100644 --- a/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap +++ b/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap @@ -5916,7 +5916,7 @@ exports[`public API should not change unintentionally Libraries/Network/RCTNetwo ): EventSubscription, sendRequest( method: string, - trackingName: ?string, + trackingName: string | void, url: string, headers: { ... }, data: RequestBody, @@ -6010,7 +6010,7 @@ declare class XMLHttpRequest extends EventTarget { getAllResponseHeaders(): ?string; getResponseHeader(header: string): ?string; setRequestHeader(header: string, value: any): void; - setTrackingName(trackingName: string | void): XMLHttpRequest; + setTrackingName(trackingName: ?string): XMLHttpRequest; setPerformanceLogger(performanceLogger: IPerformanceLogger): XMLHttpRequest; open(method: string, url: string, async: ?boolean): void; send(data: any): void;