Add support for handling com.facebook.react.bridge.Dynamic as parameter type in TurboModules
#45944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60966684 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60966684 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Aug 8, 2024
…eter type in TurboModules (facebook#45944) Summary: Pull Request resolved: facebook#45944 This diff adds support having (Legacy) Native Modules with functions with parameters of type `Dynamic`. This is currently blocking some libraries making it harder for them to migrate to New Architecture. I've implemented it by adding a `DynamicNative` implementation of `Dynamic` which holds a reference of the payload as a `folly::dynamic`. Changelog: [Android] [Added] - Add support for handling `com.facebook.react.bridge.Dynamic` as parameter type in TurboModules Differential Revision: D60966684
cortinico
force-pushed
the
export-D60966684
branch
from
8454ace to
6230866
Compare
…eter type in TurboModules (facebook#45944) Summary: Pull Request resolved: facebook#45944 This diff adds support having (Legacy) Native Modules with functions with parameters of type `Dynamic`. This is currently blocking some libraries making it harder for them to migrate to New Architecture. I've implemented it by adding a `DynamicNative` implementation of `Dynamic` which holds a reference of the payload as a `folly::dynamic`. Changelog: [Android] [Added] - Add support for handling `com.facebook.react.bridge.Dynamic` as parameter type in TurboModules Reviewed By: cipolleschi Differential Revision: D60966684
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60966684 |
cortinico
force-pushed
the
export-D60966684
branch
from
6230866 to
8a06d96
Compare
Contributor
|
This pull request has been merged in d01f1b3. |
Collaborator
|
This pull request was successfully merged by @cortinico in d01f1b3 When will my fix make it into a release? | How to file a pick request? |
cortinico
added a commit
that referenced
this pull request
Aug 16, 2024
…eter type in TurboModules (#45944) Summary: Pull Request resolved: #45944 This diff adds support having (Legacy) Native Modules with functions with parameters of type `Dynamic`. This is currently blocking some libraries making it harder for them to migrate to New Architecture. I've implemented it by adding a `DynamicNative` implementation of `Dynamic` which holds a reference of the payload as a `folly::dynamic`. Changelog: [Android] [Added] - Add support for handling `com.facebook.react.bridge.Dynamic` as parameter type in TurboModules Reviewed By: mdvacca, cipolleschi Differential Revision: D60966684 fbshipit-source-id: 2e63bc53ede5277a9c12f1b19f05f6099f5f35f9
|
This pull request was successfully merged by @cortinico in 7716b58. When will my fix make it into a release? | How to file a pick request? |
cortinico
added a commit
that referenced
this pull request
Aug 16, 2024
…eter type in TurboModules (#45944) Summary: Pull Request resolved: #45944 This diff adds support having (Legacy) Native Modules with functions with parameters of type `Dynamic`. This is currently blocking some libraries making it harder for them to migrate to New Architecture. I've implemented it by adding a `DynamicNative` implementation of `Dynamic` which holds a reference of the payload as a `folly::dynamic`. Changelog: [Android] [Added] - Add support for handling `com.facebook.react.bridge.Dynamic` as parameter type in TurboModules Reviewed By: mdvacca, cipolleschi Differential Revision: D60966684 fbshipit-source-id: 2e63bc53ede5277a9c12f1b19f05f6099f5f35f9
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds support having (Legacy) Native Modules with functions with parameters of type
Dynamic.This is currently blocking some libraries making it harder for them to migrate to New Architecture.
I've implemented it by adding a
DynamicNativeimplementation ofDynamicwhich holds a reference ofthe payload as a
folly::dynamic.Changelog:
[Android] [Added] - Add support for handling
com.facebook.react.bridge.Dynamicas parameter type in TurboModulesDifferential Revision: D60966684