Use TypeScript by default for new applications (#35165)

NickGerleman · facebook-github-bot · commit e0d80f1ac117 · 2022-11-02T01:25:31.000-07:00
Summary: This change moves the default new application template in OSS from Flow to TypeScript. This better aligns with the communities usage, and aligns to the great work that has been happening for TS codegen and built-in types. This is largely derived from [`react-native-community/react-native-template-typescript`](https://github.com/react-native-community/react-native-template-typescript), maintained by radko93, with a couple of changes. 1. Updated `types/*` devDependencies to match bumped libraries (e.g. Jest 26 to 20). 2. Removes `types/react-native` 3. Removed explicit `moduleFileExtensions` to Jest config in package.json (TS and TSX and added by default in current versions) 4. Removes overrides to eslint config to disable `no-shadow` and `no-undef`, since this was fixed in the underlying eslint config with #32644 and #32655 5. Re-translated `App.js` to be a direct translation (e.g. still a raw function instead of React.FC which is sometimes discouraged) 6. Aligns completely to `tsconfig/react-native` maintained configuration (We no longer have the opinionated override of `skipLibCheck`). The important settings are that `strict` is enabled for, but `allowJS` is also enabled to let users import JS modules without anything unexpected. `esModuleInterop` is enabled, which is needed for consistency with Babel import transformations used by Metro. Consistent with our [current documentation](https://reactnative.dev/docs/typescript) built against the community template, `tsc` will typecheck your code without emitting(building) anything. I discovered through this change that the way 'Utilities' is imported in typings doesn't seem to work in the template app use-case (but works in the RN repo?). Fixed up those imports. We also partially revert f49b251 which deleted typings. Checking to make sure we keep these in the appropriate place in the future. [Documentation](https://reactnative.dev/docs/typescript) will need to be updated as a followup. Changelog: [General][Changed] - Use Vanilla JS in the App Template Pull Request resolved: #35165 Test Plan: Added usage of `tsc` and `jest` when validating a newly built app. Passes in CircleCI `test_js` job. This also meant removing some cases of copying packages into the users app to pull in the root Metro config (we seem to be able to use the template Metro config consistent with what real apps would get). Differential Revision: D40911951 Pulled By: NickGerleman fbshipit-source-id: 81136e2aa2602d074107e1fbe8110498406e6ac9
diff --git a/Libraries/Components/ActivityIndicator/ActivityIndicator.d.ts b/Libraries/Components/ActivityIndicator/ActivityIndicator.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ColorValue, StyleProp} from '../../StyleSheet/StyleSheet';
 import {ViewStyle} from '../../StyleSheet/StyleSheetTypes';
diff --git a/Libraries/Components/DatePicker/DatePickerIOS.d.ts b/Libraries/Components/DatePicker/DatePickerIOS.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ViewProps} from '../View/ViewPropTypes';
 
diff --git a/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.d.ts b/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ColorValue} from '../../StyleSheet/StyleSheet';
 import {
diff --git a/Libraries/Components/Keyboard/KeyboardAvoidingView.d.ts b/Libraries/Components/Keyboard/KeyboardAvoidingView.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor, TimerMixin} from 'Utilities';
+import {Constructor, TimerMixin} from '../../../types/Utilities';
 import {StyleProp} from '../../StyleSheet/StyleSheet';
 import {ViewStyle} from '../../StyleSheet/StyleSheetTypes';
 import {ViewProps} from '../View/ViewPropTypes';
diff --git a/Libraries/Components/Pressable/Pressable.d.ts b/Libraries/Components/Pressable/Pressable.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Insets} from 'Utilities';
+import {Insets} from '../../../types/Utilities';
 import {ColorValue, StyleProp} from '../../StyleSheet/StyleSheet';
 import {ViewStyle} from '../../StyleSheet/StyleSheetTypes';
 import {
diff --git a/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.d.ts b/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ColorValue} from '../../StyleSheet/StyleSheet';
 import {ViewProps} from '../View/ViewPropTypes';
diff --git a/Libraries/Components/ProgressViewIOS/ProgressViewIOS.d.ts b/Libraries/Components/ProgressViewIOS/ProgressViewIOS.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {ImageURISource} from '../../Image/ImageSource';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ColorValue} from '../../StyleSheet/StyleSheet';
diff --git a/Libraries/Components/RefreshControl/RefreshControl.d.ts b/Libraries/Components/RefreshControl/RefreshControl.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ColorValue} from '../../StyleSheet/StyleSheet';
 import {ViewProps} from '../View/ViewPropTypes';
diff --git a/Libraries/Components/SafeAreaView/SafeAreaView.d.ts b/Libraries/Components/SafeAreaView/SafeAreaView.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ViewProps} from '../View/ViewPropTypes';
 
diff --git a/Libraries/Components/ScrollView/ScrollView.d.ts b/Libraries/Components/ScrollView/ScrollView.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor, Insets} from 'Utilities';
+import {Constructor, Insets} from '../../../types/Utilities';
 import {ColorValue, StyleProp} from '../../StyleSheet/StyleSheet';
 import {ViewStyle} from '../../StyleSheet/StyleSheetTypes';
 import {
diff --git a/Libraries/Components/Slider/Slider.d.ts b/Libraries/Components/Slider/Slider.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {ImageURISource} from '../../Image/ImageSource';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ColorValue, StyleProp} from '../../StyleSheet/StyleSheet';
diff --git a/Libraries/Components/Switch/Switch.d.ts b/Libraries/Components/Switch/Switch.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ColorValue, StyleProp} from '../../StyleSheet/StyleSheet';
 import {ViewStyle} from '../../StyleSheet/StyleSheetTypes';
diff --git a/Libraries/Components/TextInput/TextInput.d.ts b/Libraries/Components/TextInput/TextInput.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor, TimerMixin} from 'Utilities';
+import {Constructor, TimerMixin} from '../../../types/Utilities';
 import {
   HostComponent,
   NativeMethods,
diff --git a/Libraries/Components/Touchable/Touchable.d.ts b/Libraries/Components/Touchable/Touchable.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Insets} from 'Utilities';
+import {Insets} from '../../../types/Utilities';
 import {GestureResponderEvent} from '../../Types/CoreEventTypes';
 
 /**
diff --git a/Libraries/Components/Touchable/TouchableHighlight.d.ts b/Libraries/Components/Touchable/TouchableHighlight.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor, TimerMixin} from 'Utilities';
+import {Constructor, TimerMixin} from '../../../types/Utilities';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {ColorValue, StyleProp} from '../../StyleSheet/StyleSheet';
 import {ViewStyle} from '../../StyleSheet/StyleSheetTypes';
diff --git a/Libraries/Components/Touchable/TouchableNativeFeedback.d.ts b/Libraries/Components/Touchable/TouchableNativeFeedback.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {ColorValue} from '../../StyleSheet/StyleSheet';
 import {TouchableMixin} from './Touchable';
 
diff --git a/Libraries/Components/Touchable/TouchableOpacity.d.ts b/Libraries/Components/Touchable/TouchableOpacity.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor, TimerMixin} from 'Utilities';
+import {Constructor, TimerMixin} from '../../../types/Utilities';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 import {TVParallaxProperties} from '../View/ViewPropTypes';
 import {TouchableMixin} from './Touchable';
diff --git a/Libraries/Components/Touchable/TouchableWithoutFeedback.d.ts b/Libraries/Components/Touchable/TouchableWithoutFeedback.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor, Insets, TimerMixin} from 'Utilities';
+import {Constructor, Insets, TimerMixin} from '../../../types/Utilities';
 import {StyleProp} from '../../StyleSheet/StyleSheet';
 import {ViewStyle} from '../../StyleSheet/StyleSheetTypes';
 import {
diff --git a/Libraries/Components/View/View.d.ts b/Libraries/Components/View/View.d.ts
@@ -8,7 +8,7 @@
  */
 
 import type * as React from 'react';
-import {Constructor} from 'Utilities';
+import {Constructor} from '../../../types/Utilities';
 import {ViewProps} from './ViewPropTypes';
 import {NativeMethods} from '../../Renderer/shims/ReactNativeTypes';
 
diff --git a/Libraries/Image/Image.d.ts b/Libraries/Image/Image.d.ts
@@ -8,7 +8,7 @@
  */
 
 import * as React from 'react';
-import {Constructor, Insets} from 'Utilities';
+import {Constructor, Insets} from '../../types/Utilities';
 import {AccessibilityProps} from '../Components/View/ViewAccessibility';
 import {NativeMethods} from '../Renderer/shims/ReactNativeTypes';
 import {StyleProp} from '../StyleSheet/StyleSheet';
diff --git a/Libraries/Renderer/implementations/ReactNativeRenderer.d.ts b/Libraries/Renderer/implementations/ReactNativeRenderer.d.ts
@@ -0,0 +1,149 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+import {GestureResponderEvent} from '../../Types/CoreEventTypes';
+
+/**
+ * Gesture recognition on mobile devices is much more complicated than web.
+ * A touch can go through several phases as the app determines what the user's intention is.
+ * For example, the app needs to determine if the touch is scrolling, sliding on a widget, or tapping.
+ * This can even change during the duration of a touch. There can also be multiple simultaneous touches.
+ *
+ * The touch responder system is needed to allow components to negotiate these touch interactions
+ * without any additional knowledge about their parent or child components.
+ * This system is implemented in ResponderEventPlugin.js, which contains further details and documentation.
+ *
+ * Best Practices
+ * Users can feel huge differences in the usability of web apps vs. native, and this is one of the big causes.
+ * Every action should have the following attributes:
+ *      Feedback/highlighting- show the user what is handling their touch, and what will happen when they release the gesture
+ *      Cancel-ability- when making an action, the user should be able to abort it mid-touch by dragging their finger away
+ *
+ * These features make users more comfortable while using an app,
+ * because it allows people to experiment and interact without fear of making mistakes.
+ *
+ * TouchableHighlight and Touchable*
+ * The responder system can be complicated to use.
+ * So we have provided an abstract Touchable implementation for things that should be "tappable".
+ * This uses the responder system and allows you to easily configure tap interactions declaratively.
+ * Use TouchableHighlight anywhere where you would use a button or link on web.
+ */
+export interface GestureResponderHandlers {
+  /**
+   * A view can become the touch responder by implementing the correct negotiation methods.
+   * There are two methods to ask the view if it wants to become responder:
+   */
+
+  /**
+   * Does this view want to become responder on the start of a touch?
+   */
+  onStartShouldSetResponder?:
+    | ((event: GestureResponderEvent) => boolean)
+    | undefined;
+
+  /**
+   * Called for every touch move on the View when it is not the responder: does this view want to "claim" touch responsiveness?
+   */
+  onMoveShouldSetResponder?:
+    | ((event: GestureResponderEvent) => boolean)
+    | undefined;
+
+  /**
+   * If the View returns true and attempts to become the responder, one of the following will happen:
+   */
+
+  onResponderEnd?: ((event: GestureResponderEvent) => void) | undefined;
+
+  /**
+   * The View is now responding for touch events.
+   * This is the time to highlight and show the user what is happening
+   */
+  onResponderGrant?: ((event: GestureResponderEvent) => void) | undefined;
+
+  /**
+   * Something else is the responder right now and will not release it
+   */
+  onResponderReject?: ((event: GestureResponderEvent) => void) | undefined;
+
+  /**
+   * If the view is responding, the following handlers can be called:
+   */
+
+  /**
+   * The user is moving their finger
+   */
+  onResponderMove?: ((event: GestureResponderEvent) => void) | undefined;
+
+  /**
+   * Fired at the end of the touch, ie "touchUp"
+   */
+  onResponderRelease?: ((event: GestureResponderEvent) => void) | undefined;
+
+  onResponderStart?: ((event: GestureResponderEvent) => void) | undefined;
+
+  /**
+   *  Something else wants to become responder.
+   *  Should this view release the responder? Returning true allows release
+   */
+  onResponderTerminationRequest?:
+    | ((event: GestureResponderEvent) => boolean)
+    | undefined;
+
+  /**
+   * The responder has been taken from the View.
+   * Might be taken by other views after a call to onResponderTerminationRequest,
+   * or might be taken by the OS without asking (happens with control center/ notification center on iOS)
+   */
+  onResponderTerminate?: ((event: GestureResponderEvent) => void) | undefined;
+
+  /**
+   * onStartShouldSetResponder and onMoveShouldSetResponder are called with a bubbling pattern,
+   * where the deepest node is called first.
+   * That means that the deepest component will become responder when multiple Views return true for *ShouldSetResponder handlers.
+   * This is desirable in most cases, because it makes sure all controls and buttons are usable.
+   *
+   * However, sometimes a parent will want to make sure that it becomes responder.
+   * This can be handled by using the capture phase.
+   * Before the responder system bubbles up from the deepest component,
+   * it will do a capture phase, firing on*ShouldSetResponderCapture.
+   * So if a parent View wants to prevent the child from becoming responder on a touch start,
+   * it should have a onStartShouldSetResponderCapture handler which returns true.
+   */
+  onStartShouldSetResponderCapture?:
+    | ((event: GestureResponderEvent) => boolean)
+    | undefined;
+
+  /**
+   * onStartShouldSetResponder and onMoveShouldSetResponder are called with a bubbling pattern,
+   * where the deepest node is called first.
+   * That means that the deepest component will become responder when multiple Views return true for *ShouldSetResponder handlers.
+   * This is desirable in most cases, because it makes sure all controls and buttons are usable.
+   *
+   * However, sometimes a parent will want to make sure that it becomes responder.
+   * This can be handled by using the capture phase.
+   * Before the responder system bubbles up from the deepest component,
+   * it will do a capture phase, firing on*ShouldSetResponderCapture.
+   * So if a parent View wants to prevent the child from becoming responder on a touch start,
+   * it should have a onStartShouldSetResponderCapture handler which returns true.
+   */
+  onMoveShouldSetResponderCapture?:
+    | ((event: GestureResponderEvent) => boolean)
+    | undefined;
+}
+
+/**
+ * React Native also implements unstable_batchedUpdates
+ */
+export function unstable_batchedUpdates<A, B>(
+  callback: (a: A, b: B) => any,
+  a: A,
+  b: B,
+): void;
+export function unstable_batchedUpdates<A>(callback: (a: A) => any, a: A): void;
+export function unstable_batchedUpdates(callback: () => any): void;
diff --git a/Libraries/Renderer/shims/ReactNativeTypes.d.ts b/Libraries/Renderer/shims/ReactNativeTypes.d.ts
diff --git a/Libraries/Text/Text.d.ts b/Libraries/Text/Text.d.ts
diff --git a/scripts/run-ci-e2e-tests.js b/scripts/run-ci-e2e-tests.js
diff --git a/template/App.tsx b/template/App.tsx
diff --git a/template/__tests__/App-test.tsx b/template/__tests__/App-test.tsx
diff --git a/template/_buckconfig b/template/_buckconfig
diff --git a/template/_eslintrc.js b/template/_eslintrc.js
diff --git a/template/_flowconfig b/template/_flowconfig
diff --git a/template/package.json b/template/package.json
diff --git a/template/tsconfig.json b/template/tsconfig.json
