Skip to content

Commit c356309

Browse files
fkgozalifacebook-github-bot
authored andcommitted
Keep ES6Proxy enabled in bridgeless mode (#43538)
Summary: Pull Request resolved: #43538 The Hermes RuntimeConfig for bridgeless accidentally force-disabled ES6Proxy, resulting in #43523 Let's remove the incorrect override. To test using RNTester, add the following change: ``` diff --git a/packages/rn-tester/js/RNTesterAppShared.js b/packages/rn-tester/js/RNTesterAppShared.js index 87cb6b6..f2512d09c5a 100644 --- a/packages/rn-tester/js/RNTesterAppShared.js +++ b/packages/rn-tester/js/RNTesterAppShared.js @@ -50,6 +50,8 @@ const RNTesterApp = ({ ); const colorScheme = useColorScheme(); + new Proxy({}, {}); + const { activeModuleKey, activeModuleTitle, ``` Before this change, RNTester will get an error at start-up. After, the app loads correctly. Changelog: [General][Fixed] Correctly keep ES6Proxy for bridgeless mode Reviewed By: cortinico Differential Revision: D55045780 fbshipit-source-id: 666b99712d35622f87d42f22a4611851df67d905
1 parent bfb0319 commit c356309

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

packages/react-native/ReactCommon/react/runtime/hermes/HermesInstance.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,6 @@ std::unique_ptr<JSRuntime> HermesInstance::createJSRuntime(
137137
.withAllocInYoung(false)
138138
.withRevertToYGAtTTI(true)
139139
.build())
140-
.withES6Proxy(false)
141140
.withEnableSampleProfiling(true)
142141
.withMicrotaskQueue(ReactNativeFeatureFlags::enableMicrotasks())
143142
.withVMExperimentFlags(vmExperimentFlags);

0 commit comments

Comments
 (0)