Skip to content

Commit 96fe4a5

Browse files
javachefacebook-github-bot
authored andcommitted
Move default trackingName as undefined to RCTNetworking (#51703)
Summary: Pull Request resolved: #51703 Feedback on D75516619 Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D75544422 fbshipit-source-id: f6c5e0090946b7861fd9cd9646e1b06b7c6a05d2
1 parent 69b56a4 commit 96fe4a5

5 files changed

Lines changed: 8 additions & 8 deletions

File tree

packages/react-native/Libraries/Network/RCTNetworking.android.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ const RCTNetworking = {
5959

6060
sendRequest(
6161
method: string,
62-
trackingName: ?string,
62+
trackingName: string | void,
6363
url: string,
6464
headers: Object,
6565
data: RequestBody,

packages/react-native/Libraries/Network/RCTNetworking.ios.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const RCTNetworking = {
2929

3030
sendRequest(
3131
method: string,
32-
trackingName: ?string,
32+
trackingName: string | void,
3333
url: string,
3434
headers: {...},
3535
data: RequestBody,

packages/react-native/Libraries/Network/RCTNetworking.js.flow

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ declare const RCTNetworking: interface {
2525

2626
sendRequest(
2727
method: string,
28-
trackingName: ?string,
28+
trackingName: string | void,
2929
url: string,
3030
headers: {...},
3131
data: RequestBody,

packages/react-native/Libraries/Network/XMLHttpRequest.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ class XMLHttpRequest extends EventTarget {
170170
_sent: boolean;
171171
_url: ?string = null;
172172
_timedOut: boolean = false;
173-
_trackingName: string | void = undefined;
173+
_trackingName: ?string;
174174
_incrementalEvents: boolean = false;
175175
_startTime: ?number = null;
176176
_performanceLogger: IPerformanceLogger = GlobalPerformanceLogger;
@@ -534,7 +534,7 @@ class XMLHttpRequest extends EventTarget {
534534
/**
535535
* Custom extension for tracking origins of request.
536536
*/
537-
setTrackingName(trackingName: string | void): XMLHttpRequest {
537+
setTrackingName(trackingName: ?string): XMLHttpRequest {
538538
this._trackingName = trackingName;
539539
return this;
540540
}
@@ -632,7 +632,7 @@ class XMLHttpRequest extends EventTarget {
632632
);
633633
RCTNetworking.sendRequest(
634634
this._method,
635-
this._trackingName,
635+
this._trackingName ?? undefined,
636636
this._url,
637637
this._headers,
638638
data,

packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5916,7 +5916,7 @@ exports[`public API should not change unintentionally Libraries/Network/RCTNetwo
59165916
): EventSubscription,
59175917
sendRequest(
59185918
method: string,
5919-
trackingName: ?string,
5919+
trackingName: string | void,
59205920
url: string,
59215921
headers: { ... },
59225922
data: RequestBody,
@@ -6010,7 +6010,7 @@ declare class XMLHttpRequest extends EventTarget {
60106010
getAllResponseHeaders(): ?string;
60116011
getResponseHeader(header: string): ?string;
60126012
setRequestHeader(header: string, value: any): void;
6013-
setTrackingName(trackingName: string | void): XMLHttpRequest;
6013+
setTrackingName(trackingName: ?string): XMLHttpRequest;
60146014
setPerformanceLogger(performanceLogger: IPerformanceLogger): XMLHttpRequest;
60156015
open(method: string, url: string, async: ?boolean): void;
60166016
send(data: any): void;

0 commit comments

Comments
 (0)