Skip to content

Commit 7bebfc9

Browse files
huntiefacebook-github-bot
authored andcommitted
Remove "Open Debugger" action under JSC (#41535)
Summary: ## Context **Remote JS Debugging removal** In React Native 0.73, we have deprecated Remote JS Debugging (execution of JavaScript in a separate V8 process) and also removed the Dev Menu launcher (#36754). ## This diff Follows D46187942 — this option wasn't correctly removed for Android when running JSC. This is now consistent with iOS. Changelog: [Android][Changed] "Open Debugger" is no longer available for remote JS debugging from the Dev Menu (non-Hermes). Please use `NativeDevSettings.setIsDebuggingRemotely()`. Reviewed By: blakef Differential Revision: D50555095
1 parent f4d006a commit 7bebfc9

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -363,15 +363,16 @@ public void onOptionSelected() {
363363
}
364364
});
365365

366-
if (mDevSettings.isDeviceDebugEnabled()) {
367-
// On-device JS debugging (CDP). Render action to open debugger frontend.
366+
if (mDevSettings.isRemoteJSDebugEnabled()) {
367+
// [Deprecated in React Native 0.73] Remote JS debugging. Handle reload
368+
// via external JS executor. This capability will be removed in a future
369+
// release.
370+
mDevSettings.setRemoteJSDebugEnabled(false);
371+
handleReloadJS();
372+
}
368373

369-
// Reset the old debugger setting so no one gets stuck.
370-
// TODO: Remove in a few weeks.
371-
if (mDevSettings.isRemoteJSDebugEnabled()) {
372-
mDevSettings.setRemoteJSDebugEnabled(false);
373-
handleReloadJS();
374-
}
374+
if (mDevSettings.isDeviceDebugEnabled() && !mDevSettings.isRemoteJSDebugEnabled()) {
375+
// On-device JS debugging (CDP). Render action to open debugger frontend.
375376
options.put(
376377
mApplicationContext.getString(R.string.catalyst_debug_open),
377378
() ->

0 commit comments

Comments
 (0)