Skip to content

Commit 475a156

Browse files
cipolleschifacebook-github-bot
authored andcommitted
Make React-jsiinspector depends on hermes-engine to fix Dynamic Frameworks (#43081)
Summary: Pull Request resolved: #43081 When Hermes i used, it is hermes that provides JSI to React Native and not React-jsi. This is required to fix the ODR violatons. Dynamic frameworks requires that all the dependencies are declared explicitly, and missing the `hermes-engine` dependency was breaking the dependency graph. ## Changelog [Internal] - Make JSIInspector depends o hermes-engine Reviewed By: motiz88 Differential Revision: D53901016 fbshipit-source-id: a511719647e6203d082696fd572593fd851a1dde
1 parent 8ff05b5 commit 475a156

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

packages/react-native/ReactCommon/jsinspector-modern/React-jsinspector.podspec

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,4 +53,8 @@ Pod::Spec.new do |s|
5353
s.dependency "DoubleConversion"
5454
s.dependency "React-runtimeexecutor", version
5555
s.dependency "React-jsi"
56+
if ENV["USE_HERMES"] == nil || ENV["USE_HERMES"] == "1"
57+
s.dependency "hermes-engine"
58+
end
59+
5660
end

0 commit comments

Comments
 (0)