Commit 0b22b95
ReactViewGroup - utilize onViewAdded/Removed (#47890)
Summary:
Pull Request resolved: #47890
The fix in [#40859](#40859) overrode every possible add or remove to ensure completeness, but all paths should also call onViewAdded/onViewRemoved via:
- `addView`/`addViewInLayout` -> [addViewInner](https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-15.0.0_r5/core/java/android/view/ViewGroup.java#5310)
- `removeView`/`removeViewInLayout` -> [removeViewInternal](https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-15.0.0_r5/core/java/android/view/ViewGroup.java#5606)
- `removeViews`/`removeViewsInLayout` -> [removeViewsInternal](https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-15.0.0_r5/core/java/android/view/ViewGroup.java#5714)
Changelog: [Android][Changed] Consolidated ReactViewGroup add/remove overrides
Reviewed By: javache
Differential Revision: D66320586
fbshipit-source-id: aaf16af5ad87789f575fcb79dcf31f5686002b2d1 parent 3d1a505 commit 0b22b95
2 files changed
Lines changed: 11 additions & 66 deletions
File tree
- packages/react-native/ReactAndroid
- api
- src/main/java/com/facebook/react/views/view
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7823 | 7823 | | |
7824 | 7824 | | |
7825 | 7825 | | |
7826 | | - | |
7827 | | - | |
7828 | 7826 | | |
7829 | 7827 | | |
7830 | 7828 | | |
| |||
7847 | 7845 | | |
7848 | 7846 | | |
7849 | 7847 | | |
7850 | | - | |
7851 | | - | |
7852 | | - | |
7853 | | - | |
7854 | | - | |
| 7848 | + | |
| 7849 | + | |
7855 | 7850 | | |
7856 | 7851 | | |
7857 | 7852 | | |
| |||
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java
Lines changed: 9 additions & 59 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
524 | 524 | | |
525 | 525 | | |
526 | 526 | | |
527 | | - | |
| 527 | + | |
| 528 | + | |
528 | 529 | | |
529 | 530 | | |
530 | 531 | | |
531 | | - | |
| 532 | + | |
532 | 533 | | |
533 | 534 | | |
534 | 535 | | |
535 | 536 | | |
| 537 | + | |
536 | 538 | | |
537 | 539 | | |
538 | | - | |
| 540 | + | |
| 541 | + | |
539 | 542 | | |
540 | 543 | | |
541 | 544 | | |
542 | | - | |
| 545 | + | |
543 | 546 | | |
544 | 547 | | |
545 | | - | |
| 548 | + | |
546 | 549 | | |
547 | 550 | | |
548 | 551 | | |
549 | 552 | | |
550 | | - | |
551 | | - | |
552 | | - | |
553 | | - | |
554 | | - | |
555 | | - | |
556 | | - | |
557 | | - | |
558 | | - | |
559 | | - | |
560 | | - | |
561 | | - | |
562 | | - | |
563 | | - | |
564 | | - | |
565 | | - | |
566 | | - | |
567 | | - | |
568 | | - | |
569 | | - | |
570 | | - | |
571 | | - | |
572 | | - | |
573 | | - | |
574 | | - | |
575 | | - | |
576 | | - | |
577 | | - | |
578 | | - | |
579 | | - | |
580 | | - | |
581 | | - | |
582 | | - | |
583 | | - | |
584 | | - | |
585 | | - | |
586 | | - | |
587 | | - | |
588 | | - | |
589 | | - | |
590 | | - | |
591 | | - | |
592 | | - | |
593 | | - | |
594 | | - | |
595 | | - | |
596 | | - | |
597 | | - | |
598 | | - | |
599 | | - | |
600 | | - | |
601 | | - | |
602 | | - | |
603 | | - | |
| 553 | + | |
604 | 554 | | |
605 | 555 | | |
606 | 556 | | |
| |||
0 commit comments