Migrate to Kotlin - ReactInstanceDevHelper (#50517)

Summary:
Pull Request resolved: #50517

This diff migrates the following file to Kotlin - ReactInstanceDevHelper
as part of our ongoing effort of migrating the codebase to Kotlin

Changelog:
[Android] [Changed] - Migrate to Kotlin - ReactInstanceDevHelper. Some users implementing this class in Kotlin could have breakages. As this is a devtools/frameworks API we're not marking this as breaking.

Reviewed By: javache

Differential Revision: D72555226

fbshipit-source-id: e7e5523c56de8697def0a509c03e9fe89c6d5839

Author: cortinico

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

@@ -374,7 +374,7 @@ public void destroyRootView(View rootView) {
       }
 
       @Override
-      public void reload(String s) {
+      public void reload(String reason) {
         // no-op not implemented for Bridge Mode
       }
 

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java

@@ -38,6 +38,7 @@
 import com.facebook.react.R;
 import com.facebook.react.bridge.DefaultJSExceptionHandler;
 import com.facebook.react.bridge.JSBundleLoader;
+import com.facebook.react.bridge.JavaScriptExecutorFactory;
 import com.facebook.react.bridge.ReactContext;
 import com.facebook.react.bridge.ReactMarker;
 import com.facebook.react.bridge.ReactMarkerConstants;
@@ -540,7 +541,13 @@ public View getView(int position, @Nullable View convertView, ViewGroup parent)
 
   private @Nullable String getJSExecutorDescription() {
     try {
-      return getReactInstanceDevHelper().getJavaScriptExecutorFactory().toString();
+      JavaScriptExecutorFactory factory =
+          getReactInstanceDevHelper().getJavaScriptExecutorFactory();
+      if (factory != null) {
+        return factory.toString();
+      } else {
+        return null;
+      }
     } catch (IllegalStateException e) {
       return null;
     }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReactInstanceDevHelper.java

@@ -0,0 +1,44 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.devsupport
+
+import android.app.Activity
+import android.view.View
+import com.facebook.react.bridge.JSBundleLoader
+import com.facebook.react.bridge.JavaScriptExecutorFactory
+import com.facebook.react.bridge.ReactContext
+import com.facebook.react.devsupport.interfaces.DevSupportManager
+import com.facebook.react.interfaces.TaskInterface
+
+/**
+ * Interface used by [DevSupportManager] for accessing some fields and methods of [ReactHost] for
+ * the purpose of displaying and handling developer menu options.
+ */
+public interface ReactInstanceDevHelper {
+
+  /** Get reference to top level [Activity] attached to react context */
+  public val currentActivity: Activity?
+
+  public val javaScriptExecutorFactory: JavaScriptExecutorFactory
+
+  public val currentReactContext: ReactContext?
+
+  /** Notify react instance manager about new JS bundle version downloaded from the server. */
+  public fun onJSBundleLoadedFromServer()
+
+  /** Request to toggle the react element inspector. */
+  public fun toggleElementInspector()
+
+  public fun createRootView(appKey: String): View?
+
+  public fun destroyRootView(rootView: View)
+
+  public fun reload(reason: String)
+
+  public fun loadBundle(bundleLoader: JSBundleLoader): TaskInterface<Boolean>
+}

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReactInstanceDevHelper.kt

@@ -26,6 +26,15 @@ import com.facebook.react.modules.core.DeviceEventManagerModule
 internal class ReactHostImplDevHelper(private val delegate: ReactHostImpl) :
     ReactInstanceDevHelper {
 
+  override val currentActivity: Activity?
+    get() = delegate.lastUsedActivity
+
+  override val javaScriptExecutorFactory: JavaScriptExecutorFactory
+    get() = throw IllegalStateException("Not implemented for bridgeless mode")
+
+  override val currentReactContext: ReactContext?
+    get() = delegate.currentReactContext
+
   override fun onJSBundleLoadedFromServer() {
     // Not implemented, only referenced by BridgeDevSupportManager
   }
@@ -37,12 +46,6 @@ internal class ReactHostImplDevHelper(private val delegate: ReactHostImpl) :
         ?.emit("toggleElementInspector", null)
   }
 
-  override fun getCurrentActivity(): Activity? = delegate.lastUsedActivity
-
-  override fun getJavaScriptExecutorFactory(): JavaScriptExecutorFactory {
-    throw IllegalStateException("Not implemented for bridgeless mode")
-  }
-
   override fun createRootView(appKey: String): View? {
     val currentActivity = currentActivity
     if (currentActivity != null && !delegate.isSurfaceWithModuleNameAttached(appKey)) {
@@ -59,12 +62,10 @@ internal class ReactHostImplDevHelper(private val delegate: ReactHostImpl) :
     // Not implemented, only referenced by BridgeDevSupportManager
   }
 
-  override fun reload(s: String) {
-    delegate.reload(s)
+  override fun reload(reason: String) {
+    delegate.reload(reason)
   }
 
   override fun loadBundle(bundleLoader: JSBundleLoader): TaskInterface<Boolean> =
       delegate.loadBundle(bundleLoader)
-
-  override fun getCurrentReactContext(): ReactContext? = delegate.currentReactContext
 }