Skip to content

fix: Disable reload-and-record action for React Native entrypoint #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: Disable reload-and-record action for React Native entrypoint #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions front_end/core/root/Runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ export const enum ExperimentName {
// React Native-specific experiments - must mirror RNExperimentName above
JS_HEAP_PROFILER_ENABLE = RNExperimentName.JS_HEAP_PROFILER_ENABLE,
REACT_NATIVE_SPECIFIC_UI = RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
NOT_REACT_NATIVE_SPECIFIC_UI = '!' + RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
ENABLE_PERFORMANCE_PANEL = RNExperimentName.ENABLE_PERFORMANCE_PANEL,
ENABLE_NETWORK_PANEL = RNExperimentName.ENABLE_NETWORK_PANEL,
}
Expand Down
2 changes: 1 addition & 1 deletion front_end/panels/timeline/timeline-meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ UI.ActionRegistration.registerActionExtension({
shortcut: 'Meta+Shift+E',
},
],
experiment: Root.Runtime.ExperimentName.REACT_NATIVE_SPECIFIC_UI, // See https://docs.google.com/document/d/1_mtLIHEd9bFQN4xWBSVDR357GaRo56khB1aOxgWDeu4/edit?tab=t.0 for context.
experiment: Root.Runtime.ExperimentName.NOT_REACT_NATIVE_SPECIFIC_UI, // See https://docs.google.com/document/d/1_mtLIHEd9bFQN4xWBSVDR357GaRo56khB1aOxgWDeu4/edit?tab=t.0 for context.
});

UI.ActionRegistration.registerActionExtension({
Expand Down
1 change: 1 addition & 0 deletions front_end/testing/EnvironmentHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ const REGISTERED_EXPERIMENTS = [
Root.Runtime.ExperimentName.TIMELINE_SHOW_POST_MESSAGE_EVENTS,
Root.Runtime.ExperimentName.TIMELINE_ENHANCED_TRACES,
Root.Runtime.ExperimentName.REACT_NATIVE_SPECIFIC_UI,
Root.Runtime.ExperimentName.NOT_REACT_NATIVE_SPECIFIC_UI,
];

export async function initializeGlobalVars({reset = true} = {}) {
Expand Down
Loading