fix: 'Go to symbol' now includes methods inside a class (#2109)

Summary:
Logic was added to post-process symbols inside a ClassDef.
it allows Stmt::FunctionDef to remain simple (always creating a FUNCTION), and shifts the responsibility of context-awareness (knowing it is a method) to the parent ClassDef.
Any child symbol with SymbolKind::FUNCTION is now converted to SymbolKind::METHOD

Fixes #2051

Pull Request resolved: #2109

Test Plan:
I updated the existing test
test_document_symbols_normal_file in pyrefly/lib/test/lsp/lsp_interaction/document_symbols.rs
The test uses an existing file normal.py which contains NormalClass and normal_method.
I updated the test assertion to verify that normal_method inside NormalClass has SymbolKind::METHOD.

Reviewed By: grievejia

Differential Revision: D90689263

Pulled By: stroxler

fbshipit-source-id: ac0e6f8702e4bbc0d7b646f084615152668dcea5

Author: Karman-singh15

pyrefly/lib/lsp/non_wasm/document_symbols.rs

@@ -61,6 +61,14 @@ fn recurse_stmt_adding_symbols<'a>(
         Stmt::ClassDef(stmt_class_def) => {
             let mut children = Vec::new();
             children.append(&mut recursed_symbols);
+
+            // Functions defined inside a class are methods.
+            for child in &mut children {
+                if child.kind == lsp_types::SymbolKind::FUNCTION {
+                    child.kind = lsp_types::SymbolKind::METHOD;
+                }
+            }
+
             let name = match stmt_class_def.name.as_str() {
                 "" => "unknown".to_owned(),
                 name => name.to_owned(),

pyrefly/lib/test/lsp/document_symbols.rs

@@ -189,7 +189,7 @@ class MyClass:
     "children": [
       {
         "name": "__init__",
-        "kind": 12,
+        "kind": 6,
         "range": {
           "start": {
             "line": 4,
@@ -214,7 +214,7 @@ class MyClass:
       },
       {
         "name": "method1",
-        "kind": 12,
+        "kind": 6,
         "range": {
           "start": {
             "line": 7,
@@ -239,7 +239,7 @@ class MyClass:
       },
       {
         "name": "method2",
-        "kind": 12,
+        "kind": 6,
         "range": {
           "start": {
             "line": 10,
@@ -396,7 +396,7 @@ result = y.method()
       },
       {
         "name": "method",
-        "kind": 12,
+        "kind": 6,
         "range": {
           "start": {
             "line": 12,
@@ -689,7 +689,7 @@ result = y.method()
       },
       {
         "name": "method",
-        "kind": 12,
+        "kind": 6,
         "range": {
           "start": {
             "line": 12,
@@ -976,7 +976,7 @@ items: List[str] = ["a", "b", "c"]
       },
       {
         "name": "method",
-        "kind": 12,
+        "kind": 6,
         "range": {
           "start": {
             "line": 14,

pyrefly/lib/test/lsp/lsp_interaction/document_symbols.rs

@@ -101,11 +101,20 @@ fn test_document_symbols_normal_file() {
                 .iter()
                 .any(|s| s.name == "normal_function" && s.kind == lsp_types::SymbolKind::FUNCTION);
 
-            let has_class = symbols
+            let class_symbol = symbols
                 .iter()
-                .any(|s| s.name == "NormalClass" && s.kind == lsp_types::SymbolKind::CLASS);
+                .find(|s| s.name == "NormalClass" && s.kind == lsp_types::SymbolKind::CLASS);
+
+            let has_class_and_method = match class_symbol {
+                Some(c) => c.children.as_ref().is_some_and(|children| {
+                    children.iter().any(|s| {
+                        s.name == "normal_method" && s.kind == lsp_types::SymbolKind::METHOD
+                    })
+                }),
+                None => false,
+            };
 
-            has_function && has_class
+            has_function && has_class_and_method
         })
         .unwrap();