Fix OSS build#463
Closed
mszabo-wikia wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
FWIW, using |
nrmmota
reviewed
Mar 25, 2025
mszabo-wikia
force-pushed
the
fix-oss-build
branch
from
c2db788 to
08cd99f
Compare
mszabo-wikia
added a commit
to mszabo-wikia/fbthrift
that referenced
this pull request
Apr 18, 2025
This was added in D73136906 but is missing from CMakeLists.txt. Spotted via facebook/mcrouter#463: ``` /usr/bin/ld: /home/runner/work/mcrouter/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(ThriftServer.cpp.o): in function `apache::thrift::ThriftServer::processModulesSpecification(apache::thrift::ThriftServer::ModulesSpecification&&)::ServiceInterceptorsCollector::addModule(apache::thrift::ThriftServer::ModulesSpecification::Info const&)': ThriftServer.cpp:(.text+0x1d1c3): undefined reference to `apache::thrift::ServiceInterceptorQualifiedName::get() const' ```
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Apr 21, 2025
Summary: This was added in D73136906 but is missing from CMakeLists.txt. Spotted via facebook/mcrouter#463: ``` /usr/bin/ld: /home/runner/work/mcrouter/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(ThriftServer.cpp.o): in function `apache::thrift::ThriftServer::processModulesSpecification(apache::thrift::ThriftServer::ModulesSpecification&&)::ServiceInterceptorsCollector::addModule(apache::thrift::ThriftServer::ModulesSpecification::Info const&)': ThriftServer.cpp:(.text+0x1d1c3): undefined reference to `apache::thrift::ServiceInterceptorQualifiedName::get() const' ``` Pull Request resolved: #648 Reviewed By: vitaut Differential Revision: D73378222 Pulled By: iahs fbshipit-source-id: 676caa94c1566dc1b6275fc2cb4ba3043789cd42
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Apr 21, 2025
Summary: This was added in D73136906 but is missing from CMakeLists.txt. Spotted via facebook/mcrouter#463: ``` /usr/bin/ld: /home/runner/work/mcrouter/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(ThriftServer.cpp.o): in function `apache::thrift::ThriftServer::processModulesSpecification(apache::thrift::ThriftServer::ModulesSpecification&&)::ServiceInterceptorsCollector::addModule(apache::thrift::ThriftServer::ModulesSpecification::Info const&)': ThriftServer.cpp:(.text+0x1d1c3): undefined reference to `apache::thrift::ServiceInterceptorQualifiedName::get() const' ``` X-link: facebook/fbthrift#648 Reviewed By: vitaut Differential Revision: D73378222 Pulled By: iahs fbshipit-source-id: 676caa94c1566dc1b6275fc2cb4ba3043789cd42
mszabo-wikia
force-pushed
the
fix-oss-build
branch
2 times, most recently
from
5719668 to
353f2ad
Compare
mszabo-wikia
changed the title
mszabo-wikia
force-pushed
the
fix-oss-build
branch
from
353f2ad to
f9de886
Compare
mszabo-wikia
force-pushed
the
fix-oss-build
branch
3 times, most recently
from
6407957 to
6e411f0
Compare
mszabo-wikia
force-pushed
the
fix-oss-build
branch
7 times, most recently
from
ff97c5f to
b0c802c
Compare
* folly requires fast_float >= 8.0.0 since facebook/folly@7aa9b2c, whereas Ubuntu 24.04 packages version 3.9.0. Add a build script for fast_float for use in the OSS build and use it instead of the distribution package. * Add mcrouter/lib/WeightedCh3RvHashFunc.cpp and the corresponding header to the Automake build. * Add missing dependencies for generated MemcacheService types. * Fix fmtlib link order, remove duplicate link line entries.
mszabo-wikia
force-pushed
the
fix-oss-build
branch
from
b0c802c to
b37d0ad
Compare
Contributor
Contributor
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jul 10, 2025
Summary: * folly requires fast_float >= 8.0.0 since facebook/folly@7aa9b2c, whereas Ubuntu 24.04 packages version 3.9.0. Add a build script for fast_float for use in the OSS build and use it instead of the distribution package. * Add mcrouter/lib/WeightedCh3RvHashFunc.cpp and the corresponding header to the Automake build. * Add missing dependencies for generated MemcacheService types. * Fix fmtlib link order, remove duplicate link line entries. X-link: facebook/mcrouter#463 Reviewed By: stuclar Differential Revision: D78122316 Pulled By: disylh fbshipit-source-id: 3e531f8ffc1071128b6396abd0e24723a3edc6e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.