Skip to content

Cache JestHook emitters #8746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2019
Merged

Cache JestHook emitters #8746

merged 2 commits into from
Aug 3, 2019

Conversation

@Connormiha
Copy link
Contributor

@Connormiha Connormiha commented Jul 24, 2019

Summary

Just cached JestHookSubscriber and JestHookEmitter to avoid creating new object on each getSubscriber(), getEmitter() calls.

Test plan

scotthovestadt
scotthovestadt reviewed Jul 24, 2019
View reviewed changes
Copy link
Contributor

@scotthovestadt scotthovestadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea makes sense. Want to take it a step further and switch the data structure of this._listeners to a Map for more perf wins?

@Connormiha
Copy link
Contributor Author

Connormiha commented Jul 25, 2019

The idea makes sense. Want to take it a step further and switch the data structure of this._listeners to a Map for more perf wins?

This may impair readability and convenience.

hooks.getEmitter().onTestRunComplete(results);

vs

hooks.getEmitter().get('onTestRunComplete')(results);

rogeliog
rogeliog approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@rogeliog rogeliog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scotthovestadt
Copy link
Contributor

scotthovestadt commented Aug 3, 2019

Let's make sure this gets in for the release-- just needs a changelog.

@Connormiha Connormiha force-pushed the cache-jest-hooks-emitters branch from 2a4d7dc to f96a3b9 Compare August 3, 2019 08:51
@Connormiha
Copy link
Contributor Author

Connormiha commented Aug 3, 2019

Let's make sure this gets in for the release-- just needs a changelog.

done @scotthovestadt

@SimenB SimenB merged commit cff67fd into jestjs:master Aug 3, 2019
@snyk-bot snyk-bot mentioned this pull request Sep 2, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
This was referenced Dec 31, 2019
Open
Open
This was referenced Jan 7, 2020
Open
Open
Open
Open
This was referenced Jan 21, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 30, 2020
Closed
@github-actions
Copy link

github-actions bot commented May 11, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

+2 more reviewers

@rogeliog rogeliog rogeliog approved these changes

@scotthovestadt scotthovestadt scotthovestadt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Connormiha @scotthovestadt @rogeliog @SimenB @facebook-github-bot