add filename for obsolete snapshot file #8665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new property filesRemovedList
This comment has been minimized.
This comment has been minimized.
SimenB
approved these changes
Jul 9, 2019
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
This is great, thanks! Will need to figure out why CI fails, but the code LGTM
This comment has been minimized.
This comment has been minimized.
SimenB
reviewed
Jul 9, 2019
SimenB
reviewed
Jul 9, 2019
SimenB
reviewed
Jul 9, 2019
Connormiha
reviewed
Jul 12, 2019
jeysal
approved these changes
Jul 26, 2019
Collaborator
jeysal
left a comment
jeysal
left a comment
There was a problem hiding this comment.
LGTM! Test result property naming getting awkward but I guess we'll have to live with that as anything else is too breaking
Contributor
Author
|
🎉 |
This was referenced Dec 31, 2019
This was referenced Jan 7, 2020
This was referenced Jan 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a snapshot exists that's completely redundant because there's no test file that generates it, jest will report it found a obsolete snapshot:
Especially on a CI this can be not particularity useful, as there is no information on what's actually gone wrong, and the user cannot run
-uon CI.Test plan
I have added e2e test called
snapshot-unknown. This demonstrated the output or the cli reporter when there are 2 unknown snapshots. It should look like this:This addresses:
#5005 (comment)