jest-snapshot: Improve report when matcher fails, part 14

[pedrottimark]

Summary

4 snapshot matchers

Correct: matcher name in regular black

Complete:

• modifiers .rejects, .resolves, or .not
• expected arguments name hint, properties, or snapshot

Clear:

• short labels and aligned property values
• snapshot key name value as template literal same as in .snap file
• optional snapshot name in green hint in bold font weight

Consistent: 'Received function did not throw' from toThrow matcher

Residue:

• display matcher hint with more existing errors
• BREAKING: throw errors for inconsistent expected arguments and received values
• refactor redundant logic for values and their descriptions for matcher hint

Test plan

Updated e2e tests:

criteria	file
2 snapshots	failures.test.ts.snap
1 snapshot	watchModeUpdateSnapshot.test.ts.snap
2 match strings	toMatchInlineSnapshot.test.ts
8 match strings	toMatchSnapshot.test.ts
1 match string	toThrowErrorMatchingInlineSnapshot.test.ts
2 match strings	toThrowErrorMatchingSnapshot.test.ts
1 error match string	snapshot.test.js

See also pictures in following comment.

[pedrottimark]

Example pictures baseline followed by improved

.toMatchSnapshot correct hint has both args, short label with optional name in green bold font weight, align values on same line as labels:

Updated according to #8132 (comment)

.resolves.toMatchSnapshot correct hint and short label with key in black:

Updated according to #8132 (comment)

.not.toMatchInlineSnapshot displays matcher hint:

Updated according to #8132 (comment)

.toThrowErrorMatchingSnapshot same “did not throw” message as .toThrow matcher:

.rejects.toThrowErrorMatchingInlineSnapshot correct and complete hint:

Updated according to #8132 (comment)

[thymikee]

I really like the direction it's going. Left a few inline comments to consider

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.