-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore: migrate jest-message-util to TypeScript #7834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8921737 to
4a7592c
Compare
| "dependencies": { | ||
| "@babel/code-frame": "^7.0.0", | ||
| "@jest/types": "^24.0.0", | ||
| "@types/stack-utils": "^1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved since it's part of the exported interface
ac24837 to
165430a
Compare
thymikee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
165430a to
e5c9ad5
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I've added a new package called
@jest/types(/cc @rubennorte) where we can stick shared type definitions that don't belong in a single package.(One could argue that
Configbelongs injest-config, butjest-configdepends onbabel,jsdometc which seems hefty when I just wantProjectConfigtypings).Built diff:
Test plan
Green CI